Zhen Qian

  • More
  • CR-31
  • finished reviewing
Looks good to me.

Looks good to me.

What if the name, url, or type of the attachment is null? Will that cause NPE?

What if the name, url, or type of the attachment is null? Will that cause NPE?

SAK-30352 performance improvement for SignUp tool
SAK-31051 return url string, instead of /access url, for Web Link resources (#2444)

* KNL-1430 detect true value of copyright Alert property

* SAK-31051 provide original URL string for Web Link resource type

* SAK-31051 changes after code review

* SAK-31051 added another ContentItem attribute (webLinkUrl) in the EntityFeed. This attribute will only have value when the resource item is of Web Link type

* SAK-31051 changed log level from into to warn inside Exception catch blocks

* SAK-31051 log message change

KNL-1430 detect true value of copyright Alert property (#2404)

* KNL-1430 detect true value of copyright Alert property

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

truncated URL String returned in content entity feed for Web Link resources
truncated URL String returned in content entity feed for Web Link resources
checks for resource copyright alert setting
checks for resource copyright alert setting
SAK-30211 changes after the code review

    • -1
    • +5
    /mailarchive/mailarchive-tool/tool/pom.xml
SAK-30211 changes after the code review

    • -1
    • +5
    /mailarchive/mailarchive-tool/tool/pom.xml
  • More
  • CR-28
  • finished reviewing
Looks good to me! The same SQL has been applied to ctqa DB instance successfully.

Looks good to me! The same SQL has been applied to ctqa DB instance successfully.

Done. Merged into CTools branch. Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

Done.

Merged into CTools branch.

Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

SAK-30211 added MailArchive entity provider

    • -6
    • +18
    /mailarchive/mailarchive-tool/tool/pom.xml
SAK-30211 added MailArchive entity provider

    • -6
    • +18
    /mailarchive/mailarchive-tool/tool/pom.xml
Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

replaced with mail.read

replaced with mail.read

addressed.

addressed.

SAK-30211 add MailArchive EntityProvider
SAK-30211 add MailArchive EntityProvider
same as above. Comments needed.

same as above. Comments needed.

could be "return !ac.isEmpty();"

could be "return !ac.isEmpty();"

please put some comments for the newly added functions.

please put some comments for the newly added functions.