Zhen Qian

Accordion

About

	Last Week	All Time
Commits:	0	2,171
Files changed:	0	198
Change in LOC:	0	280

Commit Activity

Committer Mappings

Zhen Qian is mapped to 3 committers over 3 repositories

Username zqian is mapped to:

Wednesday 09 Nov 2016

8:39 am

Zhen Qian

More
CR-31
finished reviewing

8:39 am

Zhen Qian

More
Re: CR-31
commented on review

Looks good to me.

Looks good to me.

Wednesday 02 Nov 2016

2:34 pm

Zhen Qian

More
Re: CR-29
commented on review

What if the name, url, or type of the attachment is null? Will that cause NPE?

What if the name, url, or type of the attachment is null? Will that cause NPE?

Thursday 20 Oct 2016

10:56 pm

Zhen Qian

More
88127
changed 5 files
CTools-2.9_from-2.9.x in SakaiContrib

SAK-30352 performance improvement for SignUp tool

- -0
- +1
/umich/PATCHED/signup/branches/CTools-2.9_from-2.9.x/patches.txt
- History
- Source
- Diff
/umich/PATCHED/.../patches.txt
- -3
- +3
/umich/PATCHED/signup/branches/CTools-2.9_from-2.9.x/api/src/java/org/sakaiproject/signup/hbm/SignupMeeting.hbm.xml
- History
- Source
- Diff
/umich/PATCHED/.../hbm/SignupMeeting.hbm.xml
- -1
- +1
/umich/PATCHED/signup/branches/CTools-2.9_from-2.9.x/pom.xml
- History
- Source
- Diff
/umich/PATCHED/.../pom.xml
- -4
- +19
/umich/PATCHED/signup/branches/CTools-2.9_from-2.9.x/tool/src/java/org/sakaiproject/signup/tool/jsf/SignupMeetingsBean.java
- History
- Source
- Diff
/umich/PATCHED/.../SignupMeetingsBean.java
- -1
- +1
/umich/PATCHED/signup/branches/CTools-2.9_from-2.9.x/api/src/java/org/sakaiproject/signup/hbm/SignupSite.hbm.xml
- History
- Source
- Diff
/umich/PATCHED/.../hbm/SignupSite.hbm.xml

Thursday 19 May 2016

1:15 pm

Zhen Qian

More
1b50242
changed 1 file
master, 12.x and 8 more in Sakai.Git

SAK-31051 return url string, instead of /access url, for Web Link resources (#2444)

* KNL-1430 detect true value of copyright Alert property

* SAK-31051 provide original URL string for Web Link resource type

* SAK-31051 changes after code review

* SAK-31051 added another ContentItem attribute (webLinkUrl) in the EntityFeed. This attribute will only have value when the resource item is of Web Link type

* SAK-31051 changed log level from into to warn inside Exception catch blocks

* SAK-31051 log message change

- -0
- +57
/content/content-tool/tool/src/java/org/sakaiproject/content/entityproviders/ContentEntityProvider.java
- History
- Source
- Diff
/content/.../ContentEntityProvider.java

Thursday 12 May 2016

3:52 pm

Zhen Qian

More
88ff6cc
changed 1 file
master, 12.x and 8 more in Sakai.Git

KNL-1430 detect true value of copyright Alert property (#2404)

* KNL-1430 detect true value of copyright Alert property

- -2
- +11
/kernel/kernel-impl/src/main/java/org/sakaiproject/content/impl/BaseContentService.java
- History
- Source
- Diff
/kernel/.../BaseContentService.java

Monday 02 May 2016

11:56 am

Zhen Qian

More
SAKTRUNK-116
Closed

11:56 am

Zhen Qian

More
Re: SAKTRUNK-116
replied to David Haines

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Friday 29 Apr 2016

1:50 pm

Zhen Qian

More
SAKTRUNK-116
started review

truncated URL String returned in content entity feed for Web Link resources

truncated URL String returned in content entity feed for Web Link resources

8:16 am

Zhen Qian

More
SAKTRUNK-115
Abandoned

8:15 am

Zhen Qian

More
SAKTRUNK-114
Closed

Tuesday 26 Apr 2016

10:53 am

Zhen Qian

10:52 am

Zhen Qian

More
SAKTRUNK-114
started review

checks for resource copyright alert setting

checks for resource copyright alert setting

Friday 26 Feb 2016

11:53 am

Zhen Qian

More
d4ab8cb
changed 2 files
master, 12.x and 8 more in Sakai.Git

SAK-30211 changes after the code review

- -1
- +5
/mailarchive/mailarchive-tool/tool/pom.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../pom.xml
- -5
- +10
/mailarchive/mailarchive-tool/tool/src/java/org/sakaiproject/mailarchive/entityprovider/MailArchiveEntityProvider.java
- History
- Source
- Diff
/mailarchive/.../MailArchiveEntityProvider.java

11:53 am

Zhen Qian

More
7566004
changed 2 files
11.x in Sakai.Git

SAK-30211 changes after the code review

- -1
- +5
/mailarchive/mailarchive-tool/tool/pom.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../pom.xml
- -5
- +10
/mailarchive/mailarchive-tool/tool/src/java/org/sakaiproject/mailarchive/entityprovider/MailArchiveEntityProvider.java
- History
- Source
- Diff
/mailarchive/.../MailArchiveEntityProvider.java

Monday 22 Feb 2016

2:04 pm

Zhen Qian

More
CR-28
finished reviewing

2:04 pm

Zhen Qian

More
Re: CR-28
commented on review

Looks good to me! The same SQL has been applied to ctqa DB instance successfully.

Looks good to me! The same SQL has been applied to ctqa DB instance successfully.

Monday 15 Feb 2016

2:29 pm

Zhen Qian

More
SAKTRUNK-113
Closed

2:28 pm

Zhen Qian

More
Re: SAKTRUNK-113
commented on review

Done. Merged into CTools branch. Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

Done.

Merged into CTools branch.

Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

2:26 pm

Zhen Qian

More
f55b068
changed 5 files
11.x in Sakai.Git

SAK-30211 added MailArchive entity provider

- -6
- +18
/mailarchive/mailarchive-tool/tool/pom.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../pom.xml
- -0
- +7
/mailarchive/mailarchive-tool/tool/src/bundle/mailarchive.properties
- History
- Source
/mailarchive/.../mailarchive.properties
- -0
- +822
/mailarchive/mailarchive-tool/tool/src/java/org/sakaiproject/mailarchive/entityprovider/MailArchiveEntityProvider.java
- History
- Source
/mailarchive/.../MailArchiveEntityProvider.java
- -0
- +21
/mailarchive/mailarchive-tool/tool/src/webapp/WEB-INF/applicationContext.xml
- History
- Source
/mailarchive/.../applicationContext.xml
- -0
- +11
/mailarchive/mailarchive-tool/tool/src/webapp/WEB-INF/web.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../web.xml

2:26 pm

Zhen Qian

More
575078a
changed 5 files
master, 12.x and 8 more in Sakai.Git

SAK-30211 added MailArchive entity provider

- -6
- +18
/mailarchive/mailarchive-tool/tool/pom.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../pom.xml
- -0
- +7
/mailarchive/mailarchive-tool/tool/src/bundle/mailarchive.properties
- History
- Source
/mailarchive/.../mailarchive.properties
- -0
- +822
/mailarchive/mailarchive-tool/tool/src/java/org/sakaiproject/mailarchive/entityprovider/MailArchiveEntityProvider.java
- History
- Source
/mailarchive/.../MailArchiveEntityProvider.java
- -0
- +21
/mailarchive/mailarchive-tool/tool/src/webapp/WEB-INF/applicationContext.xml
- History
- Source
/mailarchive/.../applicationContext.xml
- -0
- +11
/mailarchive/mailarchive-tool/tool/src/webapp/WEB-INF/web.xml
- History
- Source
- Diff
/mailarchive/mailarchive-tool/.../web.xml

12:27 pm

Zhen Qian

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

12:27 pm

Zhen Qian

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

12:20 pm

Zhen Qian

replaced with mail.read

replaced with mail.read

12:19 pm

Zhen Qian

addressed.

addressed.

Friday 12 Feb 2016

1:50 pm

Zhen Qian

More
SAKTRUNK-113
started review

SAK-30211 add MailArchive EntityProvider

SAK-30211 add MailArchive EntityProvider

1:46 pm

Zhen Qian

More
SAKTRUNK-112
Abandoned

9:15 am

Zhen Qian

More
Re: CR-27
commented on review

same as above. Comments needed.

same as above. Comments needed.

9:14 am

Zhen Qian

More
Re: CR-27
commented on review

could be "return !ac.isEmpty();"

could be "return !ac.isEmpty();"

9:13 am

Zhen Qian

More
Re: CR-27
commented on review

please put some comments for the newly added functions.

please put some comments for the newly added functions.

Atlassian FishEye analysis with Crucible code review. (Version:3.9.0 Build:20150804094455 2015-08-04) - Administration - Page generated 2020-09-23 21:07 -0500