Steve Swinsburg

SAK-33855 allow students to view assignment/course grade stats (#6506)

* SAK-33855 add settings control for stats release to students

* SAK-33855 add in the hibernate and DTO parts for storage of the assignment and course grade stats settings.

Updated front end panel to use the new fields in GradebookInformation

Removed boilerplate cruft from backend classes

* SAK-33855 make new gradebooks get the stats enabled by default, as per upgrade scripts

Refactor logging blocks to add curly braces as they were missing

* SAK-33855 Added stats link in Student view for assignment statistics

WIP, needs permission to access gradebook service before adding content.

Also need to figure out why the icon isn't displaying, using text in the meantime.

* Delete GbBasicModalWindow.java

Not required

* SAK-33855 wrap calls for stats in a security advisor so students can view stats. Add security advisor to gradebook settings calls so a students session could get the info. Conditionally show stats based on the settings. Wire in the assignment chart for students

* Feature/sak-33855 (#11)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* Feature/sak 33855 (#12)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* SAK-33855 Remove stats from student course grade stats window to prevent students from seeing max and min grades for other students, fixed highlighting of icon, turned off the assignment stats icon for instructor view (only in student view)

* SAK-33855 back out this change

* SAK-33855 address accesslint issues

* SAK-33855 a stack of code cleanup on GradebookFrameworkServiceImpl

* SAK-33855 migrated to @Data

* SAK-33855 fix codacy issues

* SAK-33855 move inside panel

* SAK-33855 make intent clearer to class members

  1. … 8 more files in changeset.
SAK-33855 allow students to view assignment/course grade stats (#6506)

* SAK-33855 add settings control for stats release to students

* SAK-33855 add in the hibernate and DTO parts for storage of the assignment and course grade stats settings.

Updated front end panel to use the new fields in GradebookInformation

Removed boilerplate cruft from backend classes

* SAK-33855 make new gradebooks get the stats enabled by default, as per upgrade scripts

Refactor logging blocks to add curly braces as they were missing

* SAK-33855 Added stats link in Student view for assignment statistics

WIP, needs permission to access gradebook service before adding content.

Also need to figure out why the icon isn't displaying, using text in the meantime.

* Delete GbBasicModalWindow.java

Not required

* SAK-33855 wrap calls for stats in a security advisor so students can view stats. Add security advisor to gradebook settings calls so a students session could get the info. Conditionally show stats based on the settings. Wire in the assignment chart for students

* Feature/sak-33855 (#11)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* Feature/sak 33855 (#12)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* SAK-33855 Remove stats from student course grade stats window to prevent students from seeing max and min grades for other students, fixed highlighting of icon, turned off the assignment stats icon for instructor view (only in student view)

* SAK-33855 back out this change

* SAK-33855 address accesslint issues

* SAK-33855 a stack of code cleanup on GradebookFrameworkServiceImpl

* SAK-33855 migrated to @Data

* SAK-33855 fix codacy issues

* SAK-33855 move inside panel

* SAK-33855 make intent clearer to class members

(cherry picked from commit e3d992a919f77563cb032cfe47677e2f4afc7a71)

  1. … 8 more files in changeset.
SAK-33098 add bulk edit for gradebook items (#6111)

* SAK-33107 add the ability to scale point grades

* SAK-33098 bulk edit panel, rendering assignments and actions section

* Fix button style on delete item panel

* SAK-33098 move actions into columns for each assignment and wire up to business service to update the assignments

SAK-33107 add the ability to scale point grades (#6095)

* SAK-33107 add the ability to scale point grades

* Back out the codestyle changes

SAK-33107

* SAK-33107 Add back in scaleGrades changes

* Removed duplicate import

SAK-33107

SAK-33107 add the ability to scale point grades (#6095)

* SAK-33107 add the ability to scale point grades

* Back out the codestyle changes

SAK-33107

* SAK-33107 Add back in scaleGrades changes

* Removed duplicate import

SAK-33107

(cherry picked from commit f0aedb7fde19d99e28fc08e65bd2f9cc02670d3f)

SAK-33857 Remove useless gradebook code (#5257)

* SAK-33857 remove useless code in GradebookService

* SAk-33857 Remove more useless code and a bit of a refactor

* SAK-33857 Update gradebook classic for removed code. Migrated a few helpers that the UI used into the Gradebook itself.

* SAK-33857 wire up the services directly into gradebook

* SAK-33857 fix null pointer. if there are no enrolments, events will be null, not empty.

* Backout the change to this bean as the list is no longer null due to SAK-33868

* Codacy cleanup

(cherry picked from commit 00c0d3a5084e73ef9fa53d073168a38b3a48bc41)

  1. … 24 more files in changeset.
SAK-33857 Remove useless gradebook code (#5257)

* SAK-33857 remove useless code in GradebookService

* SAk-33857 Remove more useless code and a bit of a refactor

* SAK-33857 Update gradebook classic for removed code. Migrated a few helpers that the UI used into the Gradebook itself.

* SAK-33857 wire up the services directly into gradebook

* SAK-33857 fix null pointer. if there are no enrolments, events will be null, not empty.

* Backout the change to this bean as the list is no longer null due to SAK-33868

* Codacy cleanup

  1. … 24 more files in changeset.
SAK-39982 refactor Assignment/Course Grade stats into a reusable panel (#5736)

* SAk-39982 Create some panels

* More work on the new stats panels

SAK-39982

* SAK-39982 Fix the stats for assignments to allow blank increments to be added without affecting the stats spread.

Fix up the window title, the model getting confused with a null and a string arg

Wire up the average GPA stats

mMove the charts to a separate package

Consolidate the properties

Remove JFreechart entirely

SAK-39982

* SAK-39982 Migrate SettingsGradingSchemaPanel to new stats component

Make stats refresh when grading schema changes

Move isDirty into the subclass where it is used

Add doco to the GradebookInfo class, and clean it up

Fix a few other code quality issues

  1. … 8 more files in changeset.
[DO NOT MERGE] Testing AccessLint

Expect comments from AccessLint

Add codacity badge

SAK-39984 remove Sun import, do code cleanup. (#5592)

(cherry picked from commit 7a820ec982d3bb3baa490bbdc31afda70bf3fedd)

SAK-39984 remove Sun import, do code cleanup. (#5592)

SAK-34040 replace assignment stats with new chart (#5582)

* SAK-34039 refresh chart when grading schema type changes

* SAK-34045 Default colour to that of the morpheus buttons

* SAK-34040 refactor the course grade chart so that the labels and titles are provided and can be internationalised. Lays the foundation for using the same chart with the assignment stats.

* SAK-34040 refactored charting from mix of Wicket and javascript to pure Wicket.

Removed the entity broker call for course grade summary data so it is encapsulated in the wicket component.

Added a new wicket component for the assignment grade chart which can follow the same pattern.

Removed unneeded Javascript calls in the grade chart js so we now only have a single responsibility and can flex based on the chart data being passed in.

* SAK-34040 additional abstraction for base chart class.

Immediately render any subclass.

Remove the id from the assignment variant as it is autogenerated now.

* SAK-34040 finish off the conversion of the assignment grade chart.

    • -0
    • +197
    /gradebookng/tool/src/webapp/scripts/gradebook-chart.js
SAK-34042 fix height and alignment of remove button (#5580)

SAK-34045 Default colour to that of the morpheus buttons

SAK-34039 refresh chart when grading schema type changes (#5475)

SAK-34039 refresh chart when grading schema type changes (#5475)

(cherry picked from commit b3057f3aca2068e9e257863776df9c733c8222a0)

SAK-34041 Reduce width of letter grade and percentage text boxes (#5473)

Merge branch 'master' of https://github.com/sakaiproject/sakai

SAK-34012 fix cancel button and missing wicket id (#5424)

(cherry picked from commit d2fc729c8c2c320bb01a44df64988dec55563ecc)

SAK-34012 fix cancel button and missing wicket id (#5424)

Merge branch 'master' of https://github.com/sakaiproject/sakai

SAK-34013 add course grade chart to course grade dropdown (#5396)

* SAK-34013 add chart as a modal window to the course grade dropdown

(cherry picked from commit aac97ddcbfe0c09a4ad5f8153ba458ea375b5704)

SAK-34013 add course grade chart to course grade dropdown (#5396)

* SAK-34013 add chart as a modal window to the course grade dropdown

Merge branch 'master' of https://github.com/sakaiproject/sakai

SAK-33981 refactor chart to wicket component (#5372)

* Remove unused code and cleanup other compiler warnings

* Add rebel.xml to gitignore so that JRebel project config is not committed

* SAK-33981 refactor chart to component so it can be reused.

SAK-33981 refactor chart to wicket component (#5372)

* Remove unused code and cleanup other compiler warnings

* Add rebel.xml to gitignore so that JRebel project config is not committed

* SAK-33981 refactor chart to component so it can be reused.

(cherry picked from commit d3367ecba36c2164479c43f3f286bdf19cad4140)

SAK-33964 Ensure every mapping in grading schema is added to dataset (#5350)

* Remove unused code and cleanup other compiler warnings

* Add rebel.xml to gitignore so that JRebel project config is not committed

* SAK-33964 ensure the course grade dataset contains an entry for everything in the grading schema

SAK-33964 Ensure every mapping in grading schema is added to dataset (#5350)

* Remove unused code and cleanup other compiler warnings

* Add rebel.xml to gitignore so that JRebel project config is not committed

* SAK-33964 ensure the course grade dataset contains an entry for everything in the grading schema

(cherry picked from commit b64414882556b71be041e79d11bbd0a164baab25)