Sam Ottenhoff

About
  • First commit 14 September 2010
  • Latest commit 20 October 2020
Last Week All Time
Commits: 7 3,053
Files changed: 0 37
Change in LOC: 0 1,415

Reviews

14 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sam Ottenhoff is mapped to 3 committers over 3 repositories
Username ottenhoff is mapped to:
Tuesday 20 Oct
1:47 pm

Sam Ottenhoff

SAK-44495 use the kernel UserSortNameComparator (#8702)

Options
    • -2
    • +3
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/GradebookNgBusinessService.java
    • -41
    • +0
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/LastNameComparator.java
    • -1
    • +35
    /kernel/kernel-util/src/test/java/org/sakaiproject/util/comparator/UserSortNameComparatorTest.java
Friday 16 Oct
4:03 pm

Sam Ottenhoff

SAK-44481 round override points and weightings to two decimal points (#8701)

* SAK-44481 round override points and weightings to two decimal points

* Also prevent negative total

Options
    • -0
    • +3
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-rating-edit.js
    • -1
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-student.js
    • -2
    • +6
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
4:03 pm

Sam Ottenhoff

SAK-44481 round override points and weightings to two decimal points (#8701)

* SAK-44481 round override points and weightings to two decimal points

* Also prevent negative total

(cherry picked from commit 2bd523597d5616fa33da5a0cdf18936f69bd6e87)

Options
    • -0
    • +3
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-rating-edit.js
    • -1
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-student.js
    • -2
    • +6
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
4:03 pm

Sam Ottenhoff

SAK-44481 round override points and weightings to two decimal points (#8701)

* SAK-44481 round override points and weightings to two decimal points

* Also prevent negative total

(cherry picked from commit 2bd523597d5616fa33da5a0cdf18936f69bd6e87)

Options
    • -0
    • +3
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-rating-edit.js
    • -1
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-criterion-student.js
    • -2
    • +6
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
4:00 pm

Sam Ottenhoff

SAK-44360 manual 20.x npm pin on sortable

Options
    • -3
    • +3
    /webcomponents/tool/src/main/frontend/package-lock.json
    • -1
    • +1
    /webcomponents/tool/src/main/frontend/package.json
3:50 pm

Sam Ottenhoff

SAK-44360 manual 19.x to lock the troublesome sortable lib only

Options
    • -3
    • +3
    /webcomponents/src/main/frontend/package-lock.json
    • -1
    • +1
    /webcomponents/src/main/frontend/package.json
Thursday 15 Oct
4:52 pm

Sam Ottenhoff

SAK-44413 document the preference for the RemoteIpValve over the force.url.secure property (#8686)

Options
    • -0
    • +5
    /config/configuration/bundles/src/bundle/org/sakaiproject/config/bundle/default.sakai.properties
    • -4
    • +0
    /kernel/component-manager/src/main/bundle/org/sakaiproject/config/kernel.properties
Tuesday 13 Oct
10:40 am

Sam Ottenhoff

SAK-44459 fix time validation where instructor not accepting late submissions (#8682)

(cherry picked from commit b5aac937e3e374464450730c417261057a98751a)

Options
    • -8
    • +9
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ConfirmPublishAssessmentListener.java
    • -3
    • +3
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettingsListener.java
    • -7
    • +8
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
10:40 am

Sam Ottenhoff

SAK-44459 fix time validation where instructor not accepting late submissions (#8682)

Options
    • -8
    • +9
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ConfirmPublishAssessmentListener.java
    • -3
    • +3
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettingsListener.java
    • -7
    • +8
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
10:40 am

Sam Ottenhoff

SAK-44459 fix time validation where instructor not accepting late submissions (#8682)

(cherry picked from commit b5aac937e3e374464450730c417261057a98751a)

Options
    • -8
    • +9
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/ConfirmPublishAssessmentListener.java
    • -3
    • +3
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SaveAssessmentSettingsListener.java
    • -7
    • +8
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/SavePublishedSettingsListener.java
Thursday 08 Oct
8:09 am

Sam Ottenhoff

SAK-43921 fix broken submittedDate sorting. (#8661)

I attempted to fix this by using a custom ConvertUtils DateConverter routine to override the default BeanUtils routines but had absolutely zero luck

(cherry picked from commit b0c3fca193b670f465241a5dc0abe8048efb187b)

Options
    • -17
    • +13
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/util/BeanDateComparator.java
8:09 am

Sam Ottenhoff

SAK-43921 fix broken submittedDate sorting. (#8661)

I attempted to fix this by using a custom ConvertUtils DateConverter routine to override the default BeanUtils routines but had absolutely zero luck

Options
    • -17
    • +13
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/util/BeanDateComparator.java
8:09 am

Sam Ottenhoff

SAK-43921 fix broken submittedDate sorting. (#8661)

I attempted to fix this by using a custom ConvertUtils DateConverter routine to override the default BeanUtils routines but had absolutely zero luck

(cherry picked from commit b0c3fca193b670f465241a5dc0abe8048efb187b)

Options
    • -17
    • +13
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/util/BeanDateComparator.java
Tuesday 06 Oct
10:41 am

Sam Ottenhoff

SAK-44139 use same pastDue logic as student receives in the instructor view (#8654)

(cherry picked from commit 68d0ff834d9e7abd2c5fc92c85885d342eb497f7)

Options
    • -0
    • +9
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorActionListener.java
    • -10
    • +3
    /samigo/samigo-app/src/webapp/jsf/author/authorIndex_content.jsp
    • -0
    • +10
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacade.java
10:41 am

Sam Ottenhoff

SAK-44139 use same pastDue logic as student receives in the instructor view (#8654)

Options
    • -0
    • +9
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/AuthorActionListener.java
    • -10
    • +3
    /samigo/samigo-app/src/webapp/jsf/author/authorIndex_content.jsp
    • -0
    • +10
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/facade/PublishedAssessmentFacade.java
Thursday 01 Oct
2:29 pm

Sam Ottenhoff

SAK-42612 fix sakai 19 help files (#8648)

Options
    • -14
    • +14
    /help/help/src/sakai_screensteps_aboutHelpUserGuide/aboutSakaiHelp.html
    • -31
    • +31
    /help/help/src/sakai_screensteps_accessibilityUserGuide/accessibilityInformation.html
    • -14
    • +14
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanImakeimagesmoreaccessible.html
    • -12
    • +12
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanImakelinksaccessible.html
    • -9
    • +9
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanImakelistsofitemsaccessible.html
    • -11
    • +11
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanImaketablesmoreaccessible.html
    • -3
    • +2
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanImakevideosandaudiofilesmoreaccessible.html
    • -14
    • +14
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanIstructuremydocumenttomakeitmoreaccessible.html
    • -12
    • +12
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howcanchoicesinbackgroundandtextcoloraffectaccessibility.html
    • -13
    • +13
    /help/help/src/sakai_screensteps_accessibilityUserGuide/howdoIcheckmycontentforaccessibility.html
    • -16
    • +16
    /help/help/src/sakai_screensteps_accessibilityUserGuide/whataresomeguidelinesformakingcontentaccessible.html
    • -19
    • +19
    /help/help/src/sakai_screensteps_accessibilityUserGuide/whatdoesitmeantomakecontentaccessible.html
    • -7
    • +7
    /help/help/src/sakai_screensteps_accessibilityUserGuide/whyshouldIuseparagraphbreaksinmydocument.html
    • -9
    • +9
    /help/help/src/sakai_screensteps_adminSitePermsAdministratorGuide/howdoIaddsiterolepermissionsforallsites.html
    • -9
    • +9
    /help/help/src/sakai_screensteps_adminSitePermsAdministratorGuide/howdoIremovesiterolepermissionsforallsites.html
  16. … 531 more files in changeset.
10:25 am

Sam Ottenhoff

SAK-44368 fix NPEs related to LTI assignment type (#8639)

Options
    • -66
    • +68
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
10:25 am

Sam Ottenhoff

SAK-44368 fix NPEs related to LTI assignment type (#8639)

(cherry picked from commit e318081775fb8e05c812ab40e29b5560bb697c02)

Options
    • -66
    • +68
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
Wednesday 30 Sep
2:12 pm

Sam Ottenhoff

SAK-44381 avoid overwriting a good submission with a null one (#8640)

(cherry picked from commit 6b79e98daabc8d085333f5a454a2342d1f0a585e)

Options
    • -1
    • +5
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/services/GradingService.java
2:12 pm

Sam Ottenhoff

SAK-44381 avoid overwriting a good submission with a null one (#8640)

Options
    • -1
    • +5
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/services/GradingService.java
2:12 pm

Sam Ottenhoff

SAK-44381 avoid overwriting a good submission with a null one (#8640)

(cherry picked from commit 6b79e98daabc8d085333f5a454a2342d1f0a585e)

Options
    • -1
    • +5
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/services/GradingService.java
2:12 pm

Sam Ottenhoff

SAK-44381 avoid overwriting a good submission with a null one (#8640)

(cherry picked from commit 6b79e98daabc8d085333f5a454a2342d1f0a585e)

Options
    • -1
    • +5
    /samigo/samigo-services/src/java/org/sakaiproject/tool/assessment/services/GradingService.java
Tuesday 29 Sep
7:20 pm

Sam Ottenhoff

SAK-44248 use blockUI to prevent user from mashing Question Progress links (#8535)

(cherry picked from commit 1e31b17409ea02a3147766bf3312bb0742718c62)

Options
    • -1
    • +2
    /samigo/samigo-app/src/webapp/js/questionProgress.js
    • -1
    • +1
    /samigo/samigo-app/src/webapp/jsf/delivery/questionProgress.jspf
7:20 pm

Sam Ottenhoff

SAK-44248 use blockUI to prevent user from mashing Question Progress links (#8535)

Options
    • -1
    • +2
    /samigo/samigo-app/src/webapp/js/questionProgress.js
    • -1
    • +1
    /samigo/samigo-app/src/webapp/jsf/delivery/questionProgress.jspf
Monday 28 Sep
1:22 pm

Sam Ottenhoff

SAK-44357 modified date minutes and seconds are flipped (#8623)

(cherry picked from commit 93af84a1dca98393a01d598f35304093f6d117de)

Options
    • -7
    • +7
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/TemplateBean.java
1:22 pm

Sam Ottenhoff

SAK-44357 modified date minutes and seconds are flipped (#8623)

(cherry picked from commit 93af84a1dca98393a01d598f35304093f6d117de)

Options
    • -7
    • +7
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/TemplateBean.java
1:22 pm

Sam Ottenhoff

SAK-44357 modified date minutes and seconds are flipped (#8623)

(cherry picked from commit 93af84a1dca98393a01d598f35304093f6d117de)

Options
    • -7
    • +7
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/TemplateBean.java
1:22 pm

Sam Ottenhoff

SAK-44357 modified date minutes and seconds are flipped (#8623)

Options
    • -7
    • +7
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/TemplateBean.java
Wednesday 23 Sep
7:58 am

Sam Ottenhoff

SAK-44343 allow all admin users to edit assessment templates (#8612)

(cherry picked from commit 7cd7f17017f96343621c01fb072ec4347149f68b)

Options
    • -1
    • +4
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/TemplateUpdateListener.java
7:58 am

Sam Ottenhoff

SAK-44343 allow all admin users to edit assessment templates (#8612)

(cherry picked from commit 7cd7f17017f96343621c01fb072ec4347149f68b)

Options
    • -1
    • +4
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/author/TemplateUpdateListener.java