Sam Ottenhoff

About
  • First commit 14 September 2010
  • Latest commit 04 August 2020
Last Week All Time
Commits: 0 2,979
Files changed: 0 37
Change in LOC: 0 1,415

Reviews

14 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Sam Ottenhoff is mapped to 3 committers over 3 repositories
Username ottenhoff is mapped to:
Tuesday 04 Aug
10:12 am

Sam Ottenhoff

SAK-44025 grammar and NPE fixes (#8412)

Options
    • -6
    • +6
    /sitestats/sitestats-bundle/src/resources/Messages.properties
    • -7
    • +15
    /sitestats/sitestats-impl/src/java/org/sakaiproject/sitestats/impl/ServerWideReportManagerImpl.java
    • -1
    • +2
    /sitestats/sitestats-tool/src/webapp/html/pages/ServerWidePage.html
Friday 31 Jul
11:15 am

Sam Ottenhoff

SAK-44026 fix regression that broke role choice within course site (#8413)

(cherry picked from commit b4cd69417b51f832ffe8fc634e705485395ca8ea)

Options
    • -1
    • +1
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
11:15 am

Sam Ottenhoff

SAK-44026 fix regression that broke role choice within course site (#8413)

Options
    • -1
    • +1
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
11:15 am

Sam Ottenhoff

SAK-44026 fix regression that broke role choice within course site (#8413)

(cherry picked from commit b4cd69417b51f832ffe8fc634e705485395ca8ea)

Options
    • -1
    • +1
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
Tuesday 28 Jul
4:45 pm

Sam Ottenhoff

SAK-43787 draft debugging (#8404)

Options
    • -2
    • +2
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
12:52 pm

Sam Ottenhoff

SAK-43877 cleanup stacktraces during hard delete (#8326)

Options
    • -5
    • +7
    /edu-services/gradebook-service/impl/src/java/org/sakaiproject/component/gradebook/GradebookFrameworkServiceImpl.java
    • -1
    • +3
    /kernel/kernel-impl/src/main/java/org/sakaiproject/content/impl/BaseContentService.java
Monday 27 Jul
10:37 am

Sam Ottenhoff

SAK-43994 equal weight categories can have differing point values (#8387)

Options
    • -1
    • +1
    /edu-services/gradebook-service/impl/src/java/org/sakaiproject/component/gradebook/GradebookExternalAssessmentServiceImpl.java
Tuesday 21 Jul
1:47 pm

Sam Ottenhoff

SAK-43878 better handling when authzgroup does not exist (#8327)

* SAK-43878 better handling when authzgroup does not exist

* @ern suggestions

* Fix return

(cherry picked from commit 1fa64e950c86e64f80c206bff1a0fc1f9a45cf84)

Options
    • -11
    • +7
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
1:47 pm

Sam Ottenhoff

SAK-43878 better handling when authzgroup does not exist (#8327)

* SAK-43878 better handling when authzgroup does not exist

* @ern suggestions

* Fix return

(cherry picked from commit 1fa64e950c86e64f80c206bff1a0fc1f9a45cf84)

Options
    • -11
    • +7
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
1:47 pm

Sam Ottenhoff

SAK-43878 better handling when authzgroup does not exist (#8327)

* SAK-43878 better handling when authzgroup does not exist

* @ern suggestions

* Fix return

Options
    • -11
    • +7
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
Friday 17 Jul
9:37 am

Sam Ottenhoff

SAK-43951 make headings in Event Log and User Activity Report more consistent (#8370)

(cherry picked from commit d0698fd76507a6e1c4c45e415b809dee8c3dd84e)

Options
    • -2
    • +2
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages.properties
    • -1
    • +1
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/SectionActivityMessages.properties
    • -11
    • +9
    /samigo/samigo-app/src/webapp/jsf/event/eventLog.jsp
    • -1
    • +1
    /samigo/samigo-app/src/webapp/jsf/section-activity/sectionActivity.jsp
9:37 am

Sam Ottenhoff

SAK-43951 make headings in Event Log and User Activity Report more consistent (#8370)

Options
    • -2
    • +2
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages.properties
    • -1
    • +1
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/SectionActivityMessages.properties
    • -11
    • +9
    /samigo/samigo-app/src/webapp/jsf/event/eventLog.jsp
    • -1
    • +1
    /samigo/samigo-app/src/webapp/jsf/section-activity/sectionActivity.jsp
9:37 am

Sam Ottenhoff

SAK-43802 fix bad div closing tag in Manage Overview (#8368)

(cherry picked from commit 316da25c3f8f70d72c4ad92aba7dd5c476f51bd0)

Options
    • -5
    • +3
    /site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
9:37 am

Sam Ottenhoff

SAK-43802 fix bad div closing tag in Manage Overview (#8368)

Options
    • -5
    • +3
    /site-manage/site-manage-tool/tool/src/webapp/vm/sitesetup/chef_site-siteInfo-manageOverview.vm
9:37 am

Sam Ottenhoff

SAK-42669 dont use c as accesskey (#8371)

Options
    • -1
    • +0
    /samigo/samigo-app/bin/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_fa_IR.properties
    • -1
    • +1
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_ar.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_ca.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_es.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_eu.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_fa_IR.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_fr_FR.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_hi_IN.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_ja.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_pt_BR.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_tr_TR.properties
    • -1
    • +0
    /samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/bundle/EventLogMessages_zh_CN.properties
9:36 am

Sam Ottenhoff

SAK-43950 no need for col2of2 explicit min-width as it was causing issues with breakpoints in Sakai 20+ for desktops 1050px+ (#8369)

Options
    • -1
    • +0
    /library/src/morpheus-master/sass/_defaults.scss
    • -2
    • +1
    /library/src/morpheus-master/sass/modules/_main.scss
9:36 am

Sam Ottenhoff

SAK-43950 no need for col2of2 explicit min-width as it was causing issues with breakpoints in Sakai 20+ for desktops 1050px+ (#8369)

(cherry picked from commit f05d4fb09cc881d3f53b204918c828136fd51f2d)

Options
    • -1
    • +0
    /library/src/morpheus-master/sass/_defaults.scss
    • -2
    • +1
    /library/src/morpheus-master/sass/modules/_main.scss
Tuesday 14 Jul
12:37 am

Sam Ottenhoff

SAK-43932 enable pronunciation feature by default (#8360)

Options
    • -4
    • +4
    /config/configuration/bundles/src/bundle/org/sakaiproject/config/bundle/default.sakai.properties
    • -1
    • +1
    /profile2/api/src/java/org/sakaiproject/profile2/logic/SakaiProxy.java
    • -1
    • +1
    /profile2/api/src/java/org/sakaiproject/profile2/util/ProfileConstants.java
    • -1
    • +1
    /roster2/tool/src/java/org/sakaiproject/roster/api/SakaiProxy.java
12:37 am

Sam Ottenhoff

SAK-43932 enable pronunciation feature by default (#8360)

(cherry picked from commit bc4041bb34fe538b8baf52f89728c80054c31fd7)

Options
    • -4
    • +4
    /config/configuration/bundles/src/bundle/org/sakaiproject/config/bundle/default.sakai.properties
    • -1
    • +1
    /profile2/api/src/java/org/sakaiproject/profile2/logic/SakaiProxy.java
    • -1
    • +1
    /profile2/api/src/java/org/sakaiproject/profile2/util/ProfileConstants.java
    • -1
    • +1
    /roster2/tool/src/java/org/sakaiproject/roster/api/SakaiProxy.java
12:37 am

Sam Ottenhoff

SAK-43931 hide audio player in print mode (#8361)

* SAK-43931 hide audio player in print mode

* Fix Overview header

(cherry picked from commit 0e2198ea1b54008dfb7c5e29f1bf3072d9639fff)

Options
    • -4
    • +4
    /roster2/tool/src/handlebars/overview.handlebars
    • -0
    • +3
    /roster2/tool/src/webapp/css/print.css
12:37 am

Sam Ottenhoff

SAK-43931 hide audio player in print mode (#8361)

* SAK-43931 hide audio player in print mode

* Fix Overview header

Options
    • -4
    • +4
    /roster2/tool/src/handlebars/overview.handlebars
    • -0
    • +3
    /roster2/tool/src/webapp/css/print.css
Tuesday 07 Jul
2:02 pm

Sam Ottenhoff

SAK-43902 dont relogin on a /portal/presence/ fragment (#8342)

(cherry picked from commit 5f54de8d0c4a6879e10b094e9ac5b5a0f4b2ac57)

Options
    • -2
    • +2
    /portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/PresenceHandler.java
2:02 pm

Sam Ottenhoff

SAK-43902 dont relogin on a /portal/presence/ fragment (#8342)

(cherry picked from commit 5f54de8d0c4a6879e10b094e9ac5b5a0f4b2ac57)

Options
    • -2
    • +2
    /portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/PresenceHandler.java
2:02 pm

Sam Ottenhoff

SAK-43902 dont relogin on a /portal/presence/ fragment (#8342)

Options
    • -2
    • +2
    /portal/portal-impl/impl/src/java/org/sakaiproject/portal/charon/handlers/PresenceHandler.java
Monday 06 Jul
6:30 pm

Sam Ottenhoff

SAK-43772 fix issue where case changes for ScreenSteps items (#8341)

(cherry picked from commit 1ea3aad973686b9bbf8a9cd99596b2f05e5b1082)

Options
    • -1
    • +1
    /help/help-tool/src/webapp/WEB-INF/tools/sakai.help.xml
    • -28
    • +28
    /help/help/src/sakai_toc/help.xml
6:30 pm

Sam Ottenhoff

SAK-43772 fix issue where case changes for ScreenSteps items (#8341)

Options
    • -1
    • +1
    /help/help-tool/src/webapp/WEB-INF/tools/sakai.help.xml
    • -28
    • +28
    /help/help/src/sakai_toc/help.xml
Friday 19 Jun
11:16 am

Sam Ottenhoff

SAK-43719 fix profile hover EDIT button accessibility info (#8303)

* SAK-43719 fix profile hover EDIT button accessibility info

* Remove additional en_US file

(cherry picked from commit 84f021d19395f579f2bd3b0749a79d1c91a4ed93)

Options
    • -3
    • +4
    /profile2/bundle/src/resources/ProfileApplication.properties
    • -386
    • +0
    /profile2/bundle/src/resources/ProfileApplication_en_US.properties
    • -1
    • +1
    /profile2/tool/src/java/org/sakaiproject/profile2/tool/pages/panels/MyNamePronunciationDisplay.html
    • -43
    • +0
    /profile2/util/src/java/org/sakaiproject/profile2/util/messages_en_US.properties
11:16 am

Sam Ottenhoff

SAK-43719 fix profile hover EDIT button accessibility info (#8303)

* SAK-43719 fix profile hover EDIT button accessibility info

* Remove additional en_US file

Options
    • -3
    • +4
    /profile2/bundle/src/resources/ProfileApplication.properties
    • -386
    • +0
    /profile2/bundle/src/resources/ProfileApplication_en_US.properties
    • -1
    • +1
    /profile2/tool/src/java/org/sakaiproject/profile2/tool/pages/panels/MyNamePronunciationDisplay.html
    • -43
    • +0
    /profile2/util/src/java/org/sakaiproject/profile2/util/messages_en_US.properties
Tuesday 16 Jun
7:43 pm

Sam Ottenhoff

SAK-43759 when in admin site, retrieve all roles instead of just the "admin" role (#8291)

* SAK-43759 when in admin site, retrieve all roles instead of just the "admin" role

* add ~admin per @ern

(cherry picked from commit e14ec84248114cb911cc8528d646b9e36c9829b2)

Options
    • -10
    • +18
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java
7:43 pm

Sam Ottenhoff

SAK-43759 when in admin site, retrieve all roles instead of just the "admin" role (#8291)

* SAK-43759 when in admin site, retrieve all roles instead of just the "admin" role

* add ~admin per @ern

(cherry picked from commit e14ec84248114cb911cc8528d646b9e36c9829b2)

Conflicts:

sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java

Options
    • -9
    • +18
    /sitestats/sitestats-tool/src/java/org/sakaiproject/sitestats/tool/wicket/pages/ReportsEditPage.java