Lance E Sloan

  • More
  • CR-20
  • finished reviewing
Looks good.

Looks good.

These statements say the exact opposite of each other: "Mneme RESTful feed crashes without gradebook tool" and "Mneme api feed won't crash if gradebook tool is not associated with it"

These statements say the exact opposite of each other: "Mneme RESTful feed crashes without gradebook tool" and "Mneme api feed won't crash if gradebook tool is not associated with it"

This comment is probably not necessary. The symbols are well-named, so it's easy to understand what's happening there.

This comment is probably not necessary. The symbols are well-named, so it's easy to understand what's happening there.

Removing my test branch
  1. … 21 more files in changeset.
Test commit to my test branch.

Testing svn branching on this repo
  1. … 21 more files in changeset.
TLPORTAL-23

Added comments about use of this file. Also commented out the list of files, since this project doesn't need them right now. It's helpful to keep this file in the project for future reference, though.

TLPORTAL-23

Added logic to check for list of files to be archived before running tar. Added logic to allow comments in that list of files.

TLPORTAL-23

Apparently, the properties file is the only one that needs to be included in the config TAR file. And this one is a template.

TLPORTAL-23

Changed because this project doesn't need to distribute config files. Instead, env. variable googleServicePropsPath should point to the location of googleServiceProps.properties on the server.

TLPORTAL-23

Used by build.sh, this is a list of filenames to be added to configuration-files TAR file.

TLPORTAL-23

Script to be run by build server after successful Maven build.

    • -0
    • +24
    /umich/google/google-drive-lti/trunk/build.sh
TLPORTAL-23

Disable debugging statements.

TLPORTAL-23

Corrections after failed build server build.

TLPORTAL-23

Used by build.sh, this is a list of filenames to be added to configuration-files TAR file.

TLPORTAL-23

Script to be run by build server after successful Maven build.

    • -0
    • +23
    /umich/google/google-drive-lti/tags/2.3/build.sh
Notes about changing "googledrivelti" to "googleapi" to reflect its purpose.
I would rename "simplePage" to "currentPage" or "currentSimplePage".

I would rename "simplePage" to "currentPage" or "currentSimplePage".

Updated version number.
GOOGLE-158

It appears that lti-utils now has a version of "1.5-SNAPSHOT". That's what I had to use in the GDrive POM to get it to build, so I think it's probably safe to commit this change.

GOOGLE-158

Added requirements from the old About document. Added instructions for filling in the contents of build.txt.

GOOGLE-158

New files:

about.html - Contents of the new modal About dialog box.

index.html - Page shown when the application is called without any additional path or parameters. Used to let administrators see that the application is installed and running.

build.txt - A file of information about the current build of the application. Referenced by about.html and index.html. This should be filled in by the developer building the application, preferably by an automated build script.

GOOGLE-158

build.txt has been moved to a higher-level directory, where it is used by about.html and index.html.

GOOGLE-158

The old About document has been removed, replaced with a simple modal dialog box.

GOOGLE-158

Added text from old version of About document, which has been reduced to a simple modal dialog box.

GOOGLE-158

Added code to load build info from build.txt, to display a bootbox-based modal dialog box for the "About" link, and to open the help page in a new window.

GOOGLE-158

Small change to the name of the style and the way it's applied.