Beth Kirschner

About
  • First commit 15 November 2005
  • Latest commit 09 December 2015
Last Week All Time
Commits: 0 2,196
Files changed: 0 2,003
Change in LOC: 0 12,272

Reviews

7 active reviews

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Beth Kirschner is mapped to 3 committers over 3 repositories
Username bkirschn is mapped to:
Monday 15 Feb 2016
12:00 pm

Beth Kirschner

11:25 am

Beth Kirschner

Looks good (just a few comments added) - please create PR for Sakaiproject github repo too

Looks good (just a few comments added) - please create PR for Sakaiproject github repo too

11:23 am

Beth Kirschner

Delete? Not used

Delete? Not used

11:12 am

Beth Kirschner

Another comment typo

Another comment typo

11:11 am

Beth Kirschner

Cut-n-paste error?

Cut-n-paste error?

Wednesday 09 Dec 2015
11:03 am

Beth Kirschner

updated google readme
Options
    • -4
    • +2
    /umich/google/README.txt
Tuesday 01 Dec 2015
8:30 am

Beth Kirschner

this should fail
Options
    • -0
    • +3
    /umich/test-scripts/trunk/selenium/keyword/jar/parameters.txt
Monday 16 Nov 2015
9:27 am

Beth Kirschner

[NOJIRA] note regarding move to github
Options
    • -1
    • +2
    /umich/google/google-drive-lti/trunk/README.txt
9:26 am

Beth Kirschner

[NOJIRA] note regarding move to github
Options
    • -1
    • +1
    /umich/lti-utils/trunk/README-lti-utils.txt
Tuesday 10 Nov 2015
11:55 am

Beth Kirschner

  • More
  • CR-23
  • finished reviewing
Monday 09 Nov 2015
3:13 pm

Beth Kirschner

Merge pull request #1252 from pushyamig/DASH-344-3

DASH-344 including the directURL in the entity broker call only

Options
Tuesday 03 Nov 2015
10:27 am

Beth Kirschner

I'd use a better variable name than "feed" - it shouldn't reflect where the method is called from, but what the method does (e.g. include the calendar event URL). This applies to all the methods wi...

I'd use a better variable name than "feed" - it shouldn't reflect where the method is called from, but what the method does (e.g. include the calendar event URL). This applies to all the methods with the "feed" variable. Maybe "includeInfoLinkUrl"?

10:26 am

Beth Kirschner

Is this feed variable used? It should be more than a placeholder.

Is this feed variable used? It should be more than a placeholder.

10:23 am

Beth Kirschner

Need a better variable name.

Need a better variable name.

10:22 am

Beth Kirschner

I'd rather not see this code duplicated - I'd suggest changing this to call getCurrentNewsLinks(sakaiId, siteId, false);

I'd rather not see this code duplicated - I'd suggest changing this to call getCurrentNewsLinks(sakaiId, siteId, false);

Thursday 29 Oct 2015
1:57 pm

Beth Kirschner

[nojira] clean up directory structure
Options
    • -67
    • +0
    /umich/lti-utils/prepareSvnCopy.sh.tmpl
Friday 09 Oct 2015
8:37 am

Beth Kirschner

8:36 am

Beth Kirschner

Can we have another code review with Pushyami's suggested changes?

Can we have another code review with Pushyami's suggested changes?

8:34 am

Beth Kirschner

remove commented out code

remove commented out code

8:34 am

Beth Kirschner

remove commented out code

remove commented out code

8:11 am

Beth Kirschner

remove commented out code

remove commented out code

8:11 am

Beth Kirschner

I'd rather not have commented out code - just delete

I'd rather not have commented out code - just delete

Thursday 24 Sep 2015
2:41 pm

Beth Kirschner

fix formatting

fix formatting

2:41 pm

Beth Kirschner

Always use StringBuffer for concatenation - a lot less expensive: directURL = new StringBuffer( ServerConfigurationService.getPortalUrl() ); directURL.append( serverUrl); etc return directURL.toStr...

Always use StringBuffer for concatenation - a lot less expensive:
directURL = new StringBuffer( ServerConfigurationService.getPortalUrl() );
directURL.append( serverUrl);
etc
return directURL.toString()

2:36 pm

Beth Kirschner

Use constant (see above)

Use constant (see above)

2:32 pm

Beth Kirschner

I see you're just repeating a pattern all over the code of hard-coding this constant again and again, but it's still bad practice https://crucible.sakaiproject.org/static/nsjxqv/2static/images/wiki...

I see you're just repeating a pattern all over the code of hard-coding this constant again and again, but it's still bad practice
Please add this as a constant to MnemeService, and be sure to differentiate it from the APPLICATION_ID – I'd call it "SAKAI_MNEME_TOOL_ID.

1:52 pm

Beth Kirschner

Date should be 2015

Date should be 2015

Thursday 17 Sep 2015
8:08 am

Beth Kirschner

Merge pull request #1030 from pushyamig/SAK-29691

SAK-29691 Fixing the crashing of assignment feed

Options
    • -4
    • +4
    /edu-services/gradebook-service/impl/src/java/org/sakaiproject/component/gradebook/GradebookServiceHibernateImpl.java
Tuesday 08 Sep 2015
8:08 am

Beth Kirschner

Merge pull request #1052 from axxter99/DASH-345

Dash-345

Options
8:07 am

Beth Kirschner

Merge pull request #1053 from axxter99/Dash-345-1

Dash-345 wicket 1.4.23

Options