Amie Davis

SAK-4152 student grade statistics view vertical axis unreadable (#6757)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-41520 Fix overlapping labels on gradebook chart

* SAK-41520 removed unnecessary comma

SAK-4152 student grade statistics view vertical axis unreadable (#6757)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-41520 Fix overlapping labels on gradebook chart

* SAK-41520 removed unnecessary comma

(cherry picked from commit d4ac53208e5dee9640d1db41266a3e08a2a98e20)

SAK-41411 Highlight student grade within gradebook charts (#6606)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-33855 add settings control for stats release to students

* SAK-33855 add in the hibernate and DTO parts for storage of the assignment and course grade stats settings.

Updated front end panel to use the new fields in GradebookInformation

Removed boilerplate cruft from backend classes

* SAK-33855 make new gradebooks get the stats enabled by default, as per upgrade scripts

Refactor logging blocks to add curly braces as they were missing

* SAK-33855 Added stats link in Student view for assignment statistics

WIP, needs permission to access gradebook service before adding content.

Also need to figure out why the icon isn't displaying, using text in the meantime.

* Delete GbBasicModalWindow.java

Not required

* SAK-33855 wrap calls for stats in a security advisor so students can view stats. Add security advisor to gradebook settings calls so a students session could get the info. Conditionally show stats based on the settings. Wire in the assignment chart for students

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* Feature/sak-33855 (#11)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* SAK-33855 Remove stats from student course grade stats window to prevent students from seeing max and min grades for other students, fixed highlighting of icon, turned off the assignment stats icon for instructor view (only in student view)

* SAK-33855 highlight bar in assignment chart that corresponds to student's grade

* SAK-33855 SAK-41411 Highlight student grade in course grade chart when viewed by a student

* SAK-33855 SAK-41411 Removed duplicate code accidentally added when fixing merge conflicts

* SAK-33855 SAK-41411 Fixed more merge conflict issues

* SAK-33855 SAK-41411 Another merge conflict fix

SAK-41411 Highlight student grade within gradebook charts (#6606)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-33855 add settings control for stats release to students

* SAK-33855 add in the hibernate and DTO parts for storage of the assignment and course grade stats settings.

Updated front end panel to use the new fields in GradebookInformation

Removed boilerplate cruft from backend classes

* SAK-33855 make new gradebooks get the stats enabled by default, as per upgrade scripts

Refactor logging blocks to add curly braces as they were missing

* SAK-33855 Added stats link in Student view for assignment statistics

WIP, needs permission to access gradebook service before adding content.

Also need to figure out why the icon isn't displaying, using text in the meantime.

* Delete GbBasicModalWindow.java

Not required

* SAK-33855 wrap calls for stats in a security advisor so students can view stats. Add security advisor to gradebook settings calls so a students session could get the info. Conditionally show stats based on the settings. Wire in the assignment chart for students

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* Feature/sak-33855 (#11)

* SAK-33855 Fixed styling of assignment stats icon

* SAK-33855 Add course grade statistics panel to student page

Display a graph icon for viewing course grade statistics if the course grade has been released to students.

* SAK-33855 Remove stats from student course grade stats window to prevent students from seeing max and min grades for other students, fixed highlighting of icon, turned off the assignment stats icon for instructor view (only in student view)

* SAK-33855 highlight bar in assignment chart that corresponds to student's grade

* SAK-33855 SAK-41411 Highlight student grade in course grade chart when viewed by a student

* SAK-33855 SAK-41411 Removed duplicate code accidentally added when fixing merge conflicts

* SAK-33855 SAK-41411 Fixed more merge conflict issues

* SAK-33855 SAK-41411 Another merge conflict fix

(cherry picked from commit d7b2f95faa50eb0abad9eca5979dd0eb62c048b7)

SAK-41400 remove rounding on gradebook charts (#6605)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-41400 Remove custom chart drawing as we no longer want rounded corners

SAK-41400 remove rounding on gradebook charts (#6605)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* SAK-41400 Remove custom chart drawing as we no longer want rounded corners

(cherry picked from commit fd33c73813aff484c8104bfc4f13669b72eb468c)

SAK-33109 display total points of category (#6146)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Cleanup thanks to pref file

Issue: SAK-33109

* SAK-33109 Added total points for category to grade table

* SAK-33109 Reverted pref file changes

* SAK-33109 Converted tabs to spaces in html file to match current whitespace

* SAK-33109 More fixing of html file

(cherry picked from commit b8e7c420630fe8b9a5863fe9857ce1fccf2638d5)

SAK-33109 display total points of category (#6146)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Cleanup thanks to pref file

Issue: SAK-33109

* SAK-33109 Added total points for category to grade table

* SAK-33109 Reverted pref file changes

* SAK-33109 Converted tabs to spaces in html file to match current whitespace

* SAK-33109 More fixing of html file

SAK-33999 display maximum possible points (#6140)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Changed display of ungraded work to include maximum possible points

Always display the maximum possible points, no longer dependent on there being a grade.

Added a helper method to format an empty grade to instead return a dash.

Bonus code improvements thanks to my preferences file.

Issue: SAK-33999

* SAK-33999 Removed preferences file changes

* SAK-33999 Simplified helper method for empty grade display

(cherry picked from commit 6b3b23359cb088b32a024820033c21abcb7285d8)

SAK-33999 display maximum possible points (#6140)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Changed display of ungraded work to include maximum possible points

Always display the maximum possible points, no longer dependent on there being a grade.

Added a helper method to format an empty grade to instead return a dash.

Bonus code improvements thanks to my preferences file.

Issue: SAK-33999

* SAK-33999 Removed preferences file changes

* SAK-33999 Simplified helper method for empty grade display

SAK-33583 decouple include in calculations release to students (#6142)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Decoupled released and counted checkboxes on add/edit gradebook item panel

Issue: SAK-33583

* Updated to use Checkbox instead of AjaxCheckBox

Issue: SAK-33583

(cherry picked from commit 12654e271a83e6aa195c6dc07cc0703179001e70)

SAK-33583 decouple include in calculations release to students (#6142)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Decoupled released and counted checkboxes on add/edit gradebook item panel

Issue: SAK-33583

* Updated to use Checkbox instead of AjaxCheckBox

Issue: SAK-33583

SAK-34043 slight rounding of bar chart corners (#5530)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Overrode the drawing method for Chartjs so that we can have rounded corners

As documented, this code is based on code by Jed Trow. It has been modified so that only the top (or right, in the case of a horizontal bar) corners are rounded. I have also removed some code that was seemingly redundant.

The github project is linked to in the doco. His code to deal with borderWidth has been left in, in case we want a border on the bars.

The corner radius is defined as half the width or height, whichever is smaller.

Hopefully this feature will be added to a future version of Chartjs and we can remove this method.

Issue: SAK-34043

Feature/sak 34047 make graph title and axis labels bigger (#5470)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Changed font size and weight for chart title and axis labels

Issue: SAK-34047

* Changed font sizes and made the step labels bold

Issue: SAK-34037

Feature/sak 34044 suppress colour swatch when mouseover on chart (#5469)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Customised the tooltips so that the colour swatch is not shown and set all info to display on one line

Issue: SAK-34044

Feature/refresh stats (#5221)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Updated stats section

Moved the stats section into a wicket container.

Fixed the calculateStatistics method by filtering out empty grades.

Issue: SAK-33473

Feature/refresh stats (#5221)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* Updated stats section

Moved the stats section into a wicket container.

Fixed the calculateStatistics method by filtering out empty grades.

Issue: SAK-33473

(cherry picked from commit b0d8f929b36635dc4982813401dfb8060d8c4566)

Move x axis labels to bottom of chart, change GPA stat label (#4409)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* #3432 Moved x-axis labels to bottom of chart, changed GPA label to Course Average GPA, made getAverageGPA null safe

Dont display gradebook chart when there is no data (#4376)

* #3432 Make sure mapped grades are not null when they are collected.

Mapped grades will be null if the student doesn't have a course grade yet.

* #3432 Display message instead of chart if there are no course grades or the course grades have not been released to students.

#3432 Make sure mapped grades are not null when they are collected. (#4375)

Mapped grades will be null if the student doesn't have a course grade yet.

Make gradebook chart horizontal (#4362)

* Made chart horizontal and uninverted the data so that the highest grade is at the top of the graph.

#3432

* Added average GPA to list of stats. Noted in the GradePointsMapping class that any changes to the mapped grades will need to be updated in SettingsGradingSchemaPanel.

#3432

* Created helper functions for the stats calculations.

#3432