Adrian Fish

About
  • First commit 06 July 2010
  • Latest commit 05 March 2021
Last Week All Time
Commits: 4 1,084
Files changed: 0 0
Change in LOC: 0 0

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Adrian Fish is mapped to 3 committers over 2 repositories
Username a.fish@lancaster.ac.uk is mapped to:
Today
2 hrs ago

Adrian Fish

SAK-45087 The tasks widget should only be in the home dashboard (#9043)

https://jira.sakaiproject.org/browse/SAK-45087

Options
    • -0
    • +8
    /config/configuration/bundles/src/bundle/org/sakaiproject/config/bundle/default.sakai.properties
    • -7
    • +14
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/DashboardController.java
    • -9
    • +31
    /webcomponents/tool/src/main/frontend/js/widgets/sakai-widget-panel.js
    • -1
    • +0
    /webcomponents/tool/src/main/frontend/stories/data/course-dashboard-data.js
    • -0
    • +2
    /webcomponents/tool/src/main/frontend/stories/styles/sakai-styles.js
2 hrs ago

Adrian Fish

SAK-45039 Improve number of submission in grades widget (#9051)

https://jira.sakaiproject.org/browse/SAK-45039

This change results in the grades api endpoint asking assignments or

samigo for the number of submissions and graded, when the GB assignment

is externally maintained.

Options
    • -4
    • +5
    /assignment/api/src/java/org/sakaiproject/assignment/api/AssignmentService.java
    • -4
    • +12
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
    • -1
    • +3
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
    • -1
    • +1
    /gradebookng/bundle/src/main/bundle/gradebookng.properties
    • -0
    • +8
    /webapi/pom.xml
    • -29
    • +83
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/GradesController.java
2 hrs ago

Adrian Fish

SAK-45022 Make hover on rubrics grading lighter (#9055)

https://jira.sakaiproject.org/browse/SAK-45022

Options
    • -1
    • +1
    /library/src/morpheus-master/sass/modules/tool/rubrics/_rubrics_variables.scss
Wednesday 03 Mar
10:13 am

Adrian Fish

SAK-45113 Fixed unlimited resub issue with new grader (#9066)

https://jira.sakaiproject.org/browse/SAK-45113

Options
    • -3
    • +0
    /assignment/api/src/java/org/sakaiproject/assignment/api/AssignmentConstants.java
    • -0
    • +6
    /webcomponents/tool/src/main/frontend/.eslintrc.js
    • -19
    • +16
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -2
    • +2
    /webcomponents/tool/src/main/frontend/js/grader/submission.js
Wednesday 24 Feb
10:46 am

Adrian Fish

SAK-45086 Save grade in gb/t&q/discussions now releases the rubric (#9041)

https://jira.sakaiproject.org/browse/SAK-45086

Options
    • -1
    • +1
    /gradebookng/tool/src/webapp/scripts/gradebook-saverubric.js
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/js/forum.js
    • -1
    • +1
    /samigo/samigo-app/src/webapp/js/samigo-global.js
10:46 am

Adrian Fish

SAK-45086 Save grade in gb/t&q/discussions now releases the rubric (#9041)

https://jira.sakaiproject.org/browse/SAK-45086

(cherry picked from commit f162efcb277ad3a9f33004ce2410ec179a9e1cc1)

Options
    • -1
    • +1
    /gradebookng/tool/src/webapp/scripts/gradebook-saverubric.js
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/js/forum.js
    • -1
    • +1
    /samigo/samigo-app/src/webapp/js/samigo-global.js
Thursday 18 Feb
7:38 am

Adrian Fish

SAK-45042 Don't escape site description for dashboard (#9032)

https://jira.sakaiproject.org/browse/SAK-45042

Options
    • -1
    • +1
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/DashboardController.java
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/js/coursedashboard/sakai-course-dashboard.js
7:38 am

Adrian Fish

SAK-45042 Don't escape site description for dashboard (#9032)

https://jira.sakaiproject.org/browse/SAK-45042

(cherry picked from commit d88372dbe3db5092793f97b12569616d7df63bd3)

Options
    • -1
    • +1
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/DashboardController.java
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/js/coursedashboard/sakai-course-dashboard.js
Tuesday 16 Feb
3:28 pm

Adrian Fish

SAK-45035 Make sure web content and lti launch in tab. (#9030)

https://jira.sakaiproject.org/browse/SAK-45035

Options
    • -14
    • +18
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePageNav.vm
3:28 pm

Adrian Fish

SAK-45035 Make sure web content and lti launch in tab. (#9030)

https://jira.sakaiproject.org/browse/SAK-45035

(cherry picked from commit a37df2a6f70a6b00816ef3ed9825ea10372a9d2c)

Options
    • -14
    • +18
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePageNav.vm
3:28 pm

Adrian Fish

SAK-45035 Make sure web content and lti launch in tab. (#9030)

https://jira.sakaiproject.org/browse/SAK-45035

(cherry picked from commit a37df2a6f70a6b00816ef3ed9825ea10372a9d2c)

Options
    • -14
    • +18
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/includePageNav.vm
Sunday 14 Feb
7:48 am

Adrian Fish

SAK-45019 Moved widget panel to use auto-fill grid layout (#9018)

https://jira.sakaiproject.org/browse/SAK-45019

Options
    • -13
    • +2
    /webcomponents/tool/src/main/frontend/js/widgets/sakai-widget-panel.js
5:29 am

Adrian Fish

SAK-45023 Don't return submitterless submissions in new grader (#9021)

https://jira.sakaiproject.org/browse/SAK-45023

This can arise if you remove a submission user from your LDAP, for instance.

(cherry picked from commit 86e8e0f3928be96baa366566c7d136db3dedaa7b)

Options
    • -16
    • +36
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
5:29 am

Adrian Fish

SAK-45023 Don't return submitterless submissions in new grader (#9021)

https://jira.sakaiproject.org/browse/SAK-45023

This can arise if you remove a submission user from your LDAP, for instance.

Options
    • -16
    • +36
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
Friday 12 Feb
11:19 am

Adrian Fish

SAK-45020 Added eslint to the webcomponents build (#9019)

https://jira.sakaiproject.org/browse/SAK-45020

Options
    • -19
    • +10
    /webcomponents/tool/pom.xml
    • -0
    • +16
    /webcomponents/tool/src/main/frontend/.eslintrc.js
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/.gitignore
    • -0
    • +569
    /webcomponents/tool/src/main/frontend/package-lock.json
    • -1
    • +3
    /webcomponents/tool/src/main/frontend/package.json
Thursday 11 Feb
4:05 pm

Adrian Fish

SAK-44879 Allow marking rubric associations active (#8952)

https://jira.sakaiproject.org/browse/SAK-44879

(cherry picked from commit 17f4990e604e00b77b15cff76ee21a0774a903a5)

Options
    • -26
    • +2
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
    • -3
    • +0
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentToolUtils.java
    • -1
    • +0
    /assignment/tool/src/webapp/WEB-INF/applicationContext.xml
    • -4
    • +0
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -5
    • +13
    /assignment/tool/src/webapp/vm/assignment/instructor_new_edit/grading_section.vm
    • -1
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/GradebookNgBusinessService.java
    • -35
    • +0
    /msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java
    • -12
    • +3
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseForumSettingsAttach.jsp
    • -7
    • +3
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseTopicSettingsAttach.jsp
    • -1
    • +0
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfMsgGrade.jsp
    • -2
    • +0
    /msgcntr/messageforums-component-impl/src/java/org/sakaiproject/component/app/messageforums/MessageForumsForumManagerImpl.java
    • -2
    • +4
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/model/ToolItemRubricAssociation.java
    • -1
    • +3
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/repository/EvaluationRepository.java
    • -3
    • +16
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/repository/ToolItemRubricAssociationRepository.java
    • -0
    • +5
    /rubrics/impl/pom.xml
  16. … 5 more files in changeset.
4:05 pm

Adrian Fish

SAK-44879 Allow marking rubric associations active (#8952)

https://jira.sakaiproject.org/browse/SAK-44879

Options
    • -26
    • +2
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
    • -3
    • +0
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentToolUtils.java
    • -1
    • +0
    /assignment/tool/src/webapp/WEB-INF/applicationContext.xml
    • -4
    • +0
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -5
    • +13
    /assignment/tool/src/webapp/vm/assignment/instructor_new_edit/grading_section.vm
    • -1
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/GradebookNgBusinessService.java
    • -35
    • +0
    /msgcntr/messageforums-app/src/java/org/sakaiproject/tool/messageforums/DiscussionForumTool.java
    • -12
    • +3
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseForumSettingsAttach.jsp
    • -7
    • +3
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseTopicSettingsAttach.jsp
    • -1
    • +0
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfMsgGrade.jsp
    • -2
    • +0
    /msgcntr/messageforums-component-impl/src/java/org/sakaiproject/component/app/messageforums/MessageForumsForumManagerImpl.java
    • -2
    • +4
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/model/ToolItemRubricAssociation.java
    • -1
    • +3
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/repository/EvaluationRepository.java
    • -3
    • +16
    /rubrics/api/src/main/java/org/sakaiproject/rubrics/logic/repository/ToolItemRubricAssociationRepository.java
    • -0
    • +5
    /rubrics/impl/pom.xml
  16. … 5 more files in changeset.
11:36 am

Adrian Fish

SAK-45015 Default criteria pointoverride to empty (#9017)

https://jira.sakaiproject.org/browse/SAK-45015

(cherry picked from commit adb07d7cf5a3388f6ecb60f9ddafabcaa08a7952)

Options
    • -1
    • +2
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
11:36 am

Adrian Fish

SAK-45015 Default criteria pointoverride to empty (#9017)

https://jira.sakaiproject.org/browse/SAK-45015

Options
    • -1
    • +2
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
Tuesday 09 Feb
12:54 pm

Adrian Fish

SAK-44959 Assignment -> Release Grades sets rubrics to released. (#8998)

https://jira.sakaiproject.org/browse/SAK-44959

This also fixes the Save and the Save and Release behaviour in both

classic and ng grader. Save sets the rubric to draft, Save and Release

sets it to released.

Options
    • -22
    • +28
    /assignment/tool/src/webapp/js/assignments.js
    • -1
    • +1
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -1
    • +3
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -2
    • +4
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -1
    • +5
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
    • -0
    • +37
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-student-button.js
12:54 pm

Adrian Fish

SAK-44959 Assignment -> Release Grades sets rubrics to released. (#8998)

https://jira.sakaiproject.org/browse/SAK-44959

This also fixes the Save and the Save and Release behaviour in both

classic and ng grader. Save sets the rubric to draft, Save and Release

sets it to released.

(cherry picked from commit fd05ed92ee9b4689be33aa52ab67c2f0c98bac06)

Options
    • -22
    • +28
    /assignment/tool/src/webapp/js/assignments.js
    • -1
    • +1
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -1
    • +3
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -2
    • +4
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -1
    • +5
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
    • -0
    • +37
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-student-button.js
12:54 pm

Adrian Fish

SAK-44959 Assignment -> Release Grades sets rubrics to released. (#8998)

https://jira.sakaiproject.org/browse/SAK-44959

This also fixes the Save and the Save and Release behaviour in both

classic and ng grader. Save sets the rubric to draft, Save and Release

sets it to released.

(cherry picked from commit fd05ed92ee9b4689be33aa52ab67c2f0c98bac06)

Options
    • -22
    • +28
    /assignment/tool/src/webapp/js/assignments.js
    • -1
    • +1
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -1
    • +3
    /assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -2
    • +4
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -1
    • +5
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
    • -0
    • +37
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-student-button.js
10:58 am

Adrian Fish

SAK-44889 Make rubrics point override trigger draft save (#8953)

https://jira.sakaiproject.org/browse/SAK-44889

(cherry picked from commit 01eead3593b82d62b8ca7dbef2f4f60889862b04)

Options
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
10:58 am

Adrian Fish

SAK-44889 Make rubrics point override trigger draft save (#8953)

https://jira.sakaiproject.org/browse/SAK-44889

Options
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
10:58 am

Adrian Fish

SAK-44889 Make rubrics point override trigger draft save (#8953)

https://jira.sakaiproject.org/browse/SAK-44889

(cherry picked from commit 01eead3593b82d62b8ca7dbef2f4f60889862b04)

Options
    • -0
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
Tuesday 02 Feb
10:49 am

Adrian Fish

SAK-44960 Fixed Task saving (#8992)

https://jira.sakaiproject.org/browse/SAK-44960

Options
    • -0
    • +12
    /kernel/api/pom.xml
    • -0
    • +13
    /kernel/api/src/main/java/org/sakaiproject/tasks/api/UserTaskAdapterBean.java
    • -0
    • +39
    /kernel/api/src/main/java/org/sakaiproject/time/api/InstantToMillisJsonSerializer.java
    • -0
    • +39
    /kernel/api/src/main/java/org/sakaiproject/time/api/MillisToInstantJsonDeserializer.java
    • -20
    • +18
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/TasksController.java
    • -10
    • +16
    /webcomponents/tool/src/main/frontend/js/tasks/sakai-tasks-create-task.js
    • -37
    • +18
    /webcomponents/tool/src/main/frontend/js/tasks/sakai-tasks.js
10:49 am

Adrian Fish

SAK-44960 Fixed Task saving (#8992)

https://jira.sakaiproject.org/browse/SAK-44960

(cherry picked from commit e1213ab30cf2aee80b46b7c0d0af4b92527ec91c)

Options
    • -0
    • +12
    /kernel/api/pom.xml
    • -0
    • +13
    /kernel/api/src/main/java/org/sakaiproject/tasks/api/UserTaskAdapterBean.java
    • -0
    • +39
    /kernel/api/src/main/java/org/sakaiproject/time/api/InstantToMillisJsonSerializer.java
    • -0
    • +39
    /kernel/api/src/main/java/org/sakaiproject/time/api/MillisToInstantJsonDeserializer.java
    • -20
    • +18
    /webapi/src/main/java/org/sakaiproject/webapi/controllers/TasksController.java
    • -10
    • +16
    /webcomponents/tool/src/main/frontend/js/tasks/sakai-tasks-create-task.js
    • -37
    • +18
    /webcomponents/tool/src/main/frontend/js/tasks/sakai-tasks.js
Monday 01 Feb
1:15 pm

Adrian Fish

SAK-44862 Escape unallowed subpage title regex correctly (#8960)

https://jira.sakaiproject.org/browse/SAK-44862

(cherry picked from commit 793077f8aa9bc2204b3fc5f606e5e7aa49e37ebf)

Options
    • -1
    • +1
    /lessonbuilder/tool/src/webapp/js/show-page.js
1:15 pm

Adrian Fish

SAK-44862 Escape unallowed subpage title regex correctly (#8960)

https://jira.sakaiproject.org/browse/SAK-44862

(cherry picked from commit 793077f8aa9bc2204b3fc5f606e5e7aa49e37ebf)

Options
    • -1
    • +1
    /lessonbuilder/tool/src/webapp/js/show-page.js
1:15 pm

Adrian Fish

SAK-44862 Escape unallowed subpage title regex correctly (#8960)

https://jira.sakaiproject.org/browse/SAK-44862

Options
    • -1
    • +1
    /lessonbuilder/tool/src/webapp/js/show-page.js