Adrian Fish

About
  • First commit 06 July 2010
  • Latest commit 17 September 2020
Last Week All Time
Commits: 6 928
Files changed: 0 0
Change in LOC: 0 0

Reviews

1 active review

Counts may include data that you cannot access.

Line History

Line Count Graph
Line Count Graph
 

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Committer Mappings

Adrian Fish is mapped to 2 committers over 2 repositories
Username a.fish@lancaster.ac.uk is mapped to:
Thursday 17 Sep
12:50 pm

Adrian Fish

SAK-44186 Only update document viewer if i18n present (#8570)

https://jira.sakaiproject.org/browse/SAK-44186

Options
    • -0
    • +4
    /webcomponents/tool/src/main/frontend/js/sakai-document-viewer.js
10:08 am

Adrian Fish

SAK-44081 Select current pass/fail grade in new grader (#8571)

https://jira.sakaiproject.org/browse/SAK-44081

Options
    • -3
    • +3
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
Monday 14 Sep
11:55 am

Adrian Fish

SAK-44293 Make full screen message clearer and clickable (#8567)

https://jira.sakaiproject.org/browse/SAK-44293

I agree with Adam's comment on the original ticket SAK-44013, make the whole

full screen message clickable and do away with the max button in the

message.

Options
    • -15
    • +5
    /library/src/morpheus-master/js/src/sakai.morpheus.toggletools.js
    • -1
    • +2
    /library/src/morpheus-master/sass/base/_defaults.scss
    • -1
    • +1
    /portal/portal-impl/impl/src/bundle/sitenav.properties
    • -1
    • +1
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/site.vm
11:55 am

Adrian Fish

SAK-44293 Make full screen message clearer and clickable (#8567)

https://jira.sakaiproject.org/browse/SAK-44293

I agree with Adam's comment on the original ticket SAK-44013, make the whole

full screen message clickable and do away with the max button in the

message.

(cherry picked from commit ad87f220ec6e1ff4294f2214f5f1b5b833abfb37)

Options
    • -15
    • +5
    /library/src/morpheus-master/js/src/sakai.morpheus.toggletools.js
    • -1
    • +2
    /library/src/morpheus-master/sass/base/_defaults.scss
    • -1
    • +1
    /portal/portal-impl/impl/src/bundle/sitenav.properties
    • -1
    • +1
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/site.vm
11:55 am

Adrian Fish

SAK-44293 Make full screen message clearer and clickable (#8567)

https://jira.sakaiproject.org/browse/SAK-44293

I agree with Adam's comment on the original ticket SAK-44013, make the whole

full screen message clickable and do away with the max button in the

message.

(cherry picked from commit ad87f220ec6e1ff4294f2214f5f1b5b833abfb37)

Options
    • -15
    • +5
    /library/src/morpheus-master/js/src/sakai.morpheus.toggletools.js
    • -1
    • +2
    /library/src/morpheus-master/sass/base/_defaults.scss
    • -1
    • +1
    /portal/portal-impl/impl/src/bundle/sitenav.properties
    • -1
    • +1
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/site.vm
Sunday 13 Sep
1:29 pm

Adrian Fish

SAK-44245 Don't mask BaseMessage's m_formattedText property. (#8533)

https://jira.sakaiproject.org/browse/SAK-44245

Dave's change effectively hid BaseMessage's m_formattedText field from

the spring wiring in announcements. I'm glad it did, or we'd have had

multiple ways of accessing formatted text in one object graph.

Options
    • -8
    • +7
    /announcement/announcement-impl/impl/src/java/org/sakaiproject/announcement/impl/BaseAnnouncementService.java
Friday 11 Sep
1:47 pm

Adrian Fish

SAK-44264 Only warn if a grader user is not found (#8555)

https://jira.sakaiproject.org/browse/SAK-44006

Options
    • -22
    • +9
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
1:47 pm

Adrian Fish

SAK-44264 Only warn if a grader user is not found (#8555)

https://jira.sakaiproject.org/browse/SAK-44006

(cherry picked from commit c5683d4e793198970b991ea257adf371fe5d4f84)

Options
    • -22
    • +9
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
Friday 04 Sep
11:57 am

Adrian Fish

SAK-43853 Ensure resubmit date is valid in grader (#8527)

https://jira.sakaiproject.org/browse/SAK-43853

Options
    • -6
    • +7
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
    • -18
    • +11
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -3
    • +20
    /webcomponents/tool/src/main/frontend/js/grader/submission.js
9:42 am

Adrian Fish

SAK-43782 Grader feedback comment updates correctly (#8526)

https://jira.sakaiproject.org/browse/SAK-43782

Options
    • -4
    • +4
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
Thursday 03 Sep
8:12 pm

Adrian Fish

SAK-44201 Task creation should merge entities (#8523)

https://jira.sakaiproject.org/browse/SAK-44201

Options
    • -4
    • +4
    /kernel/kernel-impl/src/main/java/org/sakaiproject/tasks/impl/TaskServiceImpl.java
12:14 pm

Adrian Fish

SAK-44183 Let grader preview images (#8521)

https://jira.sakaiproject.org/browse/SAK-44183

Options
    • -25
    • +52
    /assignment/tool/src/java/org/sakaiproject/assignment/entityproviders/AssignmentEntityProvider.java
    • -1
    • +1
    /kernel/api/src/main/java/org/sakaiproject/content/api/ContentResource.java
    • -19
    • +17
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -15
    • +18
    /webcomponents/tool/src/main/frontend/js/sakai-document-viewer.js
Friday 28 Aug
9:56 am

Adrian Fish

SAK-44006 Show the first submission attachment by default (#8488)

https://jira.sakaiproject.org/browse/SAK-44006

If there's submitted text, show that by default. If not, show the first

attachment by default.

(cherry picked from commit 847415fcc1b2bc7ec59c8c0a2e82afe1e7f9478f)

Options
    • -0
    • +8
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
9:56 am

Adrian Fish

SAK-44006 Show the first submission attachment by default (#8488)

https://jira.sakaiproject.org/browse/SAK-44006

If there's submitted text, show that by default. If not, show the first

attachment by default.

Options
    • -0
    • +8
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
Wednesday 26 Aug
1:21 pm

Adrian Fish

SAK-44013 Give visual feedback when in maximised tool mode. (#8475)

https://jira.sakaiproject.org/browse/SAK-44013

(cherry picked from commit 0745a8e298b630bed41073e37f563a63157471e5)

Options
    • -2
    • +2
    /library/src/morpheus-master/js/src/sakai.morpheus.toggletools.js
    • -0
    • +25
    /library/src/morpheus-master/sass/base/_defaults.scss
    • -0
    • +1
    /portal/portal-impl/impl/src/bundle/sitenav.properties
    • -3
    • +1
    /portal/portal-render-engine-impl/impl/src/test/org/sakaiproject/portal/charon/test/MockCharonPortal.java
    • -0
    • +6
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/site.vm
    • -2
    • +2
    /webcomponents/bundle/src/main/bundle/maximise-button.properties
    • -2
    • +2
    /webcomponents/tool/src/main/frontend/js/sakai-maximise-button.js
1:21 pm

Adrian Fish

SAK-44013 Give visual feedback when in maximised tool mode. (#8475)

https://jira.sakaiproject.org/browse/SAK-44013

Options
    • -2
    • +2
    /library/src/morpheus-master/js/src/sakai.morpheus.toggletools.js
    • -0
    • +25
    /library/src/morpheus-master/sass/base/_defaults.scss
    • -0
    • +1
    /portal/portal-impl/impl/src/bundle/sitenav.properties
    • -3
    • +1
    /portal/portal-render-engine-impl/impl/src/test/org/sakaiproject/portal/charon/test/MockCharonPortal.java
    • -0
    • +6
    /portal/portal-render-engine-impl/impl/src/webapp/vm/morpheus/site.vm
    • -2
    • +2
    /webcomponents/bundle/src/main/bundle/maximise-button.properties
    • -2
    • +2
    /webcomponents/tool/src/main/frontend/js/sakai-maximise-button.js
10:57 am

Adrian Fish

SAK-43732 Add new UI dashboard tool (#8466)

https://jira.sakaiproject.org/browse/SAK-43732

Options
    • -0
    • +12
    /announcement/announcement-api/api/src/bundle/announcement.properties
    • -1
    • +3
    /announcement/announcement-api/api/src/java/org/sakaiproject/announcement/api/AnnouncementService.java
    • -1
    • +21
    /announcement/announcement-impl/impl/src/java/org/sakaiproject/announcement/impl/DbAnnouncementService.java
    • -1
    • +0
    /assignment/api/src/java/org/sakaiproject/assignment/api/AssignmentConstants.java
    • -3
    • +2
    /assignment/api/src/java/org/sakaiproject/assignment/api/AssignmentService.java
    • -0
    • +16
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
    • -0
    • +6
    /assignment/impl/src/test/org/sakaiproject/assignment/impl/AssignmentTestConfiguration.java
    • -0
    • +1
    /assignment/impl/src/webapp/WEB-INF/components.xml
    • -0
    • +4
    /assignment/tool/pom.xml
    • -1
    • +3
    /assignment/tool/src/java/org/sakaiproject/assignment/tool/AssignmentAction.java
    • -0
    • +4
    /calendar/calendar-bundles/resources/calendar.properties
    • -0
    • +5
    /dashboard/README.md
    • -0
    • +42
    /dashboard/pom.xml
    • -0
    • +75
    /dashboard/tool/pom.xml
    • -0
    • +81
    /dashboard/tool/src/main/java/org/sakaiproject/dashboard/tool/MainController.java
  16. … 163 more files in changeset.
Wednesday 19 Aug
4:29 pm

Adrian Fish

SAK-44104 Use entityproducer api to get assignment url (#8469)

https://jira.sakaiproject.org/browse/SAK-44104

Options
    • -0
    • +11
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
    • -5
    • +26
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/EmailUtil.java
    • -1
    • +0
    /assignment/impl/src/webapp/WEB-INF/components.xml
4:29 pm

Adrian Fish

SAK-44104 Use entityproducer api to get assignment url (#8469)

https://jira.sakaiproject.org/browse/SAK-44104

(cherry picked from commit 395075784551e4234d3a312c0a1412284943ba98)

Options
    • -0
    • +11
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java
    • -5
    • +26
    /assignment/impl/src/java/org/sakaiproject/assignment/impl/EmailUtil.java
    • -1
    • +0
    /assignment/impl/src/webapp/WEB-INF/components.xml
Thursday 13 Aug
3:33 pm

Adrian Fish

SAK-44080 Sections Column displays None for Non Provided Sections (#8455)

https://jira.sakaiproject.org/browse/SAK-44080

Add the locally configured sections to the list of user sections

Options
    • -1
    • +18
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/GradebookNgBusinessService.java
3:33 pm

Adrian Fish

SAK-44080 Sections Column displays None for Non Provided Sections (#8455)

https://jira.sakaiproject.org/browse/SAK-44080

Add the locally configured sections to the list of user sections

(cherry picked from commit 45e387de370322e048df0d1fe20af7e47e6011cf)

Options
    • -1
    • +18
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/business/GradebookNgBusinessService.java
Wednesday 22 Jul
9:06 am

Adrian Fish

SAK-43964 Added tr import from rubrics language utils (#8383)

Options
    • -0
    • +1
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criteria-readonly.js
Tuesday 07 Jul
1:00 pm

Adrian Fish

SAK-43147 Populate score field on evaluation intial load (#8345)

https://jira.sakaiproject.org/browse/SAK-43147

Options
    • -20
    • +9
    /webcomponents/tool/pom.xml
    • -8
    • +8
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
1:00 pm

Adrian Fish

SAK-43147 Populate score field on evaluation intial load (#8345)

https://jira.sakaiproject.org/browse/SAK-43147

(cherry picked from commit 5f42e197d83032bfe18c09c7316b8bc3f808d28a)

Conflicts:

webcomponents/tool/pom.xml

webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js

Options
    • -20
    • +11
    /webcomponents/tool/pom.xml
    • -1
    • +1
    /webcomponents/tool/src/main/frontend/js/rubrics/sakai-rubric-grading.js
1:00 pm

Adrian Fish

SAK-43147 Populate score field on evaluation intial load (#8345)

https://jira.sakaiproject.org/browse/SAK-43147

(cherry picked from commit 5f42e197d83032bfe18c09c7316b8bc3f808d28a)

Conflicts:

rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-grading.js

webcomponents/tool/pom.xml

Options
    • -1
    • +1
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-grading.js
Tuesday 30 Jun
8:37 am

Adrian Fish

SAK-42763 Bubble attachment exception in mailsender (#7706)

https://jira.sakaiproject.org/browse/SAK-42763

Options
    • -1
    • +14
    /kernel/api/src/main/java/org/sakaiproject/email/api/Attachment.java
    • -0
    • +36
    /kernel/api/src/main/java/org/sakaiproject/email/api/AttachmentSizeException.java
    • -2
    • +6
    /kernel/api/src/main/java/org/sakaiproject/email/api/EmailService.java
    • -352
    • +221
    /kernel/kernel-impl/src/main/java/org/sakaiproject/email/impl/BasicEmailService.java
    • -0
    • +1
    /mailsender/api/src/bundle/mailsender.properties
    • -9
    • +11
    /mailsender/impl/src/java/org/sakaiproject/mailsender/logic/impl/ExternalLogicImpl.java
Friday 26 Jun
9:01 am

Adrian Fish

SAK-43856 Moved rubrics webcomponent to webcomponents project (#8317)

https://jira.sakaiproject.org/browse/SAK-43856

Serving the rubrics webcomponents from under a portal url means that

all the requests for the static js files go through the request filter.

If a browser does not forward the cookie in the js request, xlogin

is returned. This fixes that. Rubrics js is now a purely static asset

with no session checks needed.

(cherry picked from commit 01f4a7a7bb452d18a56c93e8f3f9251b5023b50f)

Options
    • -2
    • +2
    /assignment/tool/src/webapp/vm/assignment/assignment_macros.vm
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/AddOrEditGradeItemPanelContent.java
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseForumSettingsAttach.jsp
    • -3
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseTopicSettingsAttach.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/forum/dfForumDetail.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/includes/dfAreaInclude.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfAllMessages.jsp
    • -1
    • +1
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfMsgGrade.jsp
    • -96
    • +0
    /rubrics/tool/pom.xml
    • -2
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/.gitignore
    • -5
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/rubric-association-requirements.js
    • -55
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/rubrics-element.js
    • -200
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/sakai-item-delete.js
  16. … 70 more files in changeset.
9:01 am

Adrian Fish

SAK-43856 Moved rubrics webcomponent to webcomponents project (#8317)

https://jira.sakaiproject.org/browse/SAK-43856

Serving the rubrics webcomponents from under a portal url means that

all the requests for the static js files go through the request filter.

If a browser does not forward the cookie in the js request, xlogin

is returned. This fixes that. Rubrics js is now a purely static asset

with no session checks needed.

Options
    • -2
    • +2
    /assignment/tool/src/webapp/vm/assignment/assignment_macros.vm
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/AddOrEditGradeItemPanelContent.java
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/GradeSummaryTablePanel.java
    • -2
    • +2
    /gradebookng/tool/src/java/org/sakaiproject/gradebookng/tool/panels/RubricGradePanel.java
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseForumSettingsAttach.jsp
    • -3
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/dfReviseTopicSettingsAttach.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/forum/dfForumDetail.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/includes/dfAreaInclude.jsp
    • -2
    • +2
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfAllMessages.jsp
    • -1
    • +1
    /msgcntr/messageforums-app/src/webapp/jsp/discussionForum/message/dfMsgGrade.jsp
    • -96
    • +0
    /rubrics/tool/pom.xml
    • -2
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/.gitignore
    • -5
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/rubric-association-requirements.js
    • -55
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/rubrics-element.js
    • -200
    • +0
    /rubrics/tool/src/main/frontend/webcomponents/js/sakai-item-delete.js
  16. … 70 more files in changeset.
Wednesday 24 Jun
10:37 am

Adrian Fish

SAK-43222 Support i18n decimal separators in Rubrics. (#7942) (#8314)

https://jira.sakaiproject.org/browse/SAK-43222

(cherry picked from commit d015a8290b83af7266608bc746e1e1335950514b)

Options
    • -2
    • +2
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criteria-readonly.js
    • -2
    • +2
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criteria.js
    • -1
    • +1
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-preview.js
    • -8
    • +8
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-criterion-student.js
    • -0
    • +63
    /rubrics/tool/src/main/frontend/webcomponents/sakai-rubric-grading-button.js
7:28 am

Adrian Fish

SAK-43827 Allow grade replacement in new grader (#8305)

https://jira.sakaiproject.org/browse/SAK-43827

(cherry picked from commit 6391c5d402894661fcd11d8a70335ee91161556e)

Options
    • -3
    • +6
    /webcomponents/tool/src/main/frontend/js/grader/sakai-grader.js
    • -3
    • +4
    /webcomponents/tool/src/main/frontend/js/sakai-group-picker.js