Sakai Trunk

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Yes. After this change, the "url" field of content entity feed will be the original URL for Web Link resources. For other types of resource items, the "URL" attribute will be the normal access url.

Is this overwriting an existing value for item.url?

Is this overwriting an existing value for item.url?

The code looks good. However I wonder why returning the content rather than the url was every the right thing to do.

The code looks good. However I wonder why returning the content rather than the url was every the right thing to do.

truncated URL String returned in content entity feed for Web Link resources
truncated URL String returned in content entity feed for Web Link resources
Looks Good!

Looks Good!

checks for resource copyright alert setting
checks for resource copyright alert setting
Done. Merged into CTools branch. Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

Done.

Merged into CTools branch.

Created PR for Sakai: https://github.com/sakaiproject/sakai/pull/1731

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

Done. Refactored into getSiteMailChannels(String siteId)

replaced with mail.read

replaced with mail.read

addressed.

addressed.

Done

Done

use string builder than concatenating the strings!.

use string builder than concatenating the strings!.

Looks good (just a few comments added) - please create PR for Sakaiproject github repo too

Looks good (just a few comments added) - please create PR for Sakaiproject github repo too

Delete? Not used

Delete? Not used

Another comment typo

Another comment typo

Cut-n-paste error?

Cut-n-paste error?

This chunk of code is repeated as in getMailArchiveChannels(), can be refactored to reuse!

This chunk of code is repeated as in getMailArchiveChannels(), can be refactored to reuse!

The Lines 172-176 is also repeated in getMailArchiveChannels(). You take that chunk of code to a private method and call it from both methods

The Lines 172-176 is also repeated in getMailArchiveChannels(). You take that chunk of code to a private method and call it from both methods

SAK-30211 add MailArchive EntityProvider
SAK-30211 add MailArchive EntityProvider