SAK-25556 - Annnouncements: Assignment Open Date announcement in wrong order in...

Activity

SAKTRUNK-97 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 6m 1 Yeah, thanks. I think I'd wanted the default to be true, ...
Reviewer - 100% reviewed 1m 1 This looks good to me Matt. This seems sane and like it s...
Total   8m 2  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Sam Ottenhoff

This looks good to me Matt. This seems sane and like it should be enabled by ...

This looks good to me Matt. This seems sane and like it should be enabled by default.

Matthew Jones

Yeah, thanks. I think I'd wanted the default to be true, not sure why I'd lef...

Yeah, thanks. I think I'd wanted the default to be true, not sure why I'd left it false. Just wanted it to be able to be disabled in-case of performance or other concerns.

/announcement-impl/.../impl/BaseAnnouncementService.java Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against