Add attachments, descriptions & short descriptions to Forums entity broker feed

Activity

SAKTRUNK-93 8

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 10m 4 Added comment with class purpose.
Reviewer - Complete 11m 2 The title says changes are for "Forumn entity broker feed...
Reviewer - Complete 13m 2 List description what this class doing
Reviewer - Complete 5m    
Reviewer - Complete 4m    
Total   43m 8  
#permalink

Objectives

Add attachments, descriptions & short descriptions to the following Forums entity broker feed:
/direct/topic/site/siteId.json. I extracted these changes from the Indiana University branch and manually merged them into sakai trunk.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Zhen Qian

The title says changes are for "Forumn entity broker feed". I can only find t...

The title says changes are for "Forumn entity broker feed". I can only find the TopicEntityProviderImpl.java diff. Would ForumEntityProviderImpl.java also need to be changed?

Reggie Rodrigues

I think the title says "Forum" because this change pertains to the forum tool...

I think the title says "Forum" because this change pertains to the forum tool. The jira ticket specified the following resource: /direct/topic/site/siteId.json. Maybe Beth can confirm this is the case.

/messageforums-api/.../entity/DecoratedAttachment.java Added   4
Open in IDE #permalink
/messageforums-api/.../entity/DecoratedForumInfo.java Changed  
Open in IDE #permalink
/messageforums-api/.../entity/DecoratedTopicInfo.java Changed  
Open in IDE #permalink
/messageforums-component-impl/.../entity/TopicEntityProviderImpl.java Changed   2
Open in IDE #permalink
/messageforums-components/.../WEB-INF/components.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against