DASH-324 Dashboard displays events for a student who has dropped a course

Activity

SAKTRUNK-88 22

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 40m 9 Done. Used static string instead of boolean.
Reviewer - Complete 21m 2 Should we add any information about how often this job ex...
Reviewer - Complete 25m 4 remove TODO
Reviewer - Complete 45m 4 How do we know this will only run on a single server? It...
Reviewer - Complete 20m 3 I'd rather use ItemType.CALENDAR_ITEM and ItemType.NEWS_I...
Total   2h 31m 22  
#permalink

Objectives

This patch create a quartz job that

1) get the site list and their users from DASH_NEWS_LINK and DASH_CALENDAR_LINK table;

2) get those sites current user list from Sakai

3) compare the dashboard user set and Sakai user set for those sites. Add or remove dashboard record if necessary.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

How do we know this will only run on a single server? It's not good to trap ...

How do we know this will only run on a single server?

It's not good to trap the very unspecific Exception.

/app/src/.../app/DashboardCommonLogic.java Changed  
Open in IDE #permalink
/impl/src/.../dao/impl/DashboardDaoImpl.java Changed  
Open in IDE #permalink
/impl/src/.../mapper/ContextUserMapper.java Added   4
Open in IDE #permalink
/impl/src/java/.../dash/dao/DashboardDao.java Changed  
Open in IDE #permalink
/impl/src/.../jobs/DashSyncUserSitesJob.java Added   7
Open in IDE #permalink
/impl/.../logic/DashboardCommonLogicImpl.java Changed   6
Open in IDE #permalink
/impl/src/resources/hsqldb.properties Changed  
Open in IDE #permalink
/impl/src/resources/mysql.properties Changed  
Open in IDE #permalink
/impl/src/resources/oracle.properties Changed   2
Open in IDE #permalink
/impl/src/.../dash/mock/DashboardDaoMock.java Changed   2
Open in IDE #permalink
/pack/src/webapp/WEB-INF/components.xml Changed  
Open in IDE #permalink
/DASH-324.diff Added
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against