Code Review for Become User Webservice

Activity

SAKTRUNK-85 17

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 30m 8 done
Reviewer - Complete 16m 4 need log here.
Reviewer - Complete 12m 1 This comment seems like it is switched with the comment o...
Reviewer - Complete 12m 2 Minor point: This would be shorter (and I think clearer) ...
Reviewer - Complete 4m 2 I'd make this all one line – having the line continuation...
Total   1h 14m 17  
#permalink

Objectives

The jira https://jira.sakaiproject.org/browse/SAK-27770. The work is done by IU. I am merging it to Sakai trunk . One of thinks the review focus should be CSRF implications.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Beth Kirschner

Please include JIRA with all code reviews - I believe this is for https://jir...

Please include JIRA with all code reviews - I believe this is for https://jira.sakaiproject.org/browse/SAK-27770

/core-providers/.../providers/SessionEntityProvider.java Changed   14
Open in IDE #permalink
/core-providers/.../java/session.properties Changed   2
Open in IDE #permalink
/core-providers/.../WEB-INF/applicationContext.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against