Activity

SAKTRUNK-79 3

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 9m 1 As I was doing some additional testing in Assignments I n...
Reviewer - 100% reviewed 6m 1 looks good to me!
Reviewer - Complete 4m    
Reviewer - Complete 5m    
Reviewer - Complete 9m 1 All looks good to me!
Total   33m 3  
#permalink

Objectives

There are still several assignments fields missing from the existing entity provider that we'd like to include:
1) Grade scale SAK-25993
2) Supplement Items text (Modal Answer, Private Note, All Purpose note)
3) Student submission (type)
4) Allow resubmission flag

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Beth Kirschner

All looks good to me!

All looks good to me!

Reggie Rodrigues

As I was doing some additional testing in Assignments I noticed I had to also...

As I was doing some additional testing in Assignments I noticed I had to also change five .vm files because they had code like "#set ($gradeScale = $assignment.getContent().getTypeOfGradeString($assignment.getContent().getTypeOfGrade()))".
I changed it to "#set ($gradeScale = $assignment.getContent().getTypeOfGradeString())"

Zhen Qian

looks good to me!

looks good to me!

/assignment-api/.../api/AssignmentConstants.java Changed  
Open in IDE #permalink
/assignment-api/.../api/AssignmentContent.java Changed  
Open in IDE #permalink
/assignment-bundles/resources/assignment.properties Changed  
Open in IDE #permalink
/assignment-impl/.../impl/BaseAssignmentService.java Changed  
Open in IDE #permalink
/assignment-tool/.../entityproviders/AssignmentEntityProvider.java Changed  
Open in IDE #permalink
/assignment-tool/.../tool/AssignmentAction.java Changed  
Open in IDE #permalink
/assignment-tool/.../WEB-INF/applicationContext.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against