Use Excel instead of CSV for exports

Activity

SAKTRUNK-58 5

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 7m    
Reviewer - 0% reviewed 0m    
Reviewer - 16% reviewed 5m 1 I have reviewed the patch and looks good, but found some ...
Aaron Zeckoski (deleted user)
Reviewer - 0% reviewed      
Reviewer - 50% reviewed 6m 3 This looks like it is from another patch.
Reviewer - 16% reviewed 3m 1 Hi, this change that is included in the crucible is not i...
Reviewer - 0% reviewed      
Total   21m 5  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Sam Ottenhoff

I have reviewed this patch. It looks good to me.

I have reviewed this patch. It looks good to me.

Miguel Carro Pellicer (Samoo)

I have reviewed the patch and looks good, but found some string comparisons t...

I have reviewed the patch and looks good, but found some string comparisons that doesn't follow best practices, i corrected them and attached a new version of the patch.

/assignment-bundles/resources/assignment.properties Changed   3
Open in IDE #permalink
/assignment-bundles/resources/assignment_ca_ES.properties Changed  
Open in IDE #permalink
/assignment-bundles/resources/assignment_es_ES.properties Changed  
Open in IDE #permalink
/assignment-impl/.../impl/BaseAssignmentService.java Changed  
Open in IDE #permalink
/assignment-tool/.../tool/AssignmentAction.java Changed  
Open in IDE #permalink
/assignment-tool/.../assignment/chef_assignments_instructor_uploadAll.vm Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against