Review SAK-23897 Site Info -> Import from site needs to run in a seperate thread...

Activity

SAKTRUNK-5 3

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 9m    
Reviewer - 100% reviewed 14m 1 I've added 2 new patches to the jira (siteinfo update and...
Reviewer - Complete 10m 2 How about a Sakai event at the beginning and end of the i...
Reviewer - 0% reviewed 0m    
Total   33m 3  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Sam Ottenhoff

How about a Sakai event at the beginning and end of the import? This would al...

How about a Sakai event at the beginning and end of the import? This would allow us to track down problematic users/imports.

Bryan Holladay

I've added 2 new patches to the jira (siteinfo update and a kernel patch). I ...

I've added 2 new patches to the jira (siteinfo update and a kernel patch). I couldn't figure out how to update crucible, so I'm assuming it's because I'm not the author. Also, I don't get any emails about anything on this (assigning, comments, etc)

/news-impl/impl/.../impl/BasicNewsService.java Changed  
Open in IDE #permalink
/web-impl/impl/.../impl/WebServiceImpl.java Changed  
Open in IDE #permalink
/site-manage-api/.../api/UserNotificationProvider.java Changed  
Open in IDE #permalink
/site-manage-impl/.../bundle/UserNotificationProvider.properties Changed  
Open in IDE #permalink
/site-manage-impl/.../impl/ETSUserNotificationProviderImpl.java Changed  
Open in IDE #permalink
/site-manage-impl/.../impl/UserNotificationProviderImpl.java Changed  
Open in IDE #permalink
/site-manage-tool/.../bundle/sitesetupgeneric.properties Changed  
Open in IDE #permalink
/site-manage-tool/.../tool/SiteAction.java Changed   1
Open in IDE #permalink
/site-manage-tool/.../sitesetup/chef_site-siteInfo-list.vm Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against