SAK-25801 the implementations of functions inside UserPrefsEntityProvider are...

Activity

SAKTRUNK-47 9

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 20m 4 Done. Instructions are added.
Reviewer - 0% reviewed      
Patrick Haggood (deleted user)
Reviewer - 100% reviewed 15m    
Reviewer - Complete 0m    
Reviewer - Complete 28m 5 Great. Do all the other methods return appropriate status...
Reviewer - Complete 4m    
Total   1h 7m 9  
#permalink

Objectives

Implemented a couple of userPrefs EntityProvider functions

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

Should the entityprovider methods implementations provide an explicit http st...

Should the entityprovider methods implementations provide an explicit http status code? I.e. if, for example, the delete method fails does the http call result come back with a status code of 200? Or with an error status?

Zhen Qian

Done. it turns 404 if the entity is not found and 403 if the user is not perm...

Done. it turns 404 if the entity is not found and 403 if the user is not permitted to see it.

David Haines

Great. Do all the other methods return appropriate status codes now too?

Great. Do all the other methods return appropriate status codes now too?

/UserPrefsEntityProvider.java Changed 6
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against