SAK-23143 - Clean up new properties on pages and tools

Activity

SAKTRUNK-43 14

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 4m    
Reviewer - Complete 2m    
Reviewer - 100% reviewed 1m    
Total   7m 14  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Matthew Buckett

I don't think any of the suggested NPE checks should be implemented as unless...

I don't think any of the suggested NPE checks should be implemented as unless something has gone seriously wrong they should all return non-null values.

Adding null checks to the code just implies that it's an expected return value and may well mask the real problem.

Ideally the documentation on the methods should be improved to say they never return null.

Matthew Buckett

Looks good to me

Looks good to me

/site/trunk/.../tool/AdminSitesAction.java Changed 12
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against