Improvements to Account Validator

Activity

SAKTRUNK-35 18

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 2h 24m 13 (3 defects) This is revision 2 of https://jira.sakaiproject.org/brows...
Reviewer - 6% reviewed 8m 1 If I'm looking at the right Joda Time, it appears to have...
Aaron Zeckoski (deleted user)
Reviewer - 0% reviewed 3m    
Reviewer - 0% reviewed      
Reviewer - 0% reviewed      
Reviewer - 31% reviewed 2m    
Reviewer - 0% reviewed      
Total   2h 37m 18 (3 defects)  
#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Brian Baillargeon

Note that there are methods that depend on KNL-1123

Note that there are methods that depend on KNL-1123

Brian Baillargeon

This is revision 2 of https://jira.sakaiproject.org/browse/SAK-24427. All the...

This is revision 2 of https://jira.sakaiproject.org/browse/SAK-24427. All the defects found up to January 23rd have since been resolved in revision 3 which has been attached to the ticket

/account-validator-api/.../model/ValidationAccount.hbm.xml Changed  
Open in IDE #permalink
/account-validator-api/.../model/ValidationAccount.java Changed  
Open in IDE #permalink
/account-validator-impl/.../bundle/validate_existingUser.xml Changed   1
Open in IDE #permalink
/account-validator-impl/.../bundle/validate_legacyUser.xml Changed  
Open in IDE #permalink
/account-validator-impl/.../bundle/validate_newPassword.xml Changed  
Open in IDE #permalink
/account-validator-impl/.../bundle/validate_newUser.xml Changed  
Open in IDE #permalink
/account-validator-impl/.../impl/ValidationLogicImpl.java Changed  
Open in IDE #permalink
/account-validator-tool/.../bundle/messages.properties Changed  
Open in IDE #permalink
/account-validator-tool/.../otp/AcountValidationLocator.java Changed   1
Open in IDE #permalink
/account-validator-tool/.../otp/ClaimLocator.java Changed  
Open in IDE #permalink
/account-validator-tool/.../producers/BaseValidationProducer.java Added  
Open in IDE #permalink
/account-validator-tool/.../producers/NewUserProducer.java Added  
Open in IDE #permalink
/account-validator-tool/.../producers/PasswordResetProducer.java Added   11
Open in IDE #permalink
/account-validator-tool/.../producers/TransferMembershipsProducer.java Added  
Open in IDE #permalink
/account-validator-tool/.../producers/ValidationProducer.java Changed  
Open in IDE #permalink
/account-validator-tool/.../WEB-INF/requestContext.xml Changed  
Open in IDE #permalink
/account-validator-tool/.../css/newUser.css Added  
Open in IDE #permalink
/account-validator-tool/.../css/passwordReset.css Added  
Open in IDE #permalink
/account-validator-tool/.../css/transferMemberships.css Added  
Open in IDE #permalink
/account-validator-tool/.../js/accountValidator.js Added  
Open in IDE #permalink
/account-validator-tool/.../templates/newUser.html Added   1
Open in IDE #permalink
/account-validator-tool/.../templates/passwordReset.html Added  
Open in IDE #permalink
/account-validator-tool/.../templates/transferMemberships.html Added  
Open in IDE #permalink
/account-validator-tool/.../templates/validate.html Changed  
Open in IDE #permalink
/reset-pass/src/.../bundle/Messages.properties Changed  
Open in IDE #permalink
/reset-pass/.../resetpass/FormProducer.java Changed   1
Open in IDE #permalink
/reset-pass/.../resetpass/UserValidator.java Changed   1
Open in IDE #permalink
/reset-pass/src/.../templates/form.html Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against