User Auditing Log

Activity

SAKTRUNK-19 39

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Greg Thomas (deleted user)
Author 1h 41m 15 Pending any other comments, I'm going to consider this re...
Reviewer - 43% reviewed 32m 13 applicationContext.xml is the default for Spring in a web...
Reviewer - 0% reviewed      
Aaron Zeckoski (deleted user)
Reviewer - 0% reviewed      
Reviewer - 0% reviewed 5m 3 I can say generally that we do hear this request from cli...
Reviewer - 0% reviewed      
Reviewer - Complete 58m 6 Replying to myself. Injection into a servlet is not as st...
Reviewer - 47% reviewed 22m 2 Are you doing anything with this connection? It looks lik...
Reviewer - 0% reviewed      
Total   3h 38m 39  
#permalink

Objectives

Indiana University has had a similar feature locally for roughly 2 years and found it to be valuable. Any changes to a user in a site (added to a site, removed from a site, had a role updated to something else in a site) will get logged in a database. The UI portion (located in the Site Info tool) grabs all the log entries and displays them. Individual tools also register their database "source" key and individual text that will get displayed in the UI. Currently, M and S are registered. M is a manual change done specifically by another user, e.g. a user was added to a site by an instructor via Site Info. S is a "Self Join/Unjoin" done by the a user in the Membership tool. Other tools can be added and registered via their components.xml if an institution wants more.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Greg Thomas (deleted user)

From the jira: *Changed the table name to USER_AUDITS_LOG *Edited mysql to...

From the jira:

  • Changed the table name to USER_AUDITS_LOG
  • Edited mysql to use a timestamp instead of datetime in the database
  • Edit comments about "not 100% accurate" to be more specific what is meant
  • Removed "childSiteId" from the database and the code since that's not needed for generic Sakai
  • Edited the text of the link and title from "User Event Log" to "User Audit Log"
  • Edited the sakai.properties attribute to only control rendering a link to the UI (no longer blocks writing info the database)
  • Added an auto incrementing ID for the primary key on the database table
  • Added sql to Sakai 10 (file is still 2.10) conversion script
  • Added function to delete logs


Not Done (yet): Where to call the function to delete logs

Steve Swinsburg

Don't add the conversion to the main CLE conversion scripts until this has be...

Don't add the conversion to the main CLE conversion scripts until this has been accepted for inclusion by the PMC.

Sam Ottenhoff

I can say generally that we do hear this request from clients: some do want a...

I can say generally that we do hear this request from clients: some do want an explicit way to know when a user was added/dropped.

Greg Thomas (deleted user)

Think I attached the 2nd patch. When you're viewing a file, you may have to d...

Think I attached the 2nd patch. When you're viewing a file, you may have to drag the little circle/line thing in the top left over to iteration 2 to see changes.

Greg Thomas (deleted user)

I actually messed up v5 a little bit missing some new files, but should be co...

I actually messed up v5 a little bit missing some new files, but should be correct in v6.

Fixed version 6

  • Updated pom.xml files to 10.0-SNAPSHOT
  • Added a listener that monitors for site.del events. If it finds one, it will extract the siteId and delete all entries in the table for that site
  • Added indexes to the sql scripts
  • Separated the "2.10" conversion script into a separate patch
  • Spacing adjustments in the code
  • Fixed bugs with wrong actions being logged via Realms tool after reorganizing from version 5

Greg Thomas (deleted user)

Pending any other comments, I'm going to consider this review closed at 5 PM ...

Pending any other comments, I'm going to consider this review closed at 5 PM Eastern time on Monday, in an effort to move this forward. If there's any other comments or concerns, please let me know. Thanks to everyone who took some time to look at this, as well!

/authz/authz-tool/.../tool/RealmsAction.java Changed   1
Open in IDE #permalink
/authz/authz-tool/tool/pom.xml Changed  
Open in IDE #permalink
/config/.../bundle/default.sakai.properties Changed   2
Open in IDE #permalink
/master/pom.xml Changed  
Open in IDE #permalink
/reference/.../conversion/sakai_2_10_0_mysql_conversion.sql Changed   5
Open in IDE #permalink
/reference/.../conversion/sakai_2_10_0_oracle_conversion.sql Changed   1
Open in IDE #permalink
/site-manage/.../bundle/UserAuditService.properties Added  
Open in IDE #permalink
/site-manage/.../impl/UserAuditSiteManageImpl.java Added  
Open in IDE #permalink
/site-manage/site-manage-impl/impl/pom.xml Changed  
Open in IDE #permalink
/site-manage/.../WEB-INF/components.xml Changed  
Open in IDE #permalink
/site-manage/.../impl/SiteAddParticipantHandler.java Changed   1
Open in IDE #permalink
/site-manage/site-manage-participant-helper/pom.xml Changed  
Open in IDE #permalink
/site-manage/.../bundle/sitesetupgeneric.properties Changed  
Open in IDE #permalink
/site-manage/.../tool/MembershipAction.java Changed   8
Open in IDE #permalink
/site-manage/.../tool/SiteAction.java Changed   1
Open in IDE #permalink
/site-manage/site-manage-tool/tool/pom.xml Changed  
Open in IDE #permalink
/userauditservice/.../api/UserAuditRegistration.java Added  
Open in IDE #permalink
/userauditservice/.../api/UserAuditService.java Added  
Open in IDE #permalink
/userauditservice/api/pom.xml Added  
Open in IDE #permalink
/userauditservice/deploy/shared/pom.xml Added  
Open in IDE #permalink
/userauditservice/deploy/pom.xml Added  
Open in IDE #permalink
/userauditservice/.../impl/UserAuditServiceImpl.java Added   1
Open in IDE #permalink
/userauditservice/.../impl/UserAuditSiteDeleteListener.java Added  
Open in IDE #permalink
/userauditservice/.../hsqldb/user_audits.sql Added  
Open in IDE #permalink
/userauditservice/.../mysql/user_audits.sql Added  
Open in IDE #permalink
/userauditservice/.../oracle/user_audits.sql Added   6
Open in IDE #permalink
/userauditservice/impl/pom.xml Added  
Open in IDE #permalink
/userauditservice/.../WEB-INF/components.xml Added  
Open in IDE #permalink
/userauditservice/pack/pom.xml Added  
Open in IDE #permalink
/userauditservice/.../bundle/UserAuditMessages.properties Added  
Open in IDE #permalink
/userauditservice/.../tool/UserAuditEventLog.java Added   3
Open in IDE #permalink
/userauditservice/.../WEB-INF/faces-config.xml Added  
Open in IDE #permalink
/userauditservice/tool/.../WEB-INF/web.xml Added  
Open in IDE #permalink
/userauditservice/.../tools/sakai.useraudit.xml Added  
Open in IDE #permalink
/userauditservice/tool/.../webapp/eventLog.jsp Added  
Open in IDE #permalink
/userauditservice/tool/pom.xml Added  
Open in IDE #permalink
/userauditservice/.../util/UserAuditJsfTool.java Added  
Open in IDE #permalink
/userauditservice/.../util/UserAuditRegistrationUtil.java Added   4
Open in IDE #permalink
/userauditservice/util/pom.xml Added  
Open in IDE #permalink
/userauditservice/pom.xml Added  
Open in IDE #permalink
/pom.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against