Merging back changes from...

Activity

SAKTRUNK-14 3

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 12m 2 Okay, I updated the source in rev 129945 and this looks l...
Total   12m 3  
#permalink

Objectives

129891: Merging back changes from https://source.sakaiproject.org/svn/assignment/branches/SAK-23904

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Sam Ottenhoff

Looks good.... Only issue I see is inconsistent tabs/spaces

Looks good.... Only issue I see is inconsistent tabs/spaces

Matthew Jones

Yea, I can never seem to get complete consistency with tabs/spaces. I general...

Yea, I can never seem to get complete consistency with tabs/spaces. I generally use eclipse to edit and haven't changed the defaults but sometimes the file has tabs other times it has spaces and it always looks perfect but never looks perfect in the diff. It looks like Sakai project is doing 8 spaces to a tab and in a few places it was expanding the tabs to 4 spaces.

I can fix all of these but not 100% sure how it happens.

Matthew Jones

Okay, I updated the source in rev 129945 and this looks like it reflects that...

Okay, I updated the source in rev 129945 and this looks like it reflects that. Thanks for the feedback. Also caught a hanging i.

/assignment/trunk/ Changed
Open in IDE #permalink
Repository SakaiTrunk does not exist
/assignment/.../tool/AssignmentAction.java Changed
Open in IDE #permalink
/assignment/.../assignment/chef_assignments_instructor_report_submissions.vm Changed
Open in IDE #permalink
/assignment/.../assignment/chef_assignments_instructor_student_list_submissions.vm Changed
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against