DASH-334 Adding or removing rosters is not recognized by the Dashboard

Activity

SAKTRUNK-102 11

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 10m 5 corrected
Reviewer - Complete 10m 5 Indentation is off in a few places.
Reviewer - Complete 8m 1 Technically 'out of scope' for this code review, but I'm ...
Total   28m 11  
#permalink

Objectives

While the cron DashSyncUserSiteJob executes, the session user is null, which makes the permission checking difficult to determine which entity is eligible for which user. The proposed fix here is the switch current session user to the user under-check, and restore the previous session user state.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

Indentation is off in a few places.

Indentation is off in a few places.

/impl/src/.../logic/DashboardLogicImpl.java Changed   10
Open in IDE #permalink
/pack/src/webapp/WEB-INF/components.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against