UMICH-1183 EntityBroker metadata stripped from EntityBroker feed with Java 8

Activity

CONTRIB-78 11

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 3m 5 Yes. https://crucible.sakaiproject.org/cru/CONTRIB-79 It...
Reviewer - 100% reviewed 20m 1 The changes made here is undoing the changes i made as pa...
Reviewer - Complete 10m 5 Can we have another code review with Pushyami's suggested...
Total   33m 11  
#permalink

Objectives

Please review the patch file. The patch removes the wrapper of mneme tool description in the "/mnmen/site" and "/mneme/my" calls. Instead, the json feed consists of list of mneme accessments. For comparison, I have attached json feeds prior or after the code change.

One thing to note there: the direct link to mneme assessment does not work. Pushyami, could you please take a look there?

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Pushyami Gundala

The changes made here is undoing the changes i made as part of UMICH-1182. Th...

The changes made here is undoing the changes i made as part of UMICH-1182. The work around i think is in support to the UMICH-1183 changes here is to put the Context block of the feed to each assessment

Beth Kirschner

Can we have another code review with Pushyami's suggested changes?

Can we have another code review with Pushyami's suggested changes?

Zhen Qian

Yes. https://crucible.sakaiproject.org/cru/CONTRIB-79 It has been reviewed a...

Yes. https://crucible.sakaiproject.org/cru/CONTRIB-79

It has been reviewed and closed

/mneme-tool/.../entityproviders/MnemeEntityProvider.java Changed   8
Open in IDE #permalink
/ctdev_mneme.json Added
Open in IDE #permalink
/localhost_mneme.json Added
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against