GOOGLE-48: Improve escaping of folder & file names in GDrive LTI

Activity

CONTRIB-6 7

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 20m 6 I'm not familiar with Jasmine. I'll look it up, but if yo...
Reviewer - 0% reviewed      
Reviewer - 0% reviewed      
Reviewer - 100% reviewed 6m 1 I'm not feeling knowledgeable enough to know off the top ...
Total   27m 7  
#permalink

Objectives

This issue is concerned with escaping special characters in folder and file names.



Part 1: Creating item names with special characters.

If you attempt to create a folder starting with:

\ / e.g. \ / test

(including spaces) it will not be created.

The following is returned (visible with developers' tools in the browser):

{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "parseError",
    "message": "Parse Error"
   }
  ],
  "code": 400,
  "message": "Parse Error"
 }
}


That folder name is valid in Google Drive, however.



Part 2: Displaying item names with special characters.

HTML in item names should be escaped and before being displayed, rather than rendered directly.

When Google Drive has an item named:

<i>test

It is displayed by GDLTI as "test" in italics. It should show the text of the HTML element instead.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

I'm not feeling knowledgeable enough to know off the top of my head if the ch...

I'm not feeling knowledgeable enough to know off the top of my head if the changes have the proper behavior. How about creating a jasmine test suite that will demonstrate that the javascript does the correct transformations?

Lance E Sloan

I'm not familiar with Jasmine. I'll look it up, but if you have any experienc...

I'm not familiar with Jasmine. I'll look it up, but if you have any experience with it, I'd appreciate your advice.

/umich/google/.../js/google-drive-utils.js Changed
/umich/google/.../webapps/js/googleDriveLti.js Changed 5
/umich/google/.../webapps/js/utils.js Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against