Separating the Google Permission calls on separate thread

Activity

CONTRIB-55 42

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 2h 26m 16 ServletException and IOException
Reviewer - Complete 10m 2 So there is no need to insert permission if the roster co...
Reviewer - Complete 42m 5 Is printStackTrace() needed? Maybe use log(e.getMessage())?
Reviewer - Complete 42m 4 Log the information unique to the timeout here and then u...
Reviewer - Complete 52m 15 The most cricical problems that need to be resolved, are ...
Total   4h 53m 42  
#permalink

Objectives

Background: While testing the Gdrive with roster size of 200, the permission calls took more than 5 minutes and duplicate permission call was created on server when browser trying to talk to server about it's previous ajax request. Server saw the Request from the browser as independent request, hence the duplication of call

The solution is to separate the google permissions calls on a separate thread and return immediate response to browser and use full message to user that "permission call can take some time".

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Beth Kirschner

The most cricical problems that need to be resolved, are 1) Copying roster ha...

The most cricical problems that need to be resolved, are
1) Copying roster hashmap to avoid ConcurrentModificationException
2) Using the duplicateSiteId.put() method to check if the siteId is already in play

Nice job overall!

David Haines

There are still indentation problems. The code would be much easier to read ...

There are still indentation problems.

The code would be much easier to read if the long text strings for messages were all put in as constants at the top of the file.

Only the helperLogMessage method should print a stack trace. If necessary add a flag to the method to say whether or not to print both the stacktrace in addition to the passing the exception to the log.

Loops should be examined to reduce duplications. See comments on removePermissionCallToGoogleOnSeparateThread method.

/src/.../bundle/googleDriveLTIProps.properties Changed  
Open in IDE #permalink
/src/main/.../lti/google/GoogleLtiServlet.java Changed   40
Open in IDE #permalink
/src/main/webapps/js/googleDriveLti.js Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against