Separating the Google Permission calls on separate thread

Activity

CONTRIB-54 7

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 52m 1 I will refactor it and will upload a new diff
Reviewer - 0% reviewed      
Reviewer - 0% reviewed      
Reviewer - Complete 40m 6 The code will be much easier to read when the message str...
Reviewer - 0% reviewed 0m    
Total   1h 32m 7  
#permalink

Objectives

Background: While testing the Gdrive with roster size of 200, the permission calls took more than 5 minutes and duplicate permission call was created on server when browser trying to talk to server about it's previous ajax request. Server saw the Request from the browser as independent request, hence the duplication of call

The solution is to separate the google permissions calls on a separate thread and return immediate response to browser and use full message to user that "permission call can take some time".

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

The code will be much easier to read when the message string building code is...

The code will be much easier to read when the message string building code is factored out into separate methods.

Pushyami Gundala

I will refactor it and will upload a new diff

I will refactor it and will upload a new diff

/src/.../bundle/googleDriveLTIProps.properties Changed   1
Open in IDE #permalink
/src/main/.../lti/google/GoogleLtiServlet.java Changed   4
Open in IDE #permalink
/src/main/webapps/js/googleDriveLti.js Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against