Improve error message to user when creating calendar for a site.

Activity

CONTRIB-53 7

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 13m 3 Discussed with Zhen and decided we can leave as it is wit...
Reviewer - 100% reviewed 12m 2 Do we want to attach some human readable message to this ...
Reviewer - Complete 0m 1 Looks ok provided IOException is the appropriate one.
Reviewer - Complete 4m 1 Looks good!
Total   29m 7  
#permalink

Objectives

Changes to provide more specific messages to users when: there is no Google calendar created for a site or there is a problem creating the Google calendar (user id not valid or communication problem with Google). This is part of JIRA GOOGLE-173.

The approach was to throw an exception when there is a problem creating the GoogleCredential (invalid user) or when actually creating the calendar. If an exception was not thrown during the calendar creation, we have a case where the Google calendar simply has not yet been created and we display the appropriate message.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

Looks ok provided IOException is the appropriate one.

Looks ok provided IOException is the appropriate one.

Reggie Rodrigues

The actual exception from Google when we try to create an access token with a...

The actual exception from Google when we try to create an access token with an invalid id is com.google.api.client.auth.oauth2.TokenResponseException which is a subclass of IOException. So I think we are ok.

Beth Kirschner

Looks good!

Looks good!

/gcalendar-api/.../api/SakaiGCalendarService.java Changed  
Open in IDE #permalink
/gcalendar-api/.../cover/SakaiGCalendarService.java Changed  
Open in IDE #permalink
/gcalendar-bundles/resources/gcalendar.properties Changed  
Open in IDE #permalink
/gcalendar-impl/.../impl/SakaiGCalendarServiceImpl.java Changed   4
Open in IDE #permalink
/gcalendar-tool/.../tool/GCalendarAction.java Changed  
Open in IDE #permalink
/gcalendar-tool/.../vm/chef_gcalendar_nocalendar.vm Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against