GOOGLE-68 Display useful error message when user doesn't have valid Google...

Activity

CONTRIB-5 12

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 35m 3 (1 defect) Only googleDriveLti.js has a requestGoogleAccessToken() f...
Reviewer - 100% reviewed 16m 4 Both this servlet and the googleDriveLti.js have function...
Reviewer - 0% reviewed      
Reviewer - Complete 27m 5 Make sure that the method of use of showLinkedGoogleFolde...
Total   1h 19m 12 (1 defect)  
#permalink

Objectives

85529:
GOOGLE-68

Display the message "You do not have a valid Google account." when the user's email address isn't associated with a valid Google account. Also send this message to the application log:

ERROR: User "username" does not have a valid Google account for Google Drive LTI. Unable to get access token. (Email: email; ID: userIdNumber)

I've extended review deadline since I will unfortunately be out of the office for a couple hours this afternoon. I want to allow enough time for discussion.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Lance E Sloan

Pushyami's direct feedback to me is that this check should apply to the non-"...

Pushyami's direct feedback to me is that this check should apply to the non-"learner"s, too. Also, the check should apply even when nothing is currently shared with the site.

  • Defect Ranking: Minor Classification: Missing

Lance E Sloan

Thanks to all of you for the review comments. I've come to the conclusion tha...

Thanks to all of you for the review comments. I've come to the conclusion that the obtaining of the access token should probably be factored out of the process for getting the folder list. That would make the code more understandable and easier to maintain. I think it will also make it easier to handle the other use cases Pushyami pointed out that are still affected by the lack of access token. I'll ask John about that. I focused closely on the one use case mentioned in the JIRA issue. Maybe the issue wasn't meant to be so literal.

/umich/.../bundle/googleDriveLTIProps.properties Changed
/umich/google/.../google/GoogleLtiServlet.java Changed 4
/umich/google/.../webapps/js/googleDriveLti.js Changed 4
/umich/google/.../pages/show-google-drive.jsp Changed 2
/umich/google/.../webapps/view/root.jsp Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against