Qualtrics backend changes

Activity

CONTRIB-46 72

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 1h 54m 31 The User value modification code is now factored out to a...
Reviewer - 15% reviewed 44m 5 should the error be more specific of the cause? There are...
Reviewer - Complete 44m 3 Lots of good comments throughout that make it helpful to ...
Reviewer - 0% reviewed      
Reviewer - Complete 1h 46m 13 more detailed error message logging is desired
Reviewer - Complete 59m 20 +1 for unit tests!
Total   6h 8m 72  
#permalink

Objectives

Review changes for Qualtrics backend including the jiras below. Review of each individual jira is not expected.

Changes to test code are included. Review of those are welcome but optional.

UI changes are not included in this review.

QUALTRICS-43: check for both settings and membership services on startup
QUALTRICS-78: prevent exposure of user tokens.
QUALTRICS-81: allow reading api server url value from system command line property
QUALTRICS-85: fail gracefully if token / user query parameters are missing
QUALTRICS-86: update panel errors
QUALTRICS-87: add explicit error if Qualtrics API server is not available
QUALTRICS-90: remove inconsistent properties unit test for the time being
QUALTRICS-91: add helper classes for better error messages
QUALTRICS-91: improve error reporting to user
QUALTRICS-91: rename variables for clarity
QUALTRICS-91: update string helper classes for nested string wrappers
QUALTRICS-91: update to new error message format, update corresponding unit tests
QUALTRICS-93: EB debugging addition
QUALTRICS-93: fixed properties handling
QUALTRICS-93: turn off phase 2 view with property
QUALTRICS-107: Servlet will not find settings in launch and will look them up explicitly.
QUALTRICS-111: refactor properties to allow multiple oauth credentials implementations
QUALTRICS-111: remove unneeded test file
QUALTRICS-111: switch to properties based OauthCredentials
QUALTRICS-111: update comments, add debug for properties injection
QUALTRICS-117: add landing page with dummy contents
QUALTRICS-117: revert bad checkin
QUALTRICS-122: implement dummy distribution provider.
QUALTRICS-122: refactor to create reusable qualtrics url class. add createDistribution class initial version
QUALTRICS-136 - better identify on client an error in the setting service
QUALTRICS-145: undo first attempt to make linked surveys json (which will fix type overriding bug)
QUALTRICS-149: add user first and last name to Qualtrics panel.
QUALTRICS-156: factor out string to constant
QUALTRICS-156: implement REST create distribution functionallity
QUALTRICS-157, QUALTRICS-158: support qualtrics distribution creation and recipient querying. Required some refactoring.
QUALTRICS-160: rename and add Java Json test
QUALTRICS-161: support new json format
QUALTRICS-164: remove panel only view from servlet code
QUALTRICS-169: add new properties to context (and remove some old ones).
QUALTRICS-169: new qualtrics lti properties: fix typo
QUALTRICS-172: improved error handling and reporting
QUALTRICS-175: provide meaningful panel names
QUALTRICS-177: return real json for linked surveys list.
QUALTRICS-183: revise qualtrics properties
QUALTRICS-186: move properties utilities class
QUALTRICS-191: address issue with spaces in path names
QUALTRICS-191: fix json parsing for surveys with responses
QUALTRICS-196 - change the wording of error message when tool is misconfigured
QUALTRICS-206: simultanious user data loss, backend work
QUALTRICS-208, QUALTRICS-219: reject settings update that are too long, add standard reporting convention for REST service errors
QUALTRICS-208: part 1: add call to make available the remaining number of bytes available in the setting string.
QUALTRICS-211: address illegal characters in settings
QUALTRICS-212, QUALTRICS-215: change print stack trace to log error, remove some unneeded comments
QUALTRICS-217: track additional information for panel creation
QUALTRICS-233: add REST call to get current server SID

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Pushyami Gundala

I see that lot of places hardcoded text which can be made constants and reuse

I see that lot of places hardcoded text which can be made constants and reuse

Reggie Rodrigues

Lots of good comments throughout that make it helpful to understand the purpo...

Lots of good comments throughout that make it helpful to understand the purpose of the classes and what they are trying to accomplish.

/ltiservlet/.../qualtricslti/DistributionCreateResult.java Added   5
Open in IDE #permalink
/ltiservlet/.../qualtricslti/LtiErrorMsgs.java Added   2
Open in IDE #permalink
/ltiservlet/.../qualtricslti/LtiProviderVelocityViewServlet.java Changed   43
Open in IDE #permalink
/ltiservlet/.../qualtricslti/PanelCreateResult.java Changed   2
Open in IDE #permalink
/ltiservlet/.../qualtricslti/PanelRecipients.java Added   6
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QImportPanel.java Changed  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QURLCreateDistribution.java Added   4
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QURLGetPanelRecipients.java Added   3
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QURLImportPanel.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QualtricsTokenFilter.java Changed   2
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QualtricsURLCreator.java Added   1
Open in IDE #permalink
/ltiservlet/src/.../qualtricslti/Setting.java Changed   1
Open in IDE #permalink
/ltiservlet/.../qualtricslti/StringWrapper.java Added  
Open in IDE #permalink
/ltiservlet/src/.../REST/DISTRIBUTION.vm Added  
Open in IDE #permalink
/ltiservlet/src/.../REST/LINKEDSURVEYS.vm Changed  
Open in IDE #permalink
/ltiservlet/src/main/webapp/REST/PANEL.vm Changed  
Open in IDE #permalink
/ltiservlet/src/.../webapp/REST/SETTING.vm Changed  
Open in IDE #permalink
/ltiservlet/src/.../webapp/REST/USERTOKEN.vm Changed  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/DistributionCreateResultJsonJacksonTest.java Added   1
Open in IDE #permalink
/ltiservlet/.../qualtricslti/JacksonJavaTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/JsonJacksonTest.java Changed  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/JsonJavaTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/LtiErrorMsgsTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/LtiProviderVelocityViewServletTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/PanelRecipientsTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QCreateDistributionTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QImportPanelTest.java Changed  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QURLGetPanelRecipientsTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/QualtricsURLCreatorTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/SettingStaticMethodTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/SettingTest.java Changed  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/StringWrapperTest.java Added  
Open in IDE #permalink
/ltiservlet/.../qualtricslti/XmlJacksonTest.java Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against