LTI-utils

Activity

CONTRIB-45 52

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 1h 3m 24 This may be useful in the looking at the UTF-8 issues. It...
Reviewer - Complete 1h 45m 15 can we do StringBuilder instead of string concatenation?
Reviewer - 100% reviewed 32m 3 person_contact_email_primary, person_name_family, person_...
Reviewer - Complete 24m 1 Do we want the err object here or maybe err.getMessage()?
Reviewer - Complete 22m 9 delete
Total   4h 7m 52  
#permalink

Objectives

Review changes for jiras listed below.

Some test files have been added. Review of test files is optional.

GOOGLE-138 passing the launch URL info to oauth
Google-138 code review changes
Google-37 code review changes
QUALTRICS-94: update log msg and readme
QUALTRICS-111: Add OauthCredentialsFactory and update OauthCredentials
QUALTRICS-149: add user first and last name to Qualtrics panel.
QUALTRICS-172: improved error handling and reporting
QUALTRICS-173: missing entry in roster causes NPE
QUALTRICS-180: update lti-utils readme.
QUALTRICS-186: move properties utilities class
QUALTRICS-202: log exceptions instead of printing them
QUALTRICS-206: clarify debug statements
QUALTRICS-208: part 1: add call to make available the remaining number of bytes available in the setting string.
QUALTRICS-210: change logging level for ssl messages
QUALTRICS-211: deal with failing to retrieve setting value with non-xml characters
QUALTRICS-228: update lti-utils trunk version
QUALTRICS-234: clarify documentation prior to code review

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
QUALTRICS-243
#permalink

General Comments

Pushyami Gundala

Should do a null check for the passed in value from the external application ...

Should do a null check for the passed in value from the external application to Lti-utils in most of the function calls before using it further

/src/main/.../lti/utils/ClientSslWrapper.java Changed   8
Open in IDE #permalink
/src/main/.../lti/utils/OauthCredentials.java Changed   2
Open in IDE #permalink
/src/.../utils/OauthCredentialsFactory.java Added   4
Open in IDE #permalink
/src/main/.../utils/PropertiesUtilities.java Added  
Open in IDE #permalink
/src/main/.../utils/RequestSignatureUtils.java Changed   4
Open in IDE #permalink
/src/main/.../lti/utils/RosterClientUtils.java Changed   14
Open in IDE #permalink
/src/main/.../utils/SettingsClientUtils.java Changed   12
Open in IDE #permalink
/src/main/java/.../its/lti/TcSessionData.java Changed   1
Open in IDE #permalink
/src/.../utils/OauthCredentialsFactoryTest.java Added   4
Open in IDE #permalink
/src/test/.../utils/RosterClientUtilsTest.java Added   2
Open in IDE #permalink
/README-lti-utils.txt Changed  
Open in IDE #permalink
/pom.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against