GAM-16 GAM-17 svm merge...

Activity

CONTRIB-4 20

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 1h 13m 9 Overall, looks good to me - I didn't see any performance ...
Reviewer - Complete 9m    
Reviewer - 44% reviewed 8m 8 For shame. Done.
Patrick Haggood (deleted user)
Reviewer - 0% reviewed 8m    
Reviewer - Complete 1h 1m    
Total   2h 39m 20  
#permalink

Objectives

GAM-16, GAM-17 - The Global Alert server needs to handle requests from the browser for config info and messages. This will remove dependency on legacy courier implementation.

Code review needs special focus on Javascript

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Beth Kirschner

Overall, looks good to me - I didn't see any performance risks. We may want t...

Overall, looks good to me - I didn't see any performance risks. We may want to raise the default/minimum limits from 10/30 seconds to 30/60 seconds.

/umich/global-alert/trunk/ Changed
Open in IDE #permalink
/umich/.../api/GlobalAlertService.java Changed
Open in IDE #permalink
/umich/.../impl/GlobalAlertServiceImpl.java Changed 2
Open in IDE #permalink
/umich/global-alert/trunk/tool/src/java/ Copied
Open in IDE #permalink
/umich/global-alert/trunk/.../src/java/org/ Copied
Open in IDE #permalink
/umich/global-alert/.../java/org/sakaiproject/ Copied
Open in IDE #permalink
/umich/.../sakaiproject/globalalert/ Copied
Open in IDE #permalink
/umich/global-alert/.../globalalert/servlet/ Copied
Open in IDE #permalink
/umich/.../servlet/GlobalAlertServlet.java Copied
/umich/global-alert/.../webapp/WEB-INF/web.xml Changed
Open in IDE #permalink
/umich/global-alert/.../webapp/css/gam.css Changed
Open in IDE #permalink
/umich/global-alert/trunk/.../webapp/js/gam.js Changed 16
/umich/global-alert/trunk/tool/pom.xml Changed
Open in IDE #permalink
/umich/.../util/GlobalAlertDelivery.java Changed 1
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against