Accesstoken generation and expiration handling

Activity

CONTRIB-30 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 11m    
Reviewer - Complete 0m    
Reviewer - Complete 25m 1 Consider making accessToken a constant as it is used to s...
Reviewer - Complete 31m 1 Since this is client time it may be in a different timezo...
Reviewer - 0% reviewed 1m    
Total   1h 9m 2  
#permalink

Objectives

86283: Google-106,Google-49 Accesstoken is generated during the POST, checking the token expiration and renewing it

To authenticate with Google to access their API we use service account oAuth flow. We don't let User authenticate them self but authentication is per application. Google Provides AccessToken per user after authenticating

Token were generated each time while Sharing and unsharing a folder and google refused to give more if too many are generated for a short time span(Google only know how they calculate and very little is provided in their documentation). SO the fix is not to generate too many token and handle the token expiration

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

There are no general comments on this review.
/umich/google/.../oauth/GoogleAccessToken.java Added
Open in IDE #permalink
/umich/google/.../oauth/GoogleSecurity.java Changed
/umich/google/.../google/GoogleLtiServlet.java Changed 1
/umich/google/.../webapps/js/googleDriveLti.js Changed 1
/umich/google/.../webapps/view/root.jsp Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against