Google-108 Manipulating the Setting service value in session

Activity

CONTRIB-29 10

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 19m 3 OK. will do
Reviewer - Complete 1m    
Reviewer - Complete 42m 5 Doesn't this assume that the value from the setting servi...
Reviewer - Complete 4m 2 All looks good with minor formatting change!
Total   1h 6m 10  
#permalink

Objectives

86232: Google-108 putting the Setting service value in session and manipulating the call from the value stored in session

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Beth Kirschner

All looks good with minor formatting change!

All looks good with minor formatting change!

/umich/.../google/GoogleConfigJsonWriter.java Changed 1
Open in IDE #permalink
/umich/google/.../google/GoogleLtiServlet.java Changed 5
/umich/.../lti/TcSiteToGoogleStorage.java Changed 3
/umich/google/.../webapps/js/googleDriveLti.js Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against