GOOGLE-108- Setting Service get call is not fetching results correct value, so...

Activity

CONTRIB-28 16

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 43m 2 Good catch
Reviewer - Complete 39m 5 "SettingValue" isn't very descriptive. What does it repre...
Patrick Haggood (deleted user)
Reviewer - 100% reviewed 20m    
Reviewer - Complete 39m 7 I suggest we do a design review of this implementation an...
Reviewer - Complete 7m 2 Ditto everything Dave said...
Total   2h 28m 16  
#permalink

Objectives

86144: GOOGLE-108- Setting Service get call is not fetching results correct value, so temperorely storing the settings value in the session

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

I'm unclear from this code how we can know that the cached value will be corr...

I'm unclear from this code how we can know that the cached value will be correct. I suspect this can be simplified.

I'm also concerned we are addressing a symptom not the problem.

Pushyami Gundala

My LTI tool.... as soon as i set value to setting service also access it righ...

My LTI tool.... as soon as i set value to setting service also access it right away. some time during getCall() intermittently not fetching correct result. I Don't see any overlapping of call between setCall() and GetCall() to setting service. I need to go into Setting service implemented code(blti project) and debugging it. It's like going into black box and debugging it. i know still blti is still our source code. I see the problem lies outside of my context. and Yes i am addressing a symptom and not a problem. But giving with the release of project soon this is the work around suggested.

I am not totally dependent on cached value. I am using combination of setting service value and cached value. I know the cases where the i expect a valid value and if i don't get one i building logic against the case.

How can we know the cached value is correct? .. I tested it and it seems to be working.

Beth Kirschner

Ditto everything Dave said...

Ditto everything Dave said...

David Haines

I suggest we do a design review of this implementation and create a testing p...

I suggest we do a design review of this implementation and create a testing plan. Caching is often quite hard to get right.

/umich/.../google/GoogleConfigJsonWriter.java Changed
/umich/google/.../google/GoogleLtiServlet.java Changed
/umich/.../lti/TcSiteToGoogleStorage.java Changed 12
/umich/google/.../pages/link-google-drive.jsp Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against