Changes to lti-utils roster utilities

Activity

CONTRIB-22 8

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 13m 3 The point of having it there currently is to have the ros...
Reviewer - Complete 56m 5 The logic in getRosteWithNames(). you can get all the inf...
Total   1h 9m 8  
#permalink

Objectives

sanity check changes
checkout pre-commit review

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Pushyami Gundala

Why is all the private functions are changed to protected?

Why is all the private functions are changed to protected?

Pushyami Gundala

I like the adding the Junit test cases to project

I like the adding the Junit test cases to project

David Haines

The private functions are now protected to make JUnit testing easier.

The private functions are now protected to make JUnit testing easier.

/src/main/.../lti/utils/RosterClientUtils.java Changed   5
Open in IDE #permalink
/src/test/.../utils/RosterClientUtilsTest.java Added  
Open in IDE #permalink
/pom.xml Changed  
Open in IDE #permalink

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against