GOOGLE-80 Hierarchical display of GD folders for instructor

Activity

CONTRIB-16 2

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 26m 1 Hi, all. Please don't shoot me. Yet. I noticed later tha...
Reviewer - 0% reviewed      
Reviewer - 0% reviewed 4m    
Reviewer - 0% reviewed 18m 1 Can you close this review and open a new one with the fin...
Total   49m 2  
#permalink

Objectives

85944:
GOOGLE-80

With some small alteration, the code used to display the contents of a shared folder to students is also used to display a tree of folders to the instructor, from which they can choose a folder to share. After this change, some of the old special-purpose folder list code should be removed, since it's now unused and obsolete.

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

Lance E Sloan

Hi, all. Please don't shoot me. Yet. I noticed later that the search feature...

Hi, all.

Please don't shoot me. Yet. I noticed later that the search feature no longer worked because the list of folders is constructed completely differently than it was before. It didn't make any sense to query GD again for matching folders, because they probably wouldn't display hierarchically. I've settled on a solution that simply highlights the matching folders. I'd like to call the user's attention to the matches, preferably by scrolling the first one into view. However, iframes can't be scrolled by JS. Another reason why we shouldn't use iframes.

David Haines

Can you close this review and open a new one with the final code?

Can you close this review and open a new one with the final code?

/umich/google/.../webapps/js/googleDriveLti.js Changed
/umich/google/.../pages/link-google-drive.jsp Changed

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against