GOOGLE-83 handling Better expection handling when a error occurs

Activity

CONTRIB-14 28

Keyboard shortcuts  
Summarize the review outcomes (optional)
 
#permalink

Details

Warning: no files are visible, they have all been filtered.
Participant Role Time Spent Comments Latest Comment
Author 1h 19m 6 Agreed. i can change what i have touched so far with this...
Reviewer - Complete 1h 1m 15 The setting service is running as part of the CTools clus...
Reviewer - Complete 13m 7 minor nit - indentation here would be good
Reviewer - Complete 26m    
Total   2h 58m 28  
#permalink

Objectives

85932: GOOGLE-83 handling Better expection handling when a error occurs

Branches in review

#permalink

Issues Raised From Comments

Key Summary State Assignee
#permalink

General Comments

David Haines

Any errors caught should leave enough information in the log so that someone ...

Any errors caught should leave enough information in the log so that someone reviewing the log in production will have some specific clue about the problem was and what it affected. E.g. "Setting read permission on folder <id> for user <user> failed with error code <code>" It usually isn't worth a lot of work to gather that information but it will often already be available close at hand. Log messages can be more specific than user messages.

David Haines

As much as possible we should not have duplicate sources of information. If t...

As much as possible we should not have duplicate sources of information. If tcsessiondata doesn't have the right information we should fix that rather than get it from a different source. If tcsessiondata is not available we should consider making it available.

David Haines

The comment on ajax usage may be out of the bounds of this review.

The comment on ajax usage may be out of the bounds of this review.

/umich/.../bundle/googleDriveLTIProps.properties Changed 7
/umich/google/.../google/GoogleLtiServlet.java Changed 15
/umich/.../lti/TcSiteToGoogleStorage.java Changed
/umich/google/.../webapps/js/googleDriveLti.js Changed 3

Review updated: Reload | Ignore | Collapse

You cannot reload the review while writing a comment.

Create issue

X
Assign To Me

Log time against