Clone
 

matthew buckett <buckett@bumph.org> in Sakai.Git

SAK-41197 Allow log job to include a stacktrace. (#6468)

The test logging job doesn't include a stacktrace, this adds the ability

to include a stacktrace in the test logging event.

SAK-41197 Allow log job to include a stacktrace. (#6468)

The test logging job doesn't include a stacktrace, this adds the ability

to include a stacktrace in the test logging event.

(cherry picked from commit 87d69fba18d8c893cd080671891f7c584da93257)

SAK-41196 Have the logger come from job configuration. (#6467)

The logger to use should come from the Job configuration.

(cherry picked from commit 7b869ad52138e19ff147e13984528497362ad2c2)

SAK-41196 Have the logger come from job configuration. (#6467)

The logger to use should come from the Job configuration.

SAK-41080 Add tests for HelpManagerImpl (#6389)

* SAK-41080 Add tests for HelpManagerImpl

This involved creating testings and removing unused code in the HelpManager API. Also unused files (hibernate) were removed and SizedList was also removed. The Sakai component configuration was split out into multiple files to make it easier to test.

    • -0
    • +55
    /help/help-component/src/resources/datastore.xml
    • -0
    • +58
    /help/help-component/src/resources/help-manager.xml
    • -0
    • +54
    /help/help-component/src/test/resources/help/toolid/help.xml
  1. … 5 more files in changeset.
SAK-40946 Also ignore the maven-wrapper.jar (#6420)

(cherry picked from commit b01bd2598765e5327b0a6265a0badcc2b778da2d)

SAK-40946 Also ignore the maven-wrapper.jar (#6420)

SAK-40946 Add maven wrapper to Sakai (#6257)

* SAK-40946 Add the maven wrapper to Sakai

This allows you not have to have downloaded maven before starting to build Sakai. Travis when doing CI builds will also use the wrapper instead of the installed maven. This allows us to directly control the maven version we want.

(cherry picked from commit 4e5d43f9d7f4d2a6a94bc61da846e00fa12e78b0)

    • -0
    • +110
    /.mvn/wrapper/MavenWrapperDownloader.java
    • -0
    • +1
    /.mvn/wrapper/maven-wrapper.properties
SAK-40946 Add maven wrapper to Sakai (#6257)

* SAK-40946 Add the maven wrapper to Sakai

This allows you not have to have downloaded maven before starting to build Sakai. Travis when doing CI builds will also use the wrapper instead of the installed maven. This allows us to directly control the maven version we want.

    • -0
    • +110
    /.mvn/wrapper/MavenWrapperDownloader.java
    • -0
    • +1
    /.mvn/wrapper/maven-wrapper.properties
SAK-41072 Cleanup help tool (unused files/JavaDoc). (#6382)

* EhCache isn’t needed here.

EhCache isn't used in this project and it's config file can be removed

and the pom.xml section can be removed.

* Fix for broken JavaDoc.

Correct JavaDoc references that got broken in a rename of packages.

* Remove unused files

These files aren't used in the current codebase.

* Move GlossaryEntryBean.

* Add dependency so validation of beans can happen.

This allows validation of the spring beans.xml file.

* Remove commented out dependencies.

    • -15
    • +0
    /help/help-component-shared/pom.xml
SAK-40943 Always include current user memberships (#6256)

When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

SAK-40943 Always include current user memberships (#6256)

When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

(cherry picked from commit fff82e9d99c3dd5b8e22906bce806c74a80e0802)

SAK-40943 Always include current user memberships (#6256)

When getting memberships for the current user the list of sites to return the results for were incorrectly getting filtered so that only the entries where the current user was allowed to view the roster in the site. That should have only been happening when the a non-admin user was looking for the memberships of a different user.

(cherry picked from commit fff82e9d99c3dd5b8e22906bce806c74a80e0802)

SAK-40871 Correctly pull through forename/surname. (#6203)

When the forename and surname were set on the user object but weren’t set on the ValidationAccount object the value would be shown in the form but then when submitted it would generate an error saying that the forename was empty.

This was because the value wasn’t set on the bean backing the form and RSF only updates values that are considered too have changed. The 2 ways this can be solved are:

- force the UIInputs to always update the bean. This means setting `mustapply` in the producer and then the default values are re-applied to the bean when the form data is read in even though the new value and the fossil values are the same. This isn’t optimal because we’re fixing it late in the call.

- update the ValidationAccount bean with defaults from the user object if they aren’t set on the ValidationAccount itself. This is the cleaner solution as the ValidationAccount bean correctly represents the state of the form.

SAK-40871 Correctly pull through forename/surname. (#6203)

When the forename and surname were set on the user object but weren’t set on the ValidationAccount object the value would be shown in the form but then when submitted it would generate an error saying that the forename was empty.

This was because the value wasn’t set on the bean backing the form and RSF only updates values that are considered too have changed. The 2 ways this can be solved are:

- force the UIInputs to always update the bean. This means setting `mustapply` in the producer and then the default values are re-applied to the bean when the form data is read in even though the new value and the fossil values are the same. This isn’t optimal because we’re fixing it late in the call.

- update the ValidationAccount bean with defaults from the user object if they aren’t set on the ValidationAccount itself. This is the cleaner solution as the ValidationAccount bean correctly represents the state of the form.

(cherry picked from commit d1a842d33352aa970d0331aec4fbcdb2d0fd3a31)

SAK-40483 Don’t log error when gradebook missing. (#5893)

If there isn’t a gradebook in the current site don’t log a failure to find the gradebook when attempting to sync grades, instead just don’t attempt to do the sync.

Also improved security advisor handling to use correct push/pop.

(cherry picked from commit 5569ad67b1724d51fe338290cbef149c2e075c78)

SAK-40483 Don’t log error when gradebook missing. (#5893)

If there isn’t a gradebook in the current site don’t log a failure to find the gradebook when attempting to sync grades, instead just don’t attempt to do the sync.

Also improved security advisor handling to use correct push/pop.

SAK-40482 LTI copying doesn’t need site.upd (#5894)

It can be the case that users don’t have the site.upd permission on My Workspace (My Home), this means that when they visit an LTI tool that attempts to patch it’s content it fails because they aren’t allowed to update the LTI tool.

This uses the DAO method which doesn’t do permission checks so it works for people without site.upd permission.

(cherry picked from commit ab9312e0f19017fcc0b94430dfca633f26424451)

SAK-40482 LTI copying doesn’t need site.upd (#5894)

It can be the case that users don’t have the site.upd permission on My Workspace (My Home), this means that when they visit an LTI tool that attempts to patch it’s content it fails because they aren’t allowed to update the LTI tool.

This uses the DAO method which doesn’t do permission checks so it works for people without site.upd permission.

SAK-40327 Better auto provisioning of jobs/triggers. (#5796)

* SAK-40327 Added auto provisioning of jobs support.

This allows other services to automatically provision jobs and triggers into the scheduler at startup. This uses the standard XML that quartz supports.

* SAK-40327 event log purge switch to auto provision

Switch the trigger event log to use the newer auto provisioning rather than the spring XML.

    • -2
    • +20
    /jobscheduler/scheduler-component/pom.xml
    • -0
    • +41
    /jobscheduler/scheduler-utils/pom.xml
    • -0
    • +46
    /jobscheduler/scheduler-utils/src/resources/sample.xml
SAK-40300 Give good error if failed to parse cron (#5784)

When a cron expression can’t be parsed by Quartz we should include any

message that was generated by Quartz in the error message. We also remove

the check for trailing ‘* *’ or ‘? ?’ as Quartz catches this now.

SAK-31929 Detect event type on import correctly (#5626)

* SAK-31929 Correctly detect event types when importing.

The calendar importer wasn’t correctly detecting the event types when importing from CSV file.

* SAK-31929 Unit Tests for Calendar CSV parsing.

SAK-40012 Remove the longDataSource (#5605)

This used to be used to separate file uploads/downloads from using all the connections in the pool, but it isn’t used any more and can be removed.

SAK-38304 Consolidate isolateContainingId()/isolateName() methods (#5509)

There were multiple copies of the same method across multiple files in the codebase, although this method is small putting them all the kernel utilities project means new uses can call them and all the existing copies can be removed.

SAK-34030 Only have a single setter for RSF (#5428)

When binding parameters from a request to a bean RSF isn’t predictable in which setter will get used, this results in the binding failing 50% of the time. By renaming one of the methods we force RSF to use the one we want all the time.

SAK-33883 Provide option to export the display ID. (#5271)

For deployments that use a display ID it’s often more useful to have this included in the gradebook export. We don’t use this in-place of the EID as it’s not guaranteed to be round trip-able whereas the EID always is.

SAK-33883 Provide option to export the display ID. (#5271)

For deployments that use a display ID it’s often more useful to have this included in the gradebook export. We don’t use this in-place of the EID as it’s not guaranteed to be round trip-able whereas the EID always is.

SAK-23694 Fail gracefully when role isn’t in group. (#5130)

When adding a member to a group that belongs to a site, if the role doesn’t exist in the group copy it out of the site and re-attempt the add of the member.

This follows the behaviour of creating the group (KNL-313) where the roles from the site are copied into the group even if they aren’t defined on the group template.

When failing to add a member to a AuthzGroup we give a better error message about what was being attempted.

This also handles the case where the user who is being added isn’t a member of the site any more.

(cherry picked from commit 6b9b87d65d985a3facd0d6733e54eef951e5e047)

SAK-23694 Fail gracefully when role isn’t in group. (#5130)

When adding a member to a group that belongs to a site, if the role doesn’t exist in the group copy it out of the site and re-attempt the add of the member.

This follows the behaviour of creating the group (KNL-313) where the roles from the site are copied into the group even if they aren’t defined on the group template.

When failing to add a member to a AuthzGroup we give a better error message about what was being attempted.

This also handles the case where the user who is being added isn’t a member of the site any more.

SAK-33684 Handle SMTP FROM that isn’t email better (#5080)

Have better handling of a client attempting to send an email where the FROM address isn’t an email address that we can parse. This may be because it’s empty or it’s not an email address.

(cherry picked from commit c05438c0bdf67c51b1890767c35c55f82dc756e5)