Clone
Tools

 

jim eng <jimeng@umich.edu> in Sakai.Git

About

1,156 commits
  • Committer is not mapped to a user
  • First commit: 09 August 2005
  • Last commit: 16 October 2013
Last Week All Time
Commits: 0 1,156

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 16 Oct 2013
8:29 am

Jim Eng <jimeng@umich.edu>

DASH-285 Move the delay so it is not counted in the diagnostics (and so it can occur on each iteration if the event-queue is empty).

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313506 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -9
    • +11
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
Tuesday 15 Oct 2013
11:37 am

Jim Eng <jimeng@umich.edu>

DASH-285 Improve logging of activity in maintenance tasks.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313501 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +3
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/impl/DashboardDaoImpl.java
    • -16
    • +55
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
Monday 14 Oct 2013
9:14 pm

Jim Eng <jimeng@umich.edu>

DASH-285 Log messages for updatingRepeatedEvents() only when actually running the update and only if loopTimerEnabled is true.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313500 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -5
    • +10
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
11:49 am

Jim Eng <jimeng@umich.edu>

DASH-285 Fix same typos in mysql queries.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313497 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /dashboard/impl/src/resources/mysql.properties
    • -1
    • +1
    /dashboard/impl/src/resources/mysql.sql
11:46 am

Jim Eng <jimeng@umich.edu>

DASH-285 Fix typos in SQL queries.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313496 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /dashboard/impl/src/resources/hsqldb.properties
    • -1
    • +1
    /dashboard/impl/src/resources/hsqldb.sql
    • -1
    • +1
    /dashboard/impl/src/resources/oracle.properties
    • -1
    • +1
    /dashboard/impl/src/resources/oracle.sql
9:47 am

Jim Eng <jimeng@umich.edu>

DASH-285 Set the loopTimerEnabledLocal property to 0 (false) if it's not already set.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313492 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +7
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
9:40 am

Jim Eng <jimeng@umich.edu>

DASH-285 Add optional diagnostic logging to dashboard event-processing loop.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313491 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +1
    /dashboard/app/src/java/org/sakaiproject/dash/app/DashboardConfig.java
    • -6
    • +86
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
    • -1
    • +2
    /dashboard/impl/src/resources/hsqldb.properties
    • -1
    • +2
    /dashboard/impl/src/resources/hsqldb.sql
    • -1
    • +2
    /dashboard/impl/src/resources/mysql.properties
    • -0
    • +1
    /dashboard/impl/src/resources/mysql.sql
    • -1
    • +2
    /dashboard/impl/src/resources/oracle.properties
    • -1
    • +2
    /dashboard/impl/src/resources/oracle.sql
Monday 05 Aug 2013
4:14 pm

Jim Eng <jimeng@umich.edu>

DASH-264 Removing misleading comment.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313465 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +0
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardLogicImpl.java
Friday 02 Aug 2013
1:28 pm

Jim Eng <jimeng@umich.edu>

DASH-264 This commit attempts to solve two related problems.

First, the commit attempts to execute database inserts of news-items, news-links, calendar-items and calendar-links in transactions such that the inserts will be committed before further database queries occur that might depend on those inserts. This is part of the effort to eliminate contention seen in recent load tests of dashboard. Further tuning may be possible by setting the isolation and/or propagation properties on the the transaction manager. If anybody has advice about better settings than the defaults, we should try them.

Second, the commit attempts to use batch-updates to insert collections of news-links and calendar-links. We believe this will improve the performance of the dashboard's event-processing thread.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313463 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +14
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/DashboardDao.java
    • -12
    • +103
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/impl/DashboardDaoImpl.java
    • -31
    • +148
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardLogicImpl.java
    • -0
    • +9
    /dashboard/impl/src/test/org/sakaiproject/dash/mock/DashboardDaoMock.java
    • -0
    • +45
    /dashboard/impl/src/test/org/sakaiproject/dash/mock/MockTransactionManager.java
    • -3
    • +8
    /dashboard/impl/src/test/org/sakaiproject/dash/test/DashboardLogicTest.java
    • -1
    • +8
    /dashboard/pack/src/webapp/WEB-INF/components.xml
Thursday 10 Jan 2013
8:43 am

Jim Eng <jimeng@umich.edu>

SAK-15196 Applied patch provided by Oxford.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@118233 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +2
    /citations/citations-servlet/servlet/pom.xml
    • -0
    • +13
    /citations/citations-tool/tool/pom.xml
    • -0
    • +190
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/entity/CitationEntityProvider.java
    • -0
    • +11
    /citations/citations-tool/tool/src/webapp/WEB-INF/applicationContext.xml
    • -0
    • +4
    /citations/citations-tool/tool/src/webapp/WEB-INF/web.xml
8:34 am

Jim Eng <jimeng@umich.edu>

SAK-20675 Applying patch supplied by Oxford to enable COiNS metadata.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@118231 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/CitationListAccessServlet.java
Wednesday 09 Jan 2013
1:30 pm

Jim Eng <jimeng@umich.edu>

SAK-20685 Added "news" as a synonym for "article" in BaseCitationService.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@118211 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +3
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseCitationService.java
12:22 pm

Jim Eng <jimeng@umich.edu>

SAK-22973 Reducing the log level of some messages so they will be less likely to show up in production unnecessarily.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@118204 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseConfigurationService.java
    • -2
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseSearchManager.java
    • -1
    • +1
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/DbCitationService.java
    • -4
    • +4
    /citations/citations-osid/web2bridge/src/java/edu/indiana/lib/twinpeaks/util/LogUtils.java
    • -2
    • +2
    /citations/citations-servlet/servlet/src/java/org/sakaiproject/citation/servlet/BatchCitationServlet.java
    • -1
    • +1
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
11:07 am

Jim Eng <jimeng@umich.edu>

SAK-23027 Fixed URL for removing selecting citations in _listCitations.vm template.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@118197 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -5
    • +0
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
    • -5
    • +11
    /citations/citations-tool/tool/src/webapp/vm/citation/_listCitations.vm
Tuesday 20 Nov 2012
3:04 pm

Jim Eng <jimeng@umich.edu>

SAK-22893 Adding a method to capture the user's selection of a notification level and using that when saving changes to a citation list. Defaults to no notification.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@116643 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +16
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
Monday 01 Oct 2012
10:39 am

Jim Eng <jimeng@umich.edu>

DASH-245 Add new mechanism for assigning tasks to particular servers in a cluster to ensure that no more than one server attempts a periodic task.

git-svn-id: https://source.sakaiproject.org/svn/dashboard/trunk@313416 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +14
    /dashboard/api/src/java/org/sakaiproject/dash/logic/DashboardLogic.java
    • -0
    • +13
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/DashboardDao.java
    • -11
    • +157
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/impl/DashboardDaoImpl.java
    • -0
    • +26
    /dashboard/impl/src/java/org/sakaiproject/dash/dao/mapper/TaskLockMapper.java
    • -218
    • +59
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardCommonLogicImpl.java
    • -0
    • +162
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/DashboardLogicImpl.java
    • -0
    • +193
    /dashboard/impl/src/java/org/sakaiproject/dash/logic/TaskLock.java
    • -0
    • +24
    /dashboard/impl/src/resources/hsqldb.properties
    • -0
    • +25
    /dashboard/impl/src/resources/mysql.properties
    • -0
    • +26
    /dashboard/impl/src/resources/oracle.properties
    • -1
    • +153
    /dashboard/impl/src/test/org/sakaiproject/dash/mock/DashboardDaoMock.java
    • -3
    • +12
    /dashboard/impl/src/test/org/sakaiproject/dash/mock/SakaiProxyMock.java
    • -3
    • +216
    /dashboard/impl/src/test/org/sakaiproject/dash/test/DashboardDaoTest.java
    • -4
    • +116
    /dashboard/impl/src/test/org/sakaiproject/dash/test/DashboardLogicTest.java
Thursday 06 Sep 2012
10:17 am

Jim Eng <jimeng@umich.edu>

SAK-22518 Added property "secondsBetweenSaveciteRefreshes" that can be set in citations config file to control the frequency of checks for updates during savecite searches.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@112171 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /citations/citations-api/api/src/java/org/sakaiproject/citation/api/ConfigurationService.java
    • -18
    • +20
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseConfigurationService.java
    • -4
    • +0
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/CitationListAccessServlet.java
    • -2
    • +2
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -17
    • +17
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
7:36 am

Jim Eng <jimeng@umich.edu>

SAK-22517 Fixed four additional calls for properties that are cast to strings immediately.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@112163 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseCitationService.java
    • -2
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/CitationListAccessServlet.java
Friday 31 Aug 2012
10:53 am

Jim Eng <jimeng@umich.edu>

SAK-22518 Make sure the default value is used if no value is set, and make sure the value is numeric and in reasonable range. Eliminate extraneous info-level logging.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@112033 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -11
    • +21
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseConfigurationService.java
    • -16
    • +8
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
10:30 am

Jim Eng <jimeng@umich.edu>

SAK-22518 Added new config property in citation module's ConfigurationService. Added code in CitationHelperAction to put the saveciteRefreshRate into json returned through AJAX. Added code in new_resource.js to use the saveciteRefreshRate to set times between update requests when savecite search window is open.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@112032 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +7
    /citations/citations-api/api/src/java/org/sakaiproject/citation/api/ConfigurationService.java
    • -0
    • +24
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseConfigurationService.java
    • -0
    • +4
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -4
    • +22
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
Thursday 30 Aug 2012
4:42 pm

Jim Eng <jimeng@umich.edu>

SAK-22517 Added parameter to Citation.getCitationProperty() method to force return of a single-value where client code is expecting a single value. Added tests to verify new method signature. Added single parameter version of the method for use in velocity templates.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@112008 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +15
    /citations/citations-api/api/src/java/org/sakaiproject/citation/api/Citation.java
    • -22
    • +35
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseCitationService.java
    • -2
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BasicCitationService.java
    • -3
    • +3
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/CitationListAccessServlet.java
    • -4
    • +4
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/DbCitationService.java
    • -1
    • +1
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/openurl/BookConverter.java
    • -2
    • +2
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/openurl/GenericConverter.java
    • -1
    • +1
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/openurl/JournalConverter.java
    • -5
    • +13
    /citations/citations-impl/impl/src/test/org/sakaiproject/citation/impl/BookConverterTest.java
    • -71
    • +71
    /citations/citations-impl/impl/src/test/org/sakaiproject/citation/impl/openurl/OpenURLServiceImplTest.java
Wednesday 22 Aug 2012
3:53 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Make sure on exit from helper that actionCanceled is false and actionCompleted is true. This ensures that folder is expanded.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111749 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
1:51 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Lowered most new log.info calls to log.debug and protect against string concatenation for log messages that do not get added to logs. Added css file for savecite template.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111745 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +3
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseConfigurationService.java
    • -6
    • +13
    /citations/citations-servlet/servlet/src/java/org/sakaiproject/citation/servlet/CitationServlet.java
    • -0
    • +29
    /citations/citations-servlet/servlet/src/webapp/css/savecite.css
    • -30
    • +68
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
1:29 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Completed auto-refresh after citations are added from search results.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111744 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -9
    • +11
    /citations/citations-servlet/servlet/src/webapp/vm/compact.vm
    • -23
    • +25
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
    • -6
    • +5
    /citations/citations-tool/tool/src/webapp/vm/citation/new_resource.vm
    • -0
    • +5
    /citations/citations-util/util/src/bundle/citations.properties
9:06 am

Jim Eng <jimeng@umich.edu>

SAK-22083 Improved formatting of confirmation page after adding citations from search. Corrected form of URLs for removing citations from collection via savecite servlet.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111736 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +2
    /citations/citations-servlet/servlet/src/java/org/sakaiproject/citation/servlet/BatchCitationServlet.java
    • -14
    • +50
    /citations/citations-servlet/servlet/src/java/org/sakaiproject/citation/servlet/CitationServlet.java
    • -0
    • +4
    /citations/citations-servlet/servlet/src/webapp/WEB-INF/web.xml
    • -3
    • +26
    /citations/citations-servlet/servlet/src/webapp/js/savecite.js
    • -19
    • +13
    /citations/citations-servlet/servlet/src/webapp/vm/_compact_citation.vm
    • -7
    • +10
    /citations/citations-servlet/servlet/src/webapp/vm/compact.vm
    • -0
    • +5
    /citations/citations-util/util/src/bundle/citations.properties
Tuesday 21 Aug 2012
10:23 am

Jim Eng <jimeng@umich.edu>

SAK-22083 Fixed export functions.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111685 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -5
    • +26
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/CitationListAccessServlet.java
    • -6
    • +6
    /citations/citations-servlet/servlet/src/java/org/sakaiproject/citation/servlet/CitationServlet.java
    • -77
    • +72
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -9
    • +17
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
    • -2
    • +5
    /citations/citations-tool/tool/src/webapp/vm/citation/new_resource.vm
    • -1
    • +7
    /citations/citations-util/util/src/bundle/citations.properties
Monday 20 Aug 2012
3:34 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Fixed paging for long lists of citations.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111662 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -2
    • +4
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
2:58 pm

Jim Eng <jimeng@umich.edu>

SAK-22414 Restore edit box for adding description to citation list.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111659 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +23
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -0
    • +7
    /citations/citations-tool/tool/src/webapp/vm/citation/new_resource.vm
    • -0
    • +1
    /citations/citations-util/util/src/bundle/citations.properties
2:19 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Added back access to reorder page.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111656 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -1
    • +1
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -0
    • +5
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
    • -0
    • +1
    /citations/citations-tool/tool/src/webapp/vm/citation/_listCitations.vm
1:24 pm

Jim Eng <jimeng@umich.edu>

SAK-22083 Reduced confusion betwixt resourceId and resourceUuid.

git-svn-id: https://source.sakaiproject.org/svn/citations/trunk@111655 66ffb92e-73f9-0310-93c1-f5514f145a0a

Options
    • -0
    • +1
    /citations/citations-api/api/src/java/org/sakaiproject/citation/api/CitationHelper.java
    • -1
    • +1
    /citations/citations-impl/impl/src/java/org/sakaiproject/citation/impl/BaseSearchManager.java
    • -25
    • +94
    /citations/citations-tool/tool/src/java/org/sakaiproject/citation/tool/CitationHelperAction.java
    • -8
    • +8
    /citations/citations-tool/tool/src/webapp/js/new_resource.js
    • -2
    • +2
    /citations/citations-tool/tool/src/webapp/vm/citation/new_resource.vm