Clone
 

david p. bauer <davidpbauer@users.noreply.github.com> in Sakai.Git

SAK-44207 Set hibernate.id.new_generator_mappings back to false after Hibernate upgrade (#8691)

The Hibernate 5 upgrade switched hibernate.id.new_generator_mappings to true by default

which made it so sequences set in hbm.xml files with class="native" would not get

created when auto.ddl was set to true to create the schema in a blank database. This

switches the property back to false to maintain the behavior before the Hibernate upgrade.

SAK-44373 Fix average gpa calculation in course grade statistics (#8635)

Average course gpa was calculated incorrectly as a percentage. This

maps the grade labels from the schema to a gpa value when entered in

the format "Grade (gpa)" e.g. "A (4.0)". And then calculates the average

course gpa based on the gpa values taken from the map or n/a if the

labels are not formatted correctly. This used when the grade schema is

set to Grade Points.

(cherry picked from commit c3462c463642061c1505561efc74435bf02ce9e5)

SAK-44373 Fix average gpa calculation in course grade statistics (#8635)

Average course gpa was calculated incorrectly as a percentage. This

maps the grade labels from the schema to a gpa value when entered in

the format "Grade (gpa)" e.g. "A (4.0)". And then calculates the average

course gpa based on the gpa values taken from the map or n/a if the

labels are not formatted correctly. This used when the grade schema is

set to Grade Points.

SAK-44373 Fix average gpa calculation in course grade statistics (#8635)

Average course gpa was calculated incorrectly as a percentage. This

maps the grade labels from the schema to a gpa value when entered in

the format "Grade (gpa)" e.g. "A (4.0)". And then calculates the average

course gpa based on the gpa values taken from the map or n/a if the

labels are not formatted correctly. This used when the grade schema is

set to Grade Points.

(cherry picked from commit c3462c463642061c1505561efc74435bf02ce9e5)

SAK-44373 Fix average gpa calculation in course grade statistics (#8635)

Average course gpa was calculated incorrectly as a percentage. This

maps the grade labels from the schema to a gpa value when entered in

the format "Grade (gpa)" e.g. "A (4.0)". And then calculates the average

course gpa based on the gpa values taken from the map or n/a if the

labels are not formatted correctly. This used when the grade schema is

set to Grade Points.

(cherry picked from commit c3462c463642061c1505561efc74435bf02ce9e5)

SAK-44294 Students unable to see rubric when no rating selected but points awarded (#8569)

If no rating was selected by the instructor but they set a point value, set the

selected value points to zero so that the rubric works as expected.

SAK-44294 Students unable to see rubric when no rating selected but points awarded (#8569)

If no rating was selected by the instructor but they set a point value, set the

selected value points to zero so that the rubric works as expected.

(cherry picked from commit 98b3916077330a403ea964a29ca5c04e5c5d0505)

SAK-44294 Students unable to see rubric when no rating selected but points awarded (#8569)

If no rating was selected by the instructor but they set a point value, set the

selected value points to zero so that the rubric works as expected.

(cherry picked from commit 98b3916077330a403ea964a29ca5c04e5c5d0505)

SAK-44285 Add missing property for Lessons layout error message (#8568)

SAK-44285 Add missing property for Lessons layout error message (#8568)

(cherry picked from commit e0152b46c9a3d5492f51260eaa4b90977124d410)

SAK-44158 Improve add and edit dialogs in Lessons (#8489)

Reorder add content menu items and split into three columns.

Removed scrolling attributes

Set position back to default when opening, which is centered on the window.

Set width to be the same as other modal windows when they open

Move groups of configuration options into collapsible panels

Made spacing more consistent

Format stuff used by BLTI was in the page stuff section so it was

never going to show. This moves it to its own section.

Prereq and required settings were duplicated to a pagestuff section. This

meant that non-page items that needed those settings couldn't access them

this is now fixed.

Fixed padding on input boxes, changed accordion buttons to links,

fixed the left hand menu width and display.

    • -3
    • +0
    /lessonbuilder/tool/src/webapp/css/checklist.css
    • -18
    • +60
    /lessonbuilder/tool/src/webapp/js/show-page.js
SAK-44157 New feature for users to add a preconfigured layout in Lessons (#8479)

This adds a new dialog that allows a user to add a layout from a template.

The layout consists of existing Lessons elements but adds them all at once

instead of forcing the user to add each step manually.

Add custom color schemes to layout. The existing color schemes will be

left as "Legacy" colors. Each color scheme has a no borders option.

This also changes edit section to a cog and moves the edit links inside

of the column box.

Improved expand collapse icons

Improve layout of column and section settings dialog

Only show settings relevant to what is being edited. Include new section

for color scheme.

Add show borders checkbox to column settings dialog

Remove the no-borders classes and add a checkbox to toggle borders on

the column dialogue. This matches the new Add Layout options.

Dark themes change the background color all others use a light gray background.

Allow instructors to change color of subpage buttons

Instructors now have the following options:

In the "Edit Subpage" dialog, can choose the color for individual subpage buttons.

In the section settings, force all subpage buttons within to be the same color scheme as the section itself

In the Add Layout dialog, choose to force all subpage buttons within to be the same color or not

In the Add Subpage dialog, choose what color the button should be.

    • -36
    • +265
    /lessonbuilder/tool/src/webapp/js/show-page.js
SAK-44153 Improvements to Group and Date Released Subpages in Lessons (#8478)

* SAK-44153 Improvements to Group and Date Released Subpages in Lessons

- Updated lesson page so hidden subpages would show "released on" instead of "Not released until" even

after the release date.

- Changed released color to be green. The color of the text will toggle depending on the state of whether

or not the page is visible.

- Links are visible but disabled in the tool menu if they are not released

- Make lessons subpage navigation group aware in the tool menu

- Add option for visible but inactive subpages

- Added release string to date released subpages for student view

- Added checkbox to hide subpage on the main subpage edit screen rather than in gear icon

- Add release date and Hidden properties to those copied in duplication

* SAK-44153 Cleanup old Lessons code

    • -26
    • +32
    /lessonbuilder/tool/src/webapp/js/show-page.js
    • -5
    • +5
    /library/src/webapp/js/lessons-subnav.js
SAK-44151 General small improvements and fixes for Lessons (#8477)

These improvements and bug fixes include:

- toggling a css class on section headers based on if the section is open or closed

- Fixing a typo in the polls markup causing styling inconsistencies

- Lowering all of the z-index values for lessons dialogs

- Fixing styling inconsistencies in Checklist feature

- Adding tabindex to the Learning Apps iframe

- Linked checklist items are broken when imported into a new site, but are not

indicated as broken to the user

- Change checklist item duplication to use JSON instead of String manipulation

- Fix date picker when no date is set

- Fix issue with checklist item indexes

- Fix auto select multiple choice on add question load

- Keep subpage group release info on duplication / import

- Fix group releasing LTI items in Lessons

    • -7
    • +20
    /lessonbuilder/tool/src/webapp/css/checklist.css
    • -2
    • +10
    /lessonbuilder/tool/src/webapp/js/checklist.js
    • -22
    • +28
    /lessonbuilder/tool/src/webapp/js/show-page.js
SAK-44159 Improvements to Reorder in the Lessons tool (#8480)

Reorder is still in one list. Sections and columns are outdented and

section name has been added to Section break.

Added preview link to reorder items

Items on the reorder page that used to be blank or did not

display anything useful now have a preview link to see the

content.

Move the add items from another page link to the main add content menu.

Add new embed items to the reorder page. Add back icon colors. Add new

icons for new reorder items. Fix z index issue with section dropdown menu.

Removed dropdown and replaced with two icons that accomplish

the same actions for a section.

    • -19
    • +52
    /lessonbuilder/tool/src/webapp/js/reorder.js
SAK-43674 Assignment reminder emails will never send (#8236)

Allow add assignment should be checked for each member of the site to

determine if an email reminder should be sent instead of checking the

permission of the current user. Fixes regression in SAK-42667

(cherry picked from commit 1db49889e1a2aa274db3be2acf5e48175421c37e)

SAK-43674 Assignment reminder emails will never send (#8236)

Allow add assignment should be checked for each member of the site to

determine if an email reminder should be sent instead of checking the

permission of the current user. Fixes regression in SAK-42667

SAK-43061 Add delete column to bulk edit modal in gbng (#7926)

Add additional functionality to the bulk edit modal that allows for

multiple items to be deleted. This feature also fixes the toggle all

for release and include columns.

Co-authored-by: kozar <jkozar2@udayton.edu>

(cherry picked from commit 70eb590284845867aa07252bf61435093749596c)

SAK-43061 Add delete column to bulk edit modal in gbng (#7926)

Add additional functionality to the bulk edit modal that allows for

multiple items to be deleted. This feature also fixes the toggle all

for release and include columns.

Co-authored-by: kozar <jkozar2@udayton.edu>

(cherry picked from commit 70eb590284845867aa07252bf61435093749596c)

SAK-43061 Add delete column to bulk edit modal in gbng (#7926)

Add additional functionality to the bulk edit modal that allows for

multiple items to be deleted. This feature also fixes the toggle all

for release and include columns.

Co-authored-by: kozar <jkozar2@udayton.edu>

SAK-41954 Update templates in CKEditor (#7054)

* SAK-41954 Update templates in CKEditor

This change updates the templates in the CKEditor, removes the old tempaltes,

turns on bootstrap styling in the editor, and makes the Templates label on

the button visible.

* SAK-41954 Add README to in case people want to add back the old templates

    • binary
    /library/src/webapp/image/genericProf.png
SAK-42221 SAK-34741 Lombok doesn't like boolean fields starting with is (#7195)

Getter for lombok automatically creates boolean accessor as isExtraCredit for

the field isExtraCredit instead of getIsExtraCredit or isIsExtraCredit.

When this is referenced in the template as .isExtraCredit it is not found because

neither getIsExtraCredit nor isIsExtraCredit exists. Changing the name of the

field in ItemBean to extraCredit allows Lombok to create the accessor isExtraCredit

which is then found when using .extraCredit in the template.

SAK-34741 SAKAI-2735 SAM-1113 Ability to flag question as Extra Credit (#7060)

* SAK-34741 SAKAI-2735 SAM-1113 Ability to flag question as Extra Credit

This allows instructors to flag questions in their assessment as extra credit. Extra credit questions

will not count towards the total possible points for an assessment. However, any points earned by the

student for answering the extra credit question correctly will be added to their total earned points

for that assessment. Currently, students are able to score over 100 percent on an assessment.

  1. … 25 more files in changeset.
SAK-41825 SAKAI-2720 Allow users to select a gradebook cateogry in sa… (#7059)

* SAK-41825 SAKAI-2720 Allow users to select a gradebook cateogry in samigo

This re-implements the work previously completed in SAKAI-278 for Sakai 11.

Instructors will be able to select a gradebook category from Samigo

for an assessment's associated gradebook item. Changes were made to the

original implementation to no longer use deprecated classes or methods.

Additionally, this expands upon the original feature to allow for

editing the category setting in published settings. This is done

by pulling in the GB setting everytime published settings is loaded

and then saving a new gradebook item if the category settings have

changed.

* SAK-41825 Use Spring to autowire gradebook service

This changed AssessmentSettingsBean and PublishedAssessmentSettingsBean to use

Spring to autowire the gradebook service, tool manager, and session manager

dependencies.

(cherry picked from commit ea6af82f8dceaa236bb62b3ee0f293a4abaf1b2b)

    • -0
    • +13
    /samigo/samigo-app/src/webapp/js/authoring.js
  1. … 6 more files in changeset.
SAK-41825 SAKAI-2720 Allow users to select a gradebook cateogry in sa… (#7059)

* SAK-41825 SAKAI-2720 Allow users to select a gradebook cateogry in samigo

This re-implements the work previously completed in SAKAI-278 for Sakai 11.

Instructors will be able to select a gradebook category from Samigo

for an assessment's associated gradebook item. Changes were made to the

original implementation to no longer use deprecated classes or methods.

Additionally, this expands upon the original feature to allow for

editing the category setting in published settings. This is done

by pulling in the GB setting everytime published settings is loaded

and then saving a new gradebook item if the category settings have

changed.

* SAK-41825 Use Spring to autowire gradebook service

This changed AssessmentSettingsBean and PublishedAssessmentSettingsBean to use

Spring to autowire the gradebook service, tool manager, and session manager

dependencies.

    • -0
    • +13
    /samigo/samigo-app/src/webapp/js/authoring.js
  1. … 6 more files in changeset.
SAK-40728 Bullhorn update count prevents portal timeout (#6091)

Indicate that update count ajax request is "auto" meaning it is

not a user request and should not prevent the user's session from

timing out.

SAK-40728 Bullhorn update count prevents portal timeout (#6091)

Indicate that update count ajax request is "auto" meaning it is

not a user request and should not prevent the user's session from

timing out.

(cherry picked from commit 71f74bd6ae1d52cb9a3667573cbd9b3cc5f99a62)

SAK-40642 Manage overview bug fixes (#6025)

When manage overview was originally written it used index 64 in SiteAction.

However, that index was taken in master and it needed to be changed to 65.

Also, fixed a couple of bugs with saving and canceling changes.

SAK-37980 Group visibility issue in Lessons tool (#5911)

When checking to see if an item should be visible there was an "always"

advisor pushed to the top of the security advisor stack before getting

the item's groups. This advisor makes it so that group release information

for a resource is ignored which makes the item stay in the list for the student

even though they don't have access to the resource. This fix pops the advisor

before getting the item groups.

3563 add auto=true to the GradebookNG AJAX polls (concurrent edits/server ping) so that the user session lastAccessedTime is not bumped (#3584) (#5534)

SAK-38438 Moved previous changes to new file locations - David Bauer <dbauer1@udayton.edu>

(cherry picked from commit 42a77bfe7039f7a4bd6e046891f88bbeb2548b13)