SakaiContrib

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
UMICH-1182 adding context info to each assessment in the site
UMICH-1183 EntityBroker metadata stripped from EntityBroker feed with Java 8
UMICH-1182 code review changes for the extending entity feed to include dates etc
Done

Done

Done.

Done.

Done

Done

Done

Done

Done

Done

fix formatting

fix formatting

Always use StringBuffer for concatenation - a lot less expensive: directURL = new StringBuffer( ServerConfigurationService.getPortalUrl() ); directURL.append( serverUrl); etc return directURL.toStr...

Always use StringBuffer for concatenation - a lot less expensive:
directURL = new StringBuffer( ServerConfigurationService.getPortalUrl() );
directURL.append( serverUrl);
etc
return directURL.toString()

Use constant (see above)

Use constant (see above)

I see you're just repeating a pattern all over the code of hard-coding this constant again and again, but it's still bad practice https://crucible.sakaiproject.org/static/nsjxqv/2static/images/wiki...

I see you're just repeating a pattern all over the code of hard-coding this constant again and again, but it's still bad practice
Please add this as a constant to MnemeService, and be sure to differentiate it from the APPLICATION_ID – I'd call it "SAKAI_MNEME_TOOL_ID.

Date should be 2015

Date should be 2015

Agreed

Agreed

Should the function name be: getMyAssessmentsForAllSites()?

Should the function name be: getMyAssessmentsForAllSites()?

UMICH-1182 extending the entity feed to have dates/ direct url
UMICH-1182 extending the entity feed to have dates/ direct url
UMICH-1182 extending the entity feed to have dates/ direct url
OK

OK

The thing is the mneme feed should not crash if the GB tool is associated or not associated with it. So i put better comment next time

The thing is the mneme feed should not crash if the GB tool is associated or not associated with it. So i put better comment next time

These statements say the exact opposite of each other: "Mneme RESTful feed crashes without gradebook tool" and "Mneme api feed won't crash if gradebook tool is not associated with it"

These statements say the exact opposite of each other: "Mneme RESTful feed crashes without gradebook tool" and "Mneme api feed won't crash if gradebook tool is not associated with it"

This comment is probably not necessary. The symbols are well-named, so it's easy to understand what's happening there.

This comment is probably not necessary. The symbols are well-named, so it's easy to understand what's happening there.

UMICH-1171 Mneme api feed won't crash if gradebook tool is not associated with it
UMICH-1171 Mneme api feed won't crash if gradebook tool is not associated with it
UMICH-1171 Mneme api feed won't crash if gradebook tool is not associated with it
No comments – looks good!

No comments – looks good!