Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
GOOGLE-158

Added code to load build info from build.txt, to display a bootbox-based modal dialog box for the "About" link, and to open the help page in a new window.

Clarify purpose of access token variables and related code. I.e., there isn't a special token handler, etc.

  1. … 1 more file in changeset.
GOOGLE-151

Also while debugging the IE problems, I noticed the title of the page was "Bootstrap, from Twitter", probably leftover from an example the first day this project was set up. I've replaced that with a new property that holds the application name, "GDrive".

  1. … 1 more file in changeset.
GOOGLE-151

Added DOCTYPE and meta element for X-UA-Compatible, which is supposed to make IE display GDrive in the proper compatibility mode. It doesn't seem to make a difference.

Simplified passing of application properties to JSP and JS.

  1. … 6 more files in changeset.
GOOGLE-143 - prevent navbar drop in smaller viewports, add ellipsis to meta data, remove hover effect, add right margin to add/share button
  1. … 1 more file in changeset.
Added code to support new gd.monthNames property.

  1. … 1 more file in changeset.
GOOGLE-102

Added labels for screen readers to folder expansion handles. Also added keyboard navigation note at top of page.

  1. … 3 more files in changeset.
GOOGLE-142

Removed old "Share Folder" link and associated property.

  1. … 2 more files in changeset.
GOOGLE-124

Removed old help links and content. Added new help links to new stand-alone help pages.

Consider making accessToken a constant as it is used to set and get the attribute value.

Consider making accessToken a constant as it is used to set and get the attribute value.

Since this is client time it may be in a different timezone than the server which will be a problem unless both are expressed in UTC. Also the clocks may well not be in sync so a more conservative ...

Since this is client time it may be in a different timezone than the server which will be a problem unless both are expressed in UTC. Also the clocks may well not be in sync so a more conservative check, like 45 minutes, would be good.

Accesstoken generation and expiration handling
Accesstoken generation and expiration handling
Google-106,Google-49 Accesstoken is generated during the POST, checking the token expiration and renewing it
  1. … 4 more files in changeset.
GOOGLE-134

Added underscore.js to simplify code, as suggested by dlhaines.

  1. … 1 more file in changeset.
Yes. I plan to get them all before the final commit.

Yes. I plan to get them all before the final commit.

It's in the jsTree lazy loading methods. As the code shows here, it was used in only one place and that has been removed, too.

It's in the jsTree lazy loading methods. As the code shows here, it was used in only one place and that has been removed, too.

It will be removed before the final commit.

It will be removed before the final commit.

Right. It has its problems. I didn't modify this part of the code and it seems to be working well for now, so I'm not going to touch it.

Right. It has its problems. I didn't modify this part of the code and it seems to be working well for now, so I'm not going to touch it.

Maybe. This is one of those sections of code that maintains the old table-based display, so it will be removed soon. CSS is not my strong suit and I suspect it wasn't for the person who wrote this ...

Maybe. This is one of those sections of code that maintains the old table-based display, so it will be removed soon. CSS is not my strong suit and I suspect it wasn't for the person who wrote this part of the code, either. They were trying to indent table row contents with this. I'm not sure how one would do that with CSS classes.

Yes.

Yes.

It probably should say ancestors. This function is one that will be removed anyway.

It probably should say ancestors. This function is one that will be removed anyway.

I intended for this part of the code to be an example for deleting nodes, to be used by other code later. I thought I commented it as such. Console logging will be removed before the final commit.

I intended for this part of the code to be an example for deleting nodes, to be used by other code later. I thought I commented it as such. Console logging will be removed before the final commit.