global-alert

Checkout Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[nojira] update gam pom.xml with correct parent version
Added version number back that was removed unintentionally
GAM-20 change logging level to debug for several log messages
GAM-20 revert inadvertant change to tag svn merge -r86023:86022
GAM-20 change logging level to debug for several log messages
Create tag GAM-1.1
GAM-18 - clean up respondin to crucible review
    • -140
    • +27
    ./trunk/tool/src/webapp/js/gam.js
For shame. Done.

For shame. Done.

OK, thanks.

OK, thanks.

The '^' is an "arrow up" - is the label of the control of a minimized Alert level 3.

The '^' is an "arrow up" - is the label of the control of a minimized Alert level 3.

These are development defaults. The production defaults are above. The defaults can be changed via the Resources in Global Alerts Admin site. Should we also have a property for these values?

These are development defaults. The production defaults are above. The defaults can be changed via the Resources in Global Alerts Admin site. Should we also have a property for these values?

These are the actual default values - I uncommented them and removed the "development" intervals (much smaller so that did not have to wait as long)

These are the actual default values - I uncommented them and removed the "development" intervals (much smaller so that did not have to wait as long)

Moot - this is for a safe (all browsers) logging function that is not used.

Moot - this is for a safe (all browsers) logging function that is not used.

Just commented them out. Potential memory leak.

Just commented them out. Potential memory leak.

Done

Done

May be an stupid question, but what is the purpose of setting text to '^' here?

May be an stupid question, but what is the purpose of setting text to '^' here?

Can those interval definition variables be configured outside of this js file?

Can those interval definition variables be configured outside of this js file?

The variable gamEvent is created but not used below.

The variable gamEvent is created but not used below.

Overall, looks good to me - I didn't see any performance risks. We may want to raise the default/minimum limits from 10/30 seconds to 30/60 seconds.

Overall, looks good to me - I didn't see any performance risks. We may want to raise the default/minimum limits from 10/30 seconds to 30/60 seconds.

Nit-picky - but maybe remove double comment?

Nit-picky - but maybe remove double comment?

Perhaps add a global boolean variable (debug) and only log these messages if debug == true? Otherwise, you'll have to rip out all the debug messages before deploying this to production.

Perhaps add a global boolean variable (debug) and only log these messages if debug == true? Otherwise, you'll have to rip out all the debug messages before deploying this to production.

Update comments (numbers aren't up-to-date, so I'd avoid using them)

Update comments (numbers aren't up-to-date, so I'd avoid using them)

delete TODO

delete TODO

Delete commented out code

Delete commented out code

Not sure what's going on here - can you put in a better comment?

Not sure what's going on here - can you put in a better comment?

Should this default to false? Actually, I'm not sure why there's optional support for this at all – if courier is deprecated and the new implementation works, shouldn't any code that supports couri...

Should this default to false? Actually, I'm not sure why there's optional support for this at all – if courier is deprecated and the new implementation works, shouldn't any code that supports courier be removed?

We need to document this configuration option in confluence: https://confluence.sakaiproject.org/display/GAM/Home

We need to document this configuration option in confluence: https://confluence.sakaiproject.org/display/GAM/Home