Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-30097 Removed hostname(server-url) from site-info url while storing in the DB.

Prepend the server url back to the site-info on the edit screen of home

page.

Merge pull request #995 from danielmerino/SAK-29301

SAK-29301 - Custom title applied on a per tool basis on Home pages in…

SAK-29301 - Custom title applied on a per tool basis on Home pages instead of customTitle page property.

Merge pull request #964 from buckett/KNL-1375

KNL-1375 Remove AuthzGroupService cover and refactor code to use ComponentManager

  1. … 6 more files in changeset.
SAK-29770 - Popup if tool description saved on home with html content

  1. … 1 more file in changeset.
KNL-1375 Remove uses of AuthzGroupService cover.

This removes all use the AuthzGroupService cover so we only have one API to maintain, for services it also makes testing easier as you can inject a test copy of the service.

  1. … 56 more files in changeset.
KNL-1375 Remove uses of AuthzGroupService cover.

This removes all use the AuthzGroupService cover so we only have one API to maintain, for services it also makes testing easier as you can inject a test copy of the service.

  1. … 56 more files in changeset.
SAK-29626 - Fix a missing former valye for the chosen icon.

SAK-29625 - Implement an icon picker in the LTI tools and Web Content Tool

Also makes progress on

SAK-29626 - Build a reusable icon picker

SAK-29646 - Add the ability to pick icons to the Web Content cool

  1. … 18 more files in changeset.
SAK-25883 Get the real path to the current root.

Then walk back up the tree and into the library folder. This is because

in Tomcat 8 the getRealPath is more strict and returns null when you

attempt to access another context.

In the long run this isn’t a good solution as we should be enabling people

to run without having to unpack webapps but it gets things working.

I haven’t added a null check in here as otherwise when we start looking

at running without unpacked WARs we’ll just lose the i18n.

SAK-27774

Teach the iframe portlet to be responsible for its own jQuery in case it

encounters morpheus.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@311739 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 4 more files in changeset.
SAK-25357 - Web content cannot display html pages with spaces

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@307705 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23914 change default to current site for attachments to Home web content

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@307037 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-25704 - More additional/specific tracking for web portlet

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@134345 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-24208

Make it so that popups happen as a result of a side effect of a user-click action

whenever possible so we do not see the "Allow popups" dialogs on the various

browsers.

This was trickier than it seemed, touching /direct/site, three tools, the

main portal, and PDA portal.

These modifications need to be committed or backported together as they have cross

dependencies.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@132825 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-24335 - Home (My Workspace Site Info) text processing inconsistent with site Info tool description

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@129944 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23875

Add the validation and sanitization code from KNL-1105 into the web content tool

to ease back-porting in case folks need the new features in a hurry.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@128949 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-23841

PortletIFrame.popupXFrame() method generates high database CPU load

This patch addresses a number of issues relating to when to and

not to do a popup.

- Change the default timeout to 6 hours.

- If a web site sends us an x-frame-options header - auto-tick the popup so there is no further checking (assume sites don't go backwards)

- Suppress checking if the prefix of the url matches the server url or the access url

- Add a new property iframe.xframe.popup=regex where if the regex matches the URL, the content is always done in a popup and the x-frame-options check is never done

- Add a new property iframe.xframe.inline=regex where if the regex matches, the content is always inlined and the x-frame-options check is never done

- Force popup if the server is https and the content is not https

- Change the Home variant of the tool to display the site title or site description inline without an iframe.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@128908 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-23834

Custom Height Does not Work in iFrame (Web Content) Portlet

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@128099 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-23230

Use commons-httpclient to encode URIs

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@128098 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 2 more files in changeset.
SAK-23230

Switch to using the new kernel validateURL() method.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@127861 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23752

Fix relative urls and allow protocol-less urls. Also validate

the infourl and check that urls are valid before placing them

into an iframe tag.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@127735 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23734 make myworkspace.info.url internationalized Patch from daniel.merino@unavarra.es

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@126917 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23566 Add missing events tracking for view activity - fixed web event

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@124848 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23566 fixed the event to match the existing one

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@123519 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-23566 Add missing events tracking for view activity - web.read

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@123514 66ffb92e-73f9-0310-93c1-f5514f145a0a

SAK-21623

Apply necessary changes to the portlet version of the iframe tool

to validate the URL entered into the dialog box during configuration.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@120169 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-21624

Remove all the onload code. It really gives inconsitent indications

across browsers when they get a page with X-Frame-Options. Sometimes

it does not fire the onload if it suppressed the page. Other browsers

puts in about:blank, and fires onload. So...

The thing that seems most reliable is to wait 8 seconds, check the

frame's location and if it is not readble, figure things are OK.

If it is readible it is a bad sign unless the iframe url is from the

current host (i.e. the window.location is the same prefix as the

iframe.location) - then it is a good sign :)

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@120167 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.
SAK-21624

First cut at the Javascript in-browser checking.

Rename the cachetimer for the in-server check to be

iframe.xframe.cachetime=7200000

Add new parameter here;

iframe.xframe.loadtime=4000

The amount of time the browser will wait before checking to see if the frame

load has at least started.

I think the JS needs a bit of tweaking still.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@120166 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 2 more files in changeset.
SAK-21624

Commit of a partial solution. This adds server side code that does

a HEAD request to the URL if popup is not selected. If the URL returns

an X-Frame-Options header, the tool switches to popup automatically.

This is controlled by a property:

iframe.xframe.timeout=7200000

This sets the number of milliseconds between checks for a

particular placement. The default is to check every two hours.

This can be disabled by

iframe.xframe.timeout=-1

This *works* quite nicely for any site that actually yields its

X-Frame-Options when a server sends a GET/HEAD. But some servers

(Facebook in particular) do not send back an X-Frame-Options

header when Java connects to it.

So this works nicely with http://www.google.com/ and still silently

fails for http://www.facebook.com.

This will need to be augmented with some JavaScript code as

described by Matt to catch those sites that only return X-Frame-Options

when they think they are talking to a browser.

But this is pretty slick for sites like Google that give us the

header in a server-to-server call.

git-svn-id: https://source.sakaiproject.org/svn/web/trunk@120164 66ffb92e-73f9-0310-93c1-f5514f145a0a