Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-43744 handle a mediaType of image from a ContentItem POST back to Sakai (#8266)

SAK-43578: Wrong translations: Insert Content Item (#8240)

(cherry picked from commit 1e136031b23e2fc3f636ed968b263a00f2e79978)

  1. … 1 more file in changeset.
SAK-43578: Wrong translations: Insert Content Item (#8240)

  1. … 1 more file in changeset.
SAK-42376 - Content Picker accessibility - cannot tab into app store (#7285)

* SAK-42376 - Lessons accessibility - cannot tab into app store

* SAK-42376 - Adding tabindex to iframe for lessons lti to tab into appstore

  1. … 1 more file in changeset.
SAK-42376 - Content Picker accessibility - cannot tab into app store (#7285)

* SAK-42376 - Lessons accessibility - cannot tab into app store

* SAK-42376 - Adding tabindex to iframe for lessons lti to tab into appstore

(cherry picked from commit b2a1176ab9e208e49db3e2ea9b8820c240b1d5e2)

  1. … 1 more file in changeset.
SAK-42226 - Go through and make sure iframe embedding works in the RCE (#7187)

  1. … 5 more files in changeset.
SAK-42226 - Go through and make sure iframe embedding works in the RCE (#7187)

(cherry picked from commit 56116afb71f19159ced492ca4b8a8b0a4672bea7)

  1. … 5 more files in changeset.
SAK-41442 - Fix ContentItem insertion in Assignments (#6619)

This is the minimal fix for the problem, but the whole plugin should be

cleaned up. The problem was with multiple editor instances on the page

and some incidental shared state.

The init function registers the ContentItemDialog with the top level

CKEDITOR object for each editor instance. What was happening in this

particular case was that the dialog was overwritten with the binding to

the second instance, for peer assessment, which is hidden. The editor

reference in the onOk callback was not for the actual editor that

invoked the dialog, but the last one initialized.

The error thrown was for the first selection range (range.checkReadOnly)

from insertHtml/insert in editable.js in CKEditor. With the second

editor hidden, the selection range array is empty, so the first item was

undefined. The shared/overwritten reference would have been more obvious

if the second editor was visible -- the item would have been inserted in

the wrong text area.

A more thorough fix would examine the init vs. onLoad details and make

sure that addIframe is called the appropriate number of times and that

only initialization that must run for each editor instance does. I

believe that would be the addCommand and addButton pieces. The

ContentItemIFrameWindow is also global. It is incidentally safe to use

because only one dialog can be in process at a time, but this should

reside within the instance of the dialog itself.

(cherry picked from commit 5ed6eaed47a11c6a72d94ab64c416b6b43df87c1)

SAK-41442 - Fix ContentItem insertion in Assignments (#6619)

This is the minimal fix for the problem, but the whole plugin should be

cleaned up. The problem was with multiple editor instances on the page

and some incidental shared state.

The init function registers the ContentItemDialog with the top level

CKEDITOR object for each editor instance. What was happening in this

particular case was that the dialog was overwritten with the binding to

the second instance, for peer assessment, which is hidden. The editor

reference in the onOk callback was not for the actual editor that

invoked the dialog, but the last one initialized.

The error thrown was for the first selection range (range.checkReadOnly)

from insertHtml/insert in editable.js in CKEditor. With the second

editor hidden, the selection range array is empty, so the first item was

undefined. The shared/overwritten reference would have been more obvious

if the second editor was visible -- the item would have been inserted in

the wrong text area.

A more thorough fix would examine the init vs. onLoad details and make

sure that addIframe is called the appropriate number of times and that

only initialization that must run for each editor instance does. I

believe that would be the addCommand and addButton pieces. The

ContentItemIFrameWindow is also global. It is incidentally safe to use

because only one dialog can be in process at a time, but this should

reside within the instance of the dialog itself.

(cherry picked from commit 5ed6eaed47a11c6a72d94ab64c416b6b43df87c1)

SAK-41442 - Fix ContentItem insertion in Assignments (#6619)

This is the minimal fix for the problem, but the whole plugin should be

cleaned up. The problem was with multiple editor instances on the page

and some incidental shared state.

The init function registers the ContentItemDialog with the top level

CKEDITOR object for each editor instance. What was happening in this

particular case was that the dialog was overwritten with the binding to

the second instance, for peer assessment, which is hidden. The editor

reference in the onOk callback was not for the actual editor that

invoked the dialog, but the last one initialized.

The error thrown was for the first selection range (range.checkReadOnly)

from insertHtml/insert in editable.js in CKEditor. With the second

editor hidden, the selection range array is empty, so the first item was

undefined. The shared/overwritten reference would have been more obvious

if the second editor was visible -- the item would have been inserted in

the wrong text area.

A more thorough fix would examine the init vs. onLoad details and make

sure that addIframe is called the appropriate number of times and that

only initialization that must run for each editor instance does. I

believe that would be the addCommand and addButton pieces. The

ContentItemIFrameWindow is also global. It is incidentally safe to use

because only one dialog can be in process at a time, but this should

reside within the instance of the dialog itself.

SAK-41442 - Fix ContentItem insertion in Assignments

This is the minimal fix for the problem, but the whole plugin should be

cleaned up. The problem was with multiple editor instances on the page

and some incidental shared state.

The init function registers the ContentItemDialog with the top level

CKEDITOR object for each editor instance. What was happening in this

particular case was that the dialog was overwritten with the binding to

the second instance, for peer assessment, which is hidden. The editor

reference in the onOk callback was not for the actual editor that

invoked the dialog, but the last one initialized.

The error thrown was for the first selection range (range.checkReadOnly)

from insertHtml/insert in editable.js in CKEditor. With the second

editor hidden, the selection range array is empty, so the first item was

undefined. The shared/overwritten reference would have been more obvious

if the second editor was visible -- the item would have been inserted in

the wrong text area.

A more thorough fix would examine the init vs. onLoad details and make

sure that addIframe is called the appropriate number of times and that

only initialization that must run for each editor instance does. I

believe that would be the addCommand and addButton pieces. The

ContentItemIFrameWindow is also global. It is incidentally safe to use

because only one dialog can be in process at a time, but this should

reside within the instance of the dialog itself.

SAK-40030 - Support iframe return (#5694)

  1. … 1 more file in changeset.
SAK-32656 - Initial commit of ContentItem in editor (#4574)

* SAK-32656 - Initial commit of ContentItem in editor

* SAK-32656 Add test plan, update message text.

    • binary
    ./images/contentitem.png
  1. … 21 more files in changeset.