Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
KNL-1554 Refactor of time service to aid deprecation (#4895)

* KNL-1554 Refactor of time service to aid deprecation

This splits out a new API called UserTimeService which is just responsible for getting the user’s timezone at the moment. This allows the main TimeService to be deprecated and any place that uses TimeService to just get the user’s timezone can switch to using UserTimeService.

This also makes the current TimeService more testable as it doesn’t actually need the whole kernel to be running, just mock instances of 2 helpers that can be easily mocked with Mockito (or similar).

This also makes the classes more focused (Single Responsibility Principal).

* Fix space

* Code formatting cleanup (brackets).

    • -0
    • +32
    ./time-components.xml
  1. … 10 more files in changeset.
KNL-1554 Refactor of time service to aid deprecation (#4895)

* KNL-1554 Refactor of time service to aid deprecation

This splits out a new API called UserTimeService which is just responsible for getting the user’s timezone at the moment. This allows the main TimeService to be deprecated and any place that uses TimeService to just get the user’s timezone can switch to using UserTimeService.

This also makes the current TimeService more testable as it doesn’t actually need the whole kernel to be running, just mock instances of 2 helpers that can be easily mocked with Mockito (or similar).

This also makes the classes more focused (Single Responsibility Principal).

* Fix space

* Code formatting cleanup (brackets).

    • -0
    • +32
    ./time-components.xml
  1. … 10 more files in changeset.