Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-46192 - Refactor Assignments / LTI External Tools For Sakai 21/22 (#9769)

The LTI support for Sakai 21 - worked, but there are a number of places where the Assignments shows information in the UI or is missing information in the UI that makes it hard to use. The basic problem was that all of the handling of scores in Sakai for LTI tools was handled by the Gradebook.  This made much of the Assignments workflow in Sakai pointless or badly broken for LTI Assignments.

The big picture of this change is that for LTI tools placed in Assignments, the grade flow is to/from the Assignments service no longer the grade book service but instead the assignment service and assignments sends grades to the gradebook using its internal logic.  With that change, there are current and emergent LTI grade flow features like activityStatus, gradingStatus, and the submission review launch that Sakai can now support with this change.

This is a dramatic improvement of the LTI integration into Assignments but the good news is that there are no data model changes and this should back port to Sakai 21 nicely.

  1. … 41 more files in changeset.
SAK-44772 - Initial commit of the "Tool Link Redirect" feature (#8896)

* SAK-44772 - Initial commit of the "Tool Link Redirect" feature

* SAK-44772 - Rename to "Transfer" per Shawn

* SAK-44772 - Add moar documentation

* SAK-44772 - Fix accessibility note

* SAK-44772 - Use list for accessibility per Andrea

(cherry picked from commit c86c28e7a622fff5d72e09bdf99ab30ee89ab8a0)

  1. … 8 more files in changeset.
SAK-44772 - Initial commit of the "Tool Link Redirect" feature (#8896)

* SAK-44772 - Initial commit of the "Tool Link Redirect" feature

* SAK-44772 - Rename to "Transfer" per Shawn

* SAK-44772 - Add moar documentation

* SAK-44772 - Fix accessibility note

* SAK-44772 - Use list for accessibility per Andrea

  1. … 8 more files in changeset.
SAK-44637 - Add Lessons Placement Checkbox (#8818)

(cherry picked from commit 48ada2d42dcd58d0207494b483b82889586f3b07)

  1. … 2 more files in changeset.
SAK-44637 - Add Lessons Placement Checkbox (#8818)

  1. … 2 more files in changeset.
SAK-44608 - Insure placementsecret set on all code paths (#8774)

SAK-44608 - Insure placementsecret set on all code paths (#8774)

(cherry picked from commit be959bb64d41930fac4088d7a7030cca19fedfbd)

SAK-44342 Apply best practice when using ResourceLoader (#8611)

(cherry picked from commit 66e7b3d7d439ac6026e08fb6a7adc8f5a1974d74)

Conflicts:

calendar/calendar-impl/impl/src/java/org/sakaiproject/calendar/impl/GenericCalendarImporter.java

commons/impl/src/java/org/sakaiproject/commons/impl/CommonsContentProducer.java

commons/tool/src/java/org/sakaiproject/commons/tool/CommonsTool.java

msgcntr/messageforums-component-impl/src/java/org/sakaiproject/component/app/messageforums/ui/PrivateMessageManagerImpl.java

msgcntr/messageforums-component-impl/src/webapp/WEB-INF/components.xml

portal/portal-impl/impl/src/java/org/sakaiproject/portal/entityprovider/PortalEntityProvider.java

roster2/tool/src/java/org/sakaiproject/roster/tool/entityprovider/RosterPOIEntityProvider.java

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/AssessmentSettingsBean.java

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/ItemConfigBean.java

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/bean/author/PublishedAssessmentSettingsBean.java

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/evaluation/HistogramListener.java

  1. … 74 more files in changeset.
SAK-44342 Apply best practice when using ResourceLoader (#8611)

(cherry picked from commit 66e7b3d7d439ac6026e08fb6a7adc8f5a1974d74)

Conflicts:

msgcntr/messageforums-component-impl/src/java/org/sakaiproject/component/app/messageforums/ui/PrivateMessageManagerImpl.java

msgcntr/messageforums-component-impl/src/webapp/WEB-INF/components.xml

samigo/samigo-app/src/java/org/sakaiproject/tool/assessment/ui/listener/delivery/DeliveryActionListener.java

  1. … 75 more files in changeset.
SAK-44342 Apply best practice when using ResourceLoader (#8611)

  1. … 76 more files in changeset.
SAK-44342 Apply best practice when using ResourceLoader (#8611)

(cherry picked from commit 66e7b3d7d439ac6026e08fb6a7adc8f5a1974d74)

  1. … 76 more files in changeset.
SAK-32679 - Refactor / Cleanup / Prepare for Assignments LTI (#8408)

* SAK-32679 - Adding an LTI Assignment type

* SAK-32679 - Very minimal MVP

* SAK-32679 - Add the launch protect field and feature

* SAK-32679 - Clean up UI, suport iframe and new window and resize

* SAK-32679 - Missed a file

* SAK-32679 - Handle the handoff from assignments to LTI

This makes sure that LTI links coming from assignments can't be

launched from elsewhere. It also handles a pretty dynamic set of

situations which would lead to double launching (new window scenario)

that would trigger 403s - instead we force a re-unlock through a

refresh of the "open in a new window" page.

* SAK-32679 - Accesslint fix and typo

* SAK-32679 - MVP of the tool selector

Todo

- Restore draft title and id on post errors

- Restore old title and id on edit

- Test test test - including all the content item stuff

* SAK-32679 - Tool title throughout and instructor launch

* SAK-32679 - Fix some of the broken flows

* SAK-32679 - Catch up with master changes

* SAK-32679 - Rename a few things and document

* SAK-32679 - Fix small bug, re-enable data model changes

* SAK-32679 - Document / cleanup - support subission and available

* SAK-32679 - Remove assignments mods and LTI data changes

This should now backport to -19 and -20

(cherry picked from commit 4e4453b54f64c94f8bd5894642e9118a5104df0f)

  1. … 15 more files in changeset.
SAK-32679 - Refactor / Cleanup / Prepare for Assignments LTI (#8408)

* SAK-32679 - Adding an LTI Assignment type

* SAK-32679 - Very minimal MVP

* SAK-32679 - Add the launch protect field and feature

* SAK-32679 - Clean up UI, suport iframe and new window and resize

* SAK-32679 - Missed a file

* SAK-32679 - Handle the handoff from assignments to LTI

This makes sure that LTI links coming from assignments can't be

launched from elsewhere. It also handles a pretty dynamic set of

situations which would lead to double launching (new window scenario)

that would trigger 403s - instead we force a re-unlock through a

refresh of the "open in a new window" page.

* SAK-32679 - Accesslint fix and typo

* SAK-32679 - MVP of the tool selector

Todo

- Restore draft title and id on post errors

- Restore old title and id on edit

- Test test test - including all the content item stuff

* SAK-32679 - Tool title throughout and instructor launch

* SAK-32679 - Fix some of the broken flows

* SAK-32679 - Catch up with master changes

* SAK-32679 - Rename a few things and document

* SAK-32679 - Fix small bug, re-enable data model changes

* SAK-32679 - Document / cleanup - support subission and available

* SAK-32679 - Remove assignments mods and LTI data changes

This should now backport to -19 and -20

  1. … 15 more files in changeset.
SAK-40044 - Pass description and name to LTI for launch (#8382)

* SAK-40044 - Pass description and name to LTI for launch

Note that the case of DBLTIService.java was wrong (it was Db)

* SAK-40044 - Fix some Codacy Issues

* SAK-40044 - Moar Codacy

(cherry picked from commit 1e7180c0abc38d965b8c2bd4751284fefafdad8f)

Conflicts:

basiclti/basiclti-common/src/java/org/sakaiproject/basiclti/util/SakaiBLTIUtil.java

  1. … 9 more files in changeset.
SAK-40044 - Pass description and name to LTI for launch (#8382)

* SAK-40044 - Pass description and name to LTI for launch

Note that the case of DBLTIService.java was wrong (it was Db)

* SAK-40044 - Fix some Codacy Issues

* SAK-40044 - Moar Codacy

  1. … 9 more files in changeset.
NOJIRA Checking licenses (#8176)

    • -0
    • +15
    ./impl/SampleLTISubstitutionsFilter.java
  1. … 137 more files in changeset.
SAK-41789 - Remove LTI 2.0 (#7161)

* MVP Without LTI 2.0

* Fixes elsewhere in the code

* Update with changes from Andrea and Shawn

* A few little touch ups

* iMake sure there is no space at the end of hte redirect url

* Add some QA / Documentation about the IMS Reference Implementation

* Better test documents for LTI Advantage

* Add some links to the sample images.

* Remove some unused code.

(cherry picked from commit 08db4a0dddac0176f30d86316f027edb321cba04)

Conflicts:

lessonbuilder/tool/src/java/org/sakaiproject/lessonbuildertool/tool/beans/SimplePageBean.java

  1. … 86 more files in changeset.
SAK-41789 - Remove LTI 2.0 (#7161)

* MVP Without LTI 2.0

* Fixes elsewhere in the code

* Update with changes from Andrea and Shawn

* A few little touch ups

* iMake sure there is no space at the end of hte redirect url

* Add some QA / Documentation about the IMS Reference Implementation

* Better test documents for LTI Advantage

* Add some links to the sample images.

* Remove some unused code.

  1. … 86 more files in changeset.
SAK-42023 BasicLTI: commons-configuration=> commons-configuration2 (#7062)

  1. … 2 more files in changeset.
SAK-42023 BasicLTI: commons-configuration=> commons-configuration2 (#7062)

(cherry picked from commit 85534e39a7c06e938a8a85b41ed6f10f00af7541)

  1. … 2 more files in changeset.
SAK-41466 BaseLTI commons-lang => commons-lang3 (#6626)

delete maven.xml: basiclti-util basiclti-common

  1. … 13 more files in changeset.
SAK-41466 BaseLTI commons-lang => commons-lang3 (#6626)

delete maven.xml: basiclti-util basiclti-common

(cherry picked from commit 6809cef1ff43aae140ac0bc0074f5768ae8bbbc5)

Conflicts:

basiclti/basiclti-tool/pom.xml

basiclti/basiclti-tool/src/java/org/sakaiproject/blti/tool/LTIAdminTool.java

  1. … 12 more files in changeset.
SAK-40487 revert SAK-32360 from 11.x (#5898)

* Revert "SAK-32360 11.x merge fixes (#5879)"

This reverts commit fe36ba272f05df24ec30f44927e52df0f5f4b108.

* Revert "SAK-32665 & SAK-32360 11x Backport"

This reverts commit 6d62f920033679143ed1653d9ab6b2c25bf5c69f.

  1. … 9 more files in changeset.
SAK-32665 & SAK-32360 11x Backport

  1. … 7 more files in changeset.
SAK-39930: BasicLTI > extend 'Allow'/'Do not allow' configuration options to the custom tool icon setting (#5544)

  1. … 8 more files in changeset.
SAK-31796 - Clean up instances of e.printStackTrace in the rest of Sakai (#5113)

* Search - Clean up instances of e.printStackTrace

* Sections - Clean up instances of printStackTrace

* Shortened - Clean up instances of e.printStackTrace

* SimpleRSS - Clean up instances of e.printStackTrace

* Site - Clean up instances of e.printStackTrace

* sitedescription - Clean up instances of e.printStackTrace

* Taggable - Clean up instances of e.printStackTrace

* Signup - Clean up instances of e.printStackTrace

* Sitemanage - Clean up instances of e.printStackTrace

* Access - Clean up instances of e.printStackTrace

* Admin-tools - Clean up instances of e.printStackTrace

* Announcement - Clean up instances of e.printStackTrace

* Archive - Clean up instances of e.printStackTrace

* Assignment - Clean up instances of e.printStackTrace

* Basiclti - Clean up instances of e.printStackTrace

* Calendar - Clean up instances of e.printStackTrace

* Chat - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Cloud-content - Clean up instances of e.printStackTrace

* Cmprovider - Clean up instances of e.printStackTrace

* Common - Clean up instances of e.printStackTrace

* Sitestats - Clean up instances of e.printStackTrace

* Commons - Clean up instances of e.printStackTrace

* Content - Clean up instances of e.printStackTrace

* Courier - Clean up instances of e.printStackTrace

* Dav - Clean up instances of e.printStackTrace

* Delegatedaccess - Clean up instances of e.printStackTrace

* Edu-services - Clean up instances of e.printStackTrace

* Content-review - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Emailtemplateservice - Clean up instances of e.printStackTrace

* Endorsed - Clean up instances of e.printStackTrace

* Entitybroker - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* Feedback - Clean up instances of e.printStackTrace

* Syllabus - Clean up instances of e.printStackTrace

* Tags - Clean up instances of e.printStackTrace

* Gradebook - Clean up instances of printStackTrace

* Textarea - Clean up printStackTrace

* Tool - Clean up printStackTrace

* Gradebookng - Clean up instances of e.printStackTrace

* Help - Clean up instances of e.printStackTrace

* Hierarchy - Clean up instances of e.printStackTrace

* Jobsscheduler - Clean up instances of e.printStackTrace

* Jsf - Clean up instances of e.printStackTrace

* User - Clean up instances of printStackTrace

* useraudit - Clean up instances of printStack

* usermembership - Clean up instances of printStackTrace

* Velocity - Clean up instances of printStackTrace

* Web - Clean up instances of printStackTrace

* Webservices - Clean up instances of printStackTrace

* Rwiki - Clean up instances of printStackTrace

* rubrics - Clean up instances of printStackTrace

* rsf - Clean up instances of printStackTrace

* roster2 - Clean up instances of printStackTrace

* reset-pass - Clean up instances of printStackTrace

* providers - Clean up instances of printStackTrace

* Profile2 - Clean up instances of printStackTrace

* Kernel - Clean up instances of printStackTrace

* Presence - Clean up instances of printStackTrace

* Postem - Clean up instances of printStackTrace

* Portal - Clean up instances of printStackTrace

* polls - Clean up instances of printStackTrace

* Podcasts - Clean up instances of printStackTrace

* Pasystem - Clean up instances of printStackTrace

* oauth - Clean up instances of printStackTrace

* Lessonbuilder - Clean up instances of printStackTrace

* Login - Clean up instances of printStackTrace

* Mailarchive - Clean up instances of printStackTrace

* Mailsender - Clean up instances of printStackTrace

* Message - Clean up instances of printStackTrace

* MSGCNTR - Clean up instances of printStackTrace

* Extra cases - Clean up instances of printStackTrace

* Extra cases - Clean up instances of System.out.println

* Extra cases - Use Slf4j Annotation

(cherry picked from commit 1dc2b84ba355b8be8a1262fd2572b1a3bfd3900c)

    • -5
    • +3
    ./impl/SiteEmailPreferenceSetterImpl.java
    • -12
    • +8
    ./impl/SiteMembershipUpdaterImpl.java
    • -46
    • +41
    ./impl/SiteMembershipsSynchroniserImpl.java
    • -12
    • +10
    ./impl/UserFinderOrCreatorImpl.java
    • -10
    • +8
    ./impl/jobs/SiteMembershipsSyncJob.java
  1. … 1299 more files in changeset.
SAK-31796 - Clean up instances of e.printStackTrace in the rest of Sakai (#5113)

* Search - Clean up instances of e.printStackTrace

* Sections - Clean up instances of printStackTrace

* Shortened - Clean up instances of e.printStackTrace

* SimpleRSS - Clean up instances of e.printStackTrace

* Site - Clean up instances of e.printStackTrace

* sitedescription - Clean up instances of e.printStackTrace

* Taggable - Clean up instances of e.printStackTrace

* Signup - Clean up instances of e.printStackTrace

* Sitemanage - Clean up instances of e.printStackTrace

* Access - Clean up instances of e.printStackTrace

* Admin-tools - Clean up instances of e.printStackTrace

* Announcement - Clean up instances of e.printStackTrace

* Archive - Clean up instances of e.printStackTrace

* Assignment - Clean up instances of e.printStackTrace

* Basiclti - Clean up instances of e.printStackTrace

* Calendar - Clean up instances of e.printStackTrace

* Chat - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Cloud-content - Clean up instances of e.printStackTrace

* Cmprovider - Clean up instances of e.printStackTrace

* Common - Clean up instances of e.printStackTrace

* Sitestats - Clean up instances of e.printStackTrace

* Commons - Clean up instances of e.printStackTrace

* Content - Clean up instances of e.printStackTrace

* Courier - Clean up instances of e.printStackTrace

* Dav - Clean up instances of e.printStackTrace

* Delegatedaccess - Clean up instances of e.printStackTrace

* Edu-services - Clean up instances of e.printStackTrace

* Content-review - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Emailtemplateservice - Clean up instances of e.printStackTrace

* Endorsed - Clean up instances of e.printStackTrace

* Entitybroker - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* Feedback - Clean up instances of e.printStackTrace

* Syllabus - Clean up instances of e.printStackTrace

* Tags - Clean up instances of e.printStackTrace

* Gradebook - Clean up instances of printStackTrace

* Textarea - Clean up printStackTrace

* Tool - Clean up printStackTrace

* Gradebookng - Clean up instances of e.printStackTrace

* Help - Clean up instances of e.printStackTrace

* Hierarchy - Clean up instances of e.printStackTrace

* Jobsscheduler - Clean up instances of e.printStackTrace

* Jsf - Clean up instances of e.printStackTrace

* User - Clean up instances of printStackTrace

* useraudit - Clean up instances of printStack

* usermembership - Clean up instances of printStackTrace

* Velocity - Clean up instances of printStackTrace

* Web - Clean up instances of printStackTrace

* Webservices - Clean up instances of printStackTrace

* Rwiki - Clean up instances of printStackTrace

* rubrics - Clean up instances of printStackTrace

* rsf - Clean up instances of printStackTrace

* roster2 - Clean up instances of printStackTrace

* reset-pass - Clean up instances of printStackTrace

* providers - Clean up instances of printStackTrace

* Profile2 - Clean up instances of printStackTrace

* Kernel - Clean up instances of printStackTrace

* Presence - Clean up instances of printStackTrace

* Postem - Clean up instances of printStackTrace

* Portal - Clean up instances of printStackTrace

* polls - Clean up instances of printStackTrace

* Podcasts - Clean up instances of printStackTrace

* Pasystem - Clean up instances of printStackTrace

* oauth - Clean up instances of printStackTrace

* Lessonbuilder - Clean up instances of printStackTrace

* Login - Clean up instances of printStackTrace

* Mailarchive - Clean up instances of printStackTrace

* Mailsender - Clean up instances of printStackTrace

* Message - Clean up instances of printStackTrace

* MSGCNTR - Clean up instances of printStackTrace

* Extra cases - Clean up instances of printStackTrace

* Extra cases - Clean up instances of System.out.println

* Extra cases - Use Slf4j Annotation

    • -5
    • +3
    ./impl/SiteEmailPreferenceSetterImpl.java
    • -12
    • +8
    ./impl/SiteMembershipUpdaterImpl.java
    • -46
    • +41
    ./impl/SiteMembershipsSynchroniserImpl.java
    • -12
    • +10
    ./impl/UserFinderOrCreatorImpl.java
    • -10
    • +8
    ./impl/jobs/SiteMembershipsSyncJob.java
  1. … 1299 more files in changeset.
SAK-33561 Support for filter custom properties. (#4960)

* SAK-33561 Support for filter custom properties.

This allows local deployments to customise the LTI substitution

properties that are used for custom property subsitution.

* SAK-33561 Added example substitution filter.

This substitution filter adds a random number to the substituted variables. You can then use this in your custom parameters with:

lucky=$random

This filter is only enabled when Sakai is started in demo mode (with the JVM flag of -Dsakai.demo=true).

* Added some more JavaDoc.

    • -0
    • +43
    ./impl/SampleLTISubstitutionsFilter.java
  1. … 4 more files in changeset.
SAK-33561 Support for filter custom properties. (#4960)

* SAK-33561 Support for filter custom properties.

This allows local deployments to customise the LTI substitution

properties that are used for custom property subsitution.

* SAK-33561 Added example substitution filter.

This substitution filter adds a random number to the substituted variables. You can then use this in your custom parameters with:

lucky=$random

This filter is only enabled when Sakai is started in demo mode (with the JVM flag of -Dsakai.demo=true).

* Added some more JavaDoc.

(cherry picked from commit d25e3d18ebc4b1c06a10ad2b1d6debdeb94860dd)

    • -0
    • +43
    ./impl/SampleLTISubstitutionsFilter.java
  1. … 4 more files in changeset.
SAK-33418 Switch to use standard loggers. (#4851)

Using ex.printStackTrace() can result in logs ending up in a different place from the rest of the logging setup.

(cherry picked from commit 976d7cb0b9145eaec17d0e771efeca9d1835b2b9)

    • -2
    • +2
    ./impl/SiteMembershipsSynchroniserImpl.java
  1. … 1 more file in changeset.