Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-45491 LTI Advantage Key Rotation (#9586)

  1. … 8 more files in changeset.
SAK-44886 - Cleanup and document role mapping (#8964)

* SAK-44886 - Cleanup and document role mapping

* SAK-44886 - Review related fixes

* SAK-44886 - Use a Set

  1. … 9 more files in changeset.
SAK-44810 - ResouceLink.id.history subsitution variable (#8938)

* SAK-44810 - ResouceLink.id.history subsitution variable

* SAK-44810 - allowsettings -> allowsettings_ext

* SAK-44810 - Separate CONTEXT_ID_HISTORY ito separate JIRA

(cherry picked from commit 8c48bcdee39cb3fc519a502fd0929437859e9cc9)

Conflicts:

basiclti/basiclti-common/src/java/org/sakaiproject/basiclti/util/SakaiBLTIUtil.java

basiclti/basiclti-common/src/test/org/sakaiproject/basiclti/util/SakaiBLTIUtilTest.java

basiclti/basiclti-impl/src/bundle/ltiservice_ar.properties

basiclti/basiclti-impl/src/bundle/ltiservice_de_DE.properties

basiclti/basiclti-impl/src/bundle/ltiservice_fr_FR.properties

  1. … 18 more files in changeset.
SAK-44810 - ResouceLink.id.history subsitution variable (#8938)

* SAK-44810 - ResouceLink.id.history subsitution variable

* SAK-44810 - allowsettings -> allowsettings_ext

* SAK-44810 - Separate CONTEXT_ID_HISTORY ito separate JIRA

(cherry picked from commit 8c48bcdee39cb3fc519a502fd0929437859e9cc9)

  1. … 20 more files in changeset.
SAK-44810 - ResouceLink.id.history subsitution variable (#8938)

* SAK-44810 - ResouceLink.id.history subsitution variable

* SAK-44810 - allowsettings -> allowsettings_ext

* SAK-44810 - Separate CONTEXT_ID_HISTORY ito separate JIRA

  1. … 20 more files in changeset.
SAK-44055 - MVP of IMS Auto Provisioning Code (#8860)

* SAK-44055 - MVP of IMS Auto Provisioning Code

* SAK-44055 - Make short cut for new tools

* SAK-44055 - deployment_id and accesslint

* SAK-44055 - Process the claims

* SAK-44055 - Add tokenTimeStamps and refactor a bit

* SAK-44055 - Use LTI13Util signature checking

* SAK-44055 - Make the registration token real

* SAK-44055 - Better naming and clean up losing keys

* SAK-44055 - Add some documentation

* SAK-44055 - Encrypt secrets - improve doc

* SAK-44055 - Support email claim and scope

* SAK-44055 - Clean up the expiration code - thanks Claude

* SAK-44055 - Change message parsing order

* SAK-44055 - Remove old auto-config from 44097

* SAK-44055 - Update Documentation

* SAK-44055 - Merge Cleanup

* SAK-44055 - Clean up codacy

(cherry picked from commit 3d669c821782f9689c67762136ec23d83da9da00)

  1. … 24 more files in changeset.
SAK-44055 - MVP of IMS Auto Provisioning Code (#8860)

* SAK-44055 - MVP of IMS Auto Provisioning Code

* SAK-44055 - Make short cut for new tools

* SAK-44055 - deployment_id and accesslint

* SAK-44055 - Process the claims

* SAK-44055 - Add tokenTimeStamps and refactor a bit

* SAK-44055 - Use LTI13Util signature checking

* SAK-44055 - Make the registration token real

* SAK-44055 - Better naming and clean up losing keys

* SAK-44055 - Add some documentation

* SAK-44055 - Encrypt secrets - improve doc

* SAK-44055 - Support email claim and scope

* SAK-44055 - Clean up the expiration code - thanks Claude

* SAK-44055 - Change message parsing order

* SAK-44055 - Remove old auto-config from 44097

* SAK-44055 - Update Documentation

* SAK-44055 - Merge Cleanup

* SAK-44055 - Clean up codacy

  1. … 24 more files in changeset.
SAK-44763 - Improve URL matching on CC import (#8884)

* SAK-44763 - Improve URL matching on CC import

* SAK-44763 - Change priority to all local first, unit test

* SAK-44763 - Use URIBuilder to remove the query

Per Matt Jones.

* SAK-44763 - Remove System.out.println per Earle

  1. … 3 more files in changeset.
SAK-44763 - Improve URL matching on CC import (#8884)

* SAK-44763 - Improve URL matching on CC import

* SAK-44763 - Change priority to all local first, unit test

* SAK-44763 - Use URIBuilder to remove the query

Per Matt Jones.

* SAK-44763 - Remove System.out.println per Earle

(cherry picked from commit f18f3995170d382d6eb4d633be7c3cfc3894d1eb)

  1. … 3 more files in changeset.
SAK-44283 - Accept float and double for scoreGiven (#8563)

* SAK-44283 - Accept float and double for scoreGiven

* SAK-44283 - Make the tests more robust for null

(cherry picked from commit 81fa9e9688bb9e93f76f7146d1f26b7b2c10e521)

  1. … 1 more file in changeset.
SAK-44283 - Accept float and double for scoreGiven (#8563)

* SAK-44283 - Accept float and double for scoreGiven

* SAK-44283 - Make the tests more robust for null

  1. … 1 more file in changeset.
SAK-44283 - Accept float and double for scoreGiven (#8563)

* SAK-44283 - Accept float and double for scoreGiven

* SAK-44283 - Make the tests more robust for null

(cherry picked from commit 81fa9e9688bb9e93f76f7146d1f26b7b2c10e521)

  1. … 1 more file in changeset.
SAK-32679 - Refactor / Cleanup / Prepare for Assignments LTI (#8408)

* SAK-32679 - Adding an LTI Assignment type

* SAK-32679 - Very minimal MVP

* SAK-32679 - Add the launch protect field and feature

* SAK-32679 - Clean up UI, suport iframe and new window and resize

* SAK-32679 - Missed a file

* SAK-32679 - Handle the handoff from assignments to LTI

This makes sure that LTI links coming from assignments can't be

launched from elsewhere. It also handles a pretty dynamic set of

situations which would lead to double launching (new window scenario)

that would trigger 403s - instead we force a re-unlock through a

refresh of the "open in a new window" page.

* SAK-32679 - Accesslint fix and typo

* SAK-32679 - MVP of the tool selector

Todo

- Restore draft title and id on post errors

- Restore old title and id on edit

- Test test test - including all the content item stuff

* SAK-32679 - Tool title throughout and instructor launch

* SAK-32679 - Fix some of the broken flows

* SAK-32679 - Catch up with master changes

* SAK-32679 - Rename a few things and document

* SAK-32679 - Fix small bug, re-enable data model changes

* SAK-32679 - Document / cleanup - support subission and available

* SAK-32679 - Remove assignments mods and LTI data changes

This should now backport to -19 and -20

(cherry picked from commit 4e4453b54f64c94f8bd5894642e9118a5104df0f)

  1. … 15 more files in changeset.
SAK-32679 - Refactor / Cleanup / Prepare for Assignments LTI (#8408)

* SAK-32679 - Adding an LTI Assignment type

* SAK-32679 - Very minimal MVP

* SAK-32679 - Add the launch protect field and feature

* SAK-32679 - Clean up UI, suport iframe and new window and resize

* SAK-32679 - Missed a file

* SAK-32679 - Handle the handoff from assignments to LTI

This makes sure that LTI links coming from assignments can't be

launched from elsewhere. It also handles a pretty dynamic set of

situations which would lead to double launching (new window scenario)

that would trigger 403s - instead we force a re-unlock through a

refresh of the "open in a new window" page.

* SAK-32679 - Accesslint fix and typo

* SAK-32679 - MVP of the tool selector

Todo

- Restore draft title and id on post errors

- Restore old title and id on edit

- Test test test - including all the content item stuff

* SAK-32679 - Tool title throughout and instructor launch

* SAK-32679 - Fix some of the broken flows

* SAK-32679 - Catch up with master changes

* SAK-32679 - Rename a few things and document

* SAK-32679 - Fix small bug, re-enable data model changes

* SAK-32679 - Document / cleanup - support subission and available

* SAK-32679 - Remove assignments mods and LTI data changes

This should now backport to -19 and -20

  1. … 15 more files in changeset.
SAK-32679 - Add the launch protect field and feature

  1. … 4 more files in changeset.
SAK-40954 - Encrypt the private keys whilst at rest (#6263)

(cherry picked from commit 2996cbccfaf891b3da20adb167233100dfe08cfe)

  1. … 3 more files in changeset.
SAK-40954 - Encrypt the private keys whilst at rest (#6263)

  1. … 3 more files in changeset.
SAK-31796 - Clean up instances of e.printStackTrace in the rest of Sakai (#5113)

* Search - Clean up instances of e.printStackTrace

* Sections - Clean up instances of printStackTrace

* Shortened - Clean up instances of e.printStackTrace

* SimpleRSS - Clean up instances of e.printStackTrace

* Site - Clean up instances of e.printStackTrace

* sitedescription - Clean up instances of e.printStackTrace

* Taggable - Clean up instances of e.printStackTrace

* Signup - Clean up instances of e.printStackTrace

* Sitemanage - Clean up instances of e.printStackTrace

* Access - Clean up instances of e.printStackTrace

* Admin-tools - Clean up instances of e.printStackTrace

* Announcement - Clean up instances of e.printStackTrace

* Archive - Clean up instances of e.printStackTrace

* Assignment - Clean up instances of e.printStackTrace

* Basiclti - Clean up instances of e.printStackTrace

* Calendar - Clean up instances of e.printStackTrace

* Chat - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Cloud-content - Clean up instances of e.printStackTrace

* Cmprovider - Clean up instances of e.printStackTrace

* Common - Clean up instances of e.printStackTrace

* Sitestats - Clean up instances of e.printStackTrace

* Commons - Clean up instances of e.printStackTrace

* Content - Clean up instances of e.printStackTrace

* Courier - Clean up instances of e.printStackTrace

* Dav - Clean up instances of e.printStackTrace

* Delegatedaccess - Clean up instances of e.printStackTrace

* Edu-services - Clean up instances of e.printStackTrace

* Content-review - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Emailtemplateservice - Clean up instances of e.printStackTrace

* Endorsed - Clean up instances of e.printStackTrace

* Entitybroker - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* Feedback - Clean up instances of e.printStackTrace

* Syllabus - Clean up instances of e.printStackTrace

* Tags - Clean up instances of e.printStackTrace

* Gradebook - Clean up instances of printStackTrace

* Textarea - Clean up printStackTrace

* Tool - Clean up printStackTrace

* Gradebookng - Clean up instances of e.printStackTrace

* Help - Clean up instances of e.printStackTrace

* Hierarchy - Clean up instances of e.printStackTrace

* Jobsscheduler - Clean up instances of e.printStackTrace

* Jsf - Clean up instances of e.printStackTrace

* User - Clean up instances of printStackTrace

* useraudit - Clean up instances of printStack

* usermembership - Clean up instances of printStackTrace

* Velocity - Clean up instances of printStackTrace

* Web - Clean up instances of printStackTrace

* Webservices - Clean up instances of printStackTrace

* Rwiki - Clean up instances of printStackTrace

* rubrics - Clean up instances of printStackTrace

* rsf - Clean up instances of printStackTrace

* roster2 - Clean up instances of printStackTrace

* reset-pass - Clean up instances of printStackTrace

* providers - Clean up instances of printStackTrace

* Profile2 - Clean up instances of printStackTrace

* Kernel - Clean up instances of printStackTrace

* Presence - Clean up instances of printStackTrace

* Postem - Clean up instances of printStackTrace

* Portal - Clean up instances of printStackTrace

* polls - Clean up instances of printStackTrace

* Podcasts - Clean up instances of printStackTrace

* Pasystem - Clean up instances of printStackTrace

* oauth - Clean up instances of printStackTrace

* Lessonbuilder - Clean up instances of printStackTrace

* Login - Clean up instances of printStackTrace

* Mailarchive - Clean up instances of printStackTrace

* Mailsender - Clean up instances of printStackTrace

* Message - Clean up instances of printStackTrace

* MSGCNTR - Clean up instances of printStackTrace

* Extra cases - Clean up instances of printStackTrace

* Extra cases - Clean up instances of System.out.println

* Extra cases - Use Slf4j Annotation

(cherry picked from commit 1dc2b84ba355b8be8a1262fd2572b1a3bfd3900c)

  1. … 1308 more files in changeset.
SAK-31796 - Clean up instances of e.printStackTrace in the rest of Sakai (#5113)

* Search - Clean up instances of e.printStackTrace

* Sections - Clean up instances of printStackTrace

* Shortened - Clean up instances of e.printStackTrace

* SimpleRSS - Clean up instances of e.printStackTrace

* Site - Clean up instances of e.printStackTrace

* sitedescription - Clean up instances of e.printStackTrace

* Taggable - Clean up instances of e.printStackTrace

* Signup - Clean up instances of e.printStackTrace

* Sitemanage - Clean up instances of e.printStackTrace

* Access - Clean up instances of e.printStackTrace

* Admin-tools - Clean up instances of e.printStackTrace

* Announcement - Clean up instances of e.printStackTrace

* Archive - Clean up instances of e.printStackTrace

* Assignment - Clean up instances of e.printStackTrace

* Basiclti - Clean up instances of e.printStackTrace

* Calendar - Clean up instances of e.printStackTrace

* Chat - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Cloud-content - Clean up instances of e.printStackTrace

* Cmprovider - Clean up instances of e.printStackTrace

* Common - Clean up instances of e.printStackTrace

* Sitestats - Clean up instances of e.printStackTrace

* Commons - Clean up instances of e.printStackTrace

* Content - Clean up instances of e.printStackTrace

* Courier - Clean up instances of e.printStackTrace

* Dav - Clean up instances of e.printStackTrace

* Delegatedaccess - Clean up instances of e.printStackTrace

* Edu-services - Clean up instances of e.printStackTrace

* Content-review - Clean up instances of e.printStackTrace

* Citations - Clean up instances of e.printStackTrace

* Emailtemplateservice - Clean up instances of e.printStackTrace

* Endorsed - Clean up instances of e.printStackTrace

* Entitybroker - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* External-calendaring-service - Clean up instances of e.printStackTrace

* Feedback - Clean up instances of e.printStackTrace

* Syllabus - Clean up instances of e.printStackTrace

* Tags - Clean up instances of e.printStackTrace

* Gradebook - Clean up instances of printStackTrace

* Textarea - Clean up printStackTrace

* Tool - Clean up printStackTrace

* Gradebookng - Clean up instances of e.printStackTrace

* Help - Clean up instances of e.printStackTrace

* Hierarchy - Clean up instances of e.printStackTrace

* Jobsscheduler - Clean up instances of e.printStackTrace

* Jsf - Clean up instances of e.printStackTrace

* User - Clean up instances of printStackTrace

* useraudit - Clean up instances of printStack

* usermembership - Clean up instances of printStackTrace

* Velocity - Clean up instances of printStackTrace

* Web - Clean up instances of printStackTrace

* Webservices - Clean up instances of printStackTrace

* Rwiki - Clean up instances of printStackTrace

* rubrics - Clean up instances of printStackTrace

* rsf - Clean up instances of printStackTrace

* roster2 - Clean up instances of printStackTrace

* reset-pass - Clean up instances of printStackTrace

* providers - Clean up instances of printStackTrace

* Profile2 - Clean up instances of printStackTrace

* Kernel - Clean up instances of printStackTrace

* Presence - Clean up instances of printStackTrace

* Postem - Clean up instances of printStackTrace

* Portal - Clean up instances of printStackTrace

* polls - Clean up instances of printStackTrace

* Podcasts - Clean up instances of printStackTrace

* Pasystem - Clean up instances of printStackTrace

* oauth - Clean up instances of printStackTrace

* Lessonbuilder - Clean up instances of printStackTrace

* Login - Clean up instances of printStackTrace

* Mailarchive - Clean up instances of printStackTrace

* Mailsender - Clean up instances of printStackTrace

* Message - Clean up instances of printStackTrace

* MSGCNTR - Clean up instances of printStackTrace

* Extra cases - Clean up instances of printStackTrace

* Extra cases - Clean up instances of System.out.println

* Extra cases - Use Slf4j Annotation

  1. … 1308 more files in changeset.
SAK-32675 - Update license plugin and license headers (#4720)

* SAK-32675 - Update license plugin and license headers

* SAK-32675 - Adding more license files

  1. … 1281 more files in changeset.
SAK-32356 - SAK-32356 - Some grades passed to LTI outcomes result in errors because of mathematical precision (#4124)

  1. … 2 more files in changeset.
SAK-32356 - SAK-32356 - Some grades passed to LTI outcomes result in errors because of mathematical precision (#4124)

  1. … 2 more files in changeset.
SAK-32190 Cope with encryption not always failing. (#3918)

Sometimes even with a bad key decryption will work, so we well as checking for an exception we also check that we didn’t get the original text back.

SAK-31364 - Restore legacy semicolon processing (#2843)

    • -0
    • +55
    ./util/SakaiBLTIUtilTest.java
  1. … 1 more file in changeset.
SAK-31364 - Restore legacy semicolon processing (#2843)

    • -0
    • +55
    ./util/SakaiBLTIUtilTest.java
  1. … 1 more file in changeset.
SAK-28125

Improve the Blowfish unit tests to provide more information so they can be

better used as examples.

git-svn-id: https://source.sakaiproject.org/svn/basiclti/trunk@316024 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 2 more files in changeset.
SAK-28125

Change the previous key lengthening algorithm to be a combined key

lengthening and key shortening algorithm and move from hex-only

keys to true raw keys to avoid implicitly shortening key length

by insisting on only printing characters in keys transported

over the net. Here is the new shortening/lengthening/decryption

algorithm in PHP using raw sha1:

$sha1Secret = hash('sha1',$actual_secret, true);

if ( strlen($sha1Secret) > 16 ) $sha1Secret = substr($sha1Secret,0,16);

$session = mcrypt_decrypt(MCRYPT_BLOWFISH, $sha1Secret,

$encrypted_session, MCRYPT_MODE_ECB);

We are still limiting the BlowFish key length to 128 (16 bytes)

since Java only ships with 128 by default.

Also cleanup / remove some redundant code between PortableShaUtil and

BlowFish classes as well as add a bit of error checking on the hex conversions

in PortableShaUtil. Unit tests updated as well.

git-svn-id: https://source.sakaiproject.org/svn/basiclti/trunk@315745 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 3 more files in changeset.
SAK-28125

Add a feature to send a BlowFish encrypted session to particularly well-trusted

LTI tools to allow them to ace "as user" when accessing Sakai URLs like "/direct"

The new field is "ext_sakai_encrypted_session"

git-svn-id: https://source.sakaiproject.org/svn/basiclti/trunk@315720 66ffb92e-73f9-0310-93c1-f5514f145a0a

    • -0
    • +81
    ./util/BlowFishTest.java
  1. … 3 more files in changeset.
SAK-28122

Solve the problem of ShaUtil not generating NIST-style (i.e. cross-platform)

Hex strings.

Rename org.sakaiproject.basiclti.util.ShaUtil to org.sakaiproject.basiclti.util.LegacyShaUtil

Introduce org.sakaiproject.basiclti.util.PortableShaUtil

Add/modify necessary unit tests

This has no dependencies outside of basiclti

git-svn-id: https://source.sakaiproject.org/svn/basiclti/trunk@315714 66ffb92e-73f9-0310-93c1-f5514f145a0a

    • -0
    • +95
    ./util/LegacyShaUtilTest.java
    • -0
    • +61
    ./util/PortableShaUtilTest.java
  1. … 8 more files in changeset.
BLTI-195

Add the type of CIPHER to the encrypted text to allow for evolution and

to be able to be more clear when the field is actually encrypted.

git-svn-id: https://source.sakaiproject.org/svn/basiclti/branches/BLTI-195@120420 66ffb92e-73f9-0310-93c1-f5514f145a0a

  1. … 1 more file in changeset.