Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-46441 Assignments : validation of model answer not happening (#9947)

SAK-46444 Assignments : show closed date error message (#9950)

* SAK-46444 Assignments : show closed date error message

View submission page wasn't displaying it either (submission.CloseDate

doesn't even exist). As the same information had to be used on 2 screens

and it was already being processed elsewhere, I refactored two methods

into one and added a tiny piece of logic.

(cherry picked from commit 11713e91fc4cf40efc44946dc2c5548017395c7d)

Conflicts:

assignment/tool/src/webapp/vm/assignment/chef_assignments_student_view_submission.vm

    • -2
    • +4
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
    • -8
    • +2
    ./vm/assignment/chef_assignments_student_view_submission.vm
  1. … 2 more files in changeset.
SAK-46444 Assignments : show closed date error message (#9950)

* SAK-46444 Assignments : show closed date error message

View submission page wasn't displaying it either (submission.CloseDate

doesn't even exist). As the same information had to be used on 2 screens

and it was already being processed elsewhere, I refactored two methods

into one and added a tiny piece of logic.

    • -2
    • +4
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
    • -8
    • +2
    ./vm/assignment/chef_assignments_student_view_submission.vm
  1. … 2 more files in changeset.
SAK-46453 Assignment remove @Transactional from AssignmentToolUtils#gradeSubmission (#9956)

https://sakaiproject.atlassian.net/browse/SAK-46453

Also adjusted the bean to use the FQDN pattern

(cherry picked from commit 3408199d9e0b99fab73f11fb278626a3f1e07941)

  1. … 3 more files in changeset.
SAK-46453 Assignment remove @Transactional from AssignmentToolUtils#gradeSubmission (#9956)

https://sakaiproject.atlassian.net/browse/SAK-46453

Also adjusted the bean to use the FQDN pattern

(cherry picked from commit 3408199d9e0b99fab73f11fb278626a3f1e07941)

  1. … 3 more files in changeset.
SAK-46453 Assignment remove @Transactional from AssignmentToolUtils#gradeSubmission (#9956)

https://sakaiproject.atlassian.net/browse/SAK-46453

Also adjusted the bean to use the FQDN pattern

  1. … 3 more files in changeset.
SAK-46435 Assignment students grade is not visible after it has been released (#9944)

https://sakaiproject.atlassian.net/browse/SAK-46435

(cherry picked from commit 9bb67b9537044fb851f3d9cc6000f488aab9e8b4)

(cherry picked from commit 2ee0412269ec0da1711722ad616f6830d756cfe5)

SAK-46435 Assignment students grade is not visible after it has been released (#9944)

https://sakaiproject.atlassian.net/browse/SAK-46435

(cherry picked from commit 9bb67b9537044fb851f3d9cc6000f488aab9e8b4)

SAK-46192 - Refactor Assignments / LTI External Tools For Sakai 21/22 (#9769)

The LTI support for Sakai 21 - worked, but there are a number of places where the Assignments shows information in the UI or is missing information in the UI that makes it hard to use. The basic problem was that all of the handling of scores in Sakai for LTI tools was handled by the Gradebook.  This made much of the Assignments workflow in Sakai pointless or badly broken for LTI Assignments.

The big picture of this change is that for LTI tools placed in Assignments, the grade flow is to/from the Assignments service no longer the grade book service but instead the assignment service and assignments sends grades to the gradebook using its internal logic.  With that change, there are current and emergent LTI grade flow features like activityStatus, gradingStatus, and the submission review launch that Sakai can now support with this change.

This is a dramatic improvement of the LTI integration into Assignments but the good news is that there are no data model changes and this should back port to Sakai 21 nicely.

    • -162
    • +170
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -12
    • +18
    ./vm/assignment/chef_assignments_instructor_view_assignment.vm
    • -18
    • +32
    ./vm/assignment/chef_assignments_student_view_submission.vm
  1. … 35 more files in changeset.
SAK-43155 Assignments Work Log Feature (#9888)

    • -0
    • +36
    ./vm/assignment/assignment_macros.vm
    • -1
    • +9
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -2
    • +2
    ./vm/assignment/chef_assignments_instructor_list_deleted_assignments.vm
    • -14
    • +48
    ./vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -0
    • +54
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -0
    • +39
    ./vm/assignment/chef_assignments_instructor_preview_assignment.vm
    • -6
    • +6
    ./vm/assignment/chef_assignments_instructor_reorder_assignment.vm
    • -10
    • +10
    ./vm/assignment/chef_assignments_instructor_report_submissions.vm
    • -1
    • +34
    ./vm/assignment/chef_assignments_instructor_student_list_submissions.vm
    • -0
    • +39
    ./vm/assignment/chef_assignments_instructor_view_assignment.vm
    • -0
    • +19
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
  1. … 32 more files in changeset.
SAK-44930 Turnitin options should not be displayed when alert appears when posting an assignment (#9905)

(cherry picked from commit 3e933d34acedff5e02c116e924197cc1b6c3fd2a)

    • -1
    • +1
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
SAK-44930 Turnitin options should not be displayed when alert appears when posting an assignment (#9905)

    • -1
    • +1
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
SAK-40813 Add assignment extension feature (#7754)

This feature allows an instructor to provide a new accept until date for

a student that did not submit an assignment in time. This new date only

applies for one submission by the student. After that, the normal resubmission

process takes over.

Co-authored-by: kozar <jkozar2@udayton.edu>

    • -1
    • +49
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -0
    • +11
    ./vm/assignment/chef_assignments_student_view_submission.vm
  1. … 6 more files in changeset.
SAK-40738 CKEditor autosave alerts about saved text for ckeditor other than the one that originated the autosave (#9857)

    • -0
    • +5
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -0
    • +6
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -0
    • +5
    ./vm/assignment/chef_assignments_student_view_submission.vm
  1. … 50 more files in changeset.
Revert "SAK-43155: Worklog tab in assignments (#8996)"

This reverts commit 27d0a9664f0b062ad696590bb62e74125c5d8165.

    • -36
    • +0
    ./vm/assignment/assignment_macros.vm
    • -9
    • +1
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -2
    • +2
    ./vm/assignment/chef_assignments_instructor_list_deleted_assignments.vm
    • -48
    • +14
    ./vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -54
    • +0
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -39
    • +0
    ./vm/assignment/chef_assignments_instructor_preview_assignment.vm
    • -6
    • +6
    ./vm/assignment/chef_assignments_instructor_reorder_assignment.vm
    • -10
    • +10
    ./vm/assignment/chef_assignments_instructor_report_submissions.vm
    • -34
    • +1
    ./vm/assignment/chef_assignments_instructor_student_list_submissions.vm
    • -39
    • +0
    ./vm/assignment/chef_assignments_instructor_view_assignment.vm
    • -19
    • +0
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
  1. … 31 more files in changeset.
Revert "SAK-43155: Worklog tab in assignments (#8996)"

This reverts commit 27d0a9664f0b062ad696590bb62e74125c5d8165.

    • -36
    • +0
    ./vm/assignment/assignment_macros.vm
    • -9
    • +1
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -2
    • +2
    ./vm/assignment/chef_assignments_instructor_list_deleted_assignments.vm
    • -48
    • +14
    ./vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -54
    • +0
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -39
    • +0
    ./vm/assignment/chef_assignments_instructor_preview_assignment.vm
    • -6
    • +6
    ./vm/assignment/chef_assignments_instructor_reorder_assignment.vm
    • -10
    • +10
    ./vm/assignment/chef_assignments_instructor_report_submissions.vm
    • -34
    • +1
    ./vm/assignment/chef_assignments_instructor_student_list_submissions.vm
    • -39
    • +0
    ./vm/assignment/chef_assignments_instructor_view_assignment.vm
    • -19
    • +0
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
  1. … 31 more files in changeset.
SAK-43155: Worklog tab in assignments (#8996)

* SAK-43155: Worklog tab in assignments

* SAK-43155: Resolved Codacy Issues

* SAK-43155: solving timesheet calendar not saving picked date

* SAK-43155 fixing core comments

* SAK-43155 fixing more core comments

* fixing json serializer error messages

* SAK-43155: Resolve Issues Hibernate

* SAK-43155: Resolved Issue sakai-reference

* SAK-43155: Resolved test JUNIT

* SAK-43155: Resolved *.vm issues

* correctTime -> timeHasCorrectFormat

* regTime -> duration. No el nombre de la columna de BBDD, sino la variable relacionada

* asnComment -> comment. No el nombre de la columna de BBDD, sino la variable relacionada

* Cambio de String a Long

* Mover pattern al constructor

* if para evitar NPE

* Cambios en columnas de BBDD

* Quitar findFirst()

* AssignmentService. Nomenclatura de metodos y context -> siteId

* deleteTimesheet. se obtiene contexto desde timeSheet antes de revisar permisos

* Eliminar getSubmissionSubmitter y findSubmissionSubmitter

* Cambios de Fish en javascript

* ultimos retoques

* SAK-43155: Resolved ALL remaining issues

* SAK-43155: Resolved TEST problems

* Update assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java

* Update assignment/tool/src/webapp/js/assignments.js

* Update assignment/tool/src/webapp/js/studentViewSubmission.js

* Update assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java

* changes tuesday sept 28

Co-authored-by: Victor <Victor@155.54.67.215>

Co-authored-by: victorGomollon <victor.gomollon@ticarum.es>

Co-authored-by: victorGomollon <58029414+victorGomollon@users.noreply.github.com>

Co-authored-by: Adrian Fish <adrian.r.fish@gmail.com>

    • -0
    • +36
    ./vm/assignment/assignment_macros.vm
    • -1
    • +9
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -2
    • +2
    ./vm/assignment/chef_assignments_instructor_list_deleted_assignments.vm
    • -14
    • +48
    ./vm/assignment/chef_assignments_instructor_list_submissions.vm
    • -0
    • +54
    ./vm/assignment/chef_assignments_instructor_new_edit_assignment.vm
    • -0
    • +39
    ./vm/assignment/chef_assignments_instructor_preview_assignment.vm
    • -6
    • +6
    ./vm/assignment/chef_assignments_instructor_reorder_assignment.vm
    • -10
    • +10
    ./vm/assignment/chef_assignments_instructor_report_submissions.vm
    • -1
    • +34
    ./vm/assignment/chef_assignments_instructor_student_list_submissions.vm
    • -0
    • +39
    ./vm/assignment/chef_assignments_instructor_view_assignment.vm
    • -0
    • +19
    ./vm/assignment/chef_assignments_student_confirm_submission.vm
  1. … 31 more files in changeset.
SAK-43911 Drag and Drop Reorder lists should display a grabbing cursor (#9393)

    • -1
    • +1
    ./vm/assignment/chef_assignments_instructor_reorder_assignment.vm
  1. … 4 more files in changeset.
SAK-46298 Assignments - Student's inline submission text is not submitted for content-review when using the Upload All feature (#9851)

    • -2
    • +10
    ./vm/assignment/chef_assignments_instructor_uploadAll.vm
  1. … 3 more files in changeset.
SAK-46133 Assignments-Video Recording: move focus to buttons below video when recording starts

SAK-46169 - Assignments - submitted attachment lists include "Inline Submission.html" which is an implementation detail (#9768)

    • -8
    • +1
    ./vm/assignment/chef_assignments_instructor_grading_submission.vm
    • -1
    • +2
    ./vm/assignment/chef_assignments_instructor_preview_grading_submission.vm
    • -2
    • +3
    ./vm/assignment/chef_assignments_student_view_submission_confirmation.vm
  1. … 2 more files in changeset.
SAK-45409 Honor pledge blocks access to closed assignments

(cherry picked from commit 4d50591f2b3b80b8ac21eba92f6647bbef18b234)

  1. … 1 more file in changeset.
SAK-45409 Honor pledge blocks access to closed assignments

  1. … 1 more file in changeset.
SAK-46189 Reset group locking flag in template foreach iteration over groups

(cherry picked from commit b4dd6a4ecbbf3fb540bfc039ff4a8818bd13e467)

SAK-46189 Reset group locking flag in template foreach iteration over groups

SAK-46189 Reset group locking flag in template foreach iteration over groups

(cherry picked from commit b4dd6a4ecbbf3fb540bfc039ff4a8818bd13e467)

SAK-46179 Assignments - Peer Review - no primary action button, button order questionable

(cherry picked from commit 91ca52fe5ae3b7c827cd6507327bcc83836a6c88)

SAK-46179 Assignments - Peer Review - no primary action button, button order questionable

SAK-46179 Assignments - Peer Review - no primary action button, button order questionable

(cherry picked from commit 91ca52fe5ae3b7c827cd6507327bcc83836a6c88)

SAK-44872 - Remove FCKEditor from the build.

  1. … 562 more files in changeset.