Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
SAK-46192 - Refactor Assignments / LTI External Tools For Sakai 21/22 (#9769)

The LTI support for Sakai 21 - worked, but there are a number of places where the Assignments shows information in the UI or is missing information in the UI that makes it hard to use. The basic problem was that all of the handling of scores in Sakai for LTI tools was handled by the Gradebook.  This made much of the Assignments workflow in Sakai pointless or badly broken for LTI Assignments.

The big picture of this change is that for LTI tools placed in Assignments, the grade flow is to/from the Assignments service no longer the grade book service but instead the assignment service and assignments sends grades to the gradebook using its internal logic.  With that change, there are current and emergent LTI grade flow features like activityStatus, gradingStatus, and the submission review launch that Sakai can now support with this change.

This is a dramatic improvement of the LTI integration into Assignments but the good news is that there are no data model changes and this should back port to Sakai 21 nicely.

  1. … 41 more files in changeset.
SAK-43155 Assignments Work Log Feature (#9888)

  1. … 46 more files in changeset.
SAK-46359 Filter out null feedback attachments for grader (#9892)

https://jira.sakaiproject.org/browse/SAK-46359

Revert "SAK-43155: Worklog tab in assignments (#8996)"

This reverts commit 27d0a9664f0b062ad696590bb62e74125c5d8165.

  1. … 45 more files in changeset.
Revert "SAK-43155: Worklog tab in assignments (#8996)"

This reverts commit 27d0a9664f0b062ad696590bb62e74125c5d8165.

  1. … 45 more files in changeset.
SAK-43155: Worklog tab in assignments (#8996)

* SAK-43155: Worklog tab in assignments

* SAK-43155: Resolved Codacy Issues

* SAK-43155: solving timesheet calendar not saving picked date

* SAK-43155 fixing core comments

* SAK-43155 fixing more core comments

* fixing json serializer error messages

* SAK-43155: Resolve Issues Hibernate

* SAK-43155: Resolved Issue sakai-reference

* SAK-43155: Resolved test JUNIT

* SAK-43155: Resolved *.vm issues

* correctTime -> timeHasCorrectFormat

* regTime -> duration. No el nombre de la columna de BBDD, sino la variable relacionada

* asnComment -> comment. No el nombre de la columna de BBDD, sino la variable relacionada

* Cambio de String a Long

* Mover pattern al constructor

* if para evitar NPE

* Cambios en columnas de BBDD

* Quitar findFirst()

* AssignmentService. Nomenclatura de metodos y context -> siteId

* deleteTimesheet. se obtiene contexto desde timeSheet antes de revisar permisos

* Eliminar getSubmissionSubmitter y findSubmissionSubmitter

* Cambios de Fish en javascript

* ultimos retoques

* SAK-43155: Resolved ALL remaining issues

* SAK-43155: Resolved TEST problems

* Update assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java

* Update assignment/tool/src/webapp/js/assignments.js

* Update assignment/tool/src/webapp/js/studentViewSubmission.js

* Update assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java

* changes tuesday sept 28

Co-authored-by: Victor <Victor@155.54.67.215>

Co-authored-by: victorGomollon <victor.gomollon@ticarum.es>

Co-authored-by: victorGomollon <58029414+victorGomollon@users.noreply.github.com>

Co-authored-by: Adrian Fish <adrian.r.fish@gmail.com>

  1. … 45 more files in changeset.
SAK-45269 Grader: remove attachments with special characters in name (#9314)

2 problems here: url encoding and reference prefix.

  1. … 3 more files in changeset.
SAK-45269 Grader: remove attachments with special characters in name (#9314)

2 problems here: url encoding and reference prefix.

(cherry picked from commit f2df5423f9d267a58660ccb8ea52bf81614284f9)

  1. … 3 more files in changeset.
SAK-45269 Grader: remove attachments with special characters in name (#9314)

2 problems here: url encoding and reference prefix.

(cherry picked from commit f2df5423f9d267a58660ccb8ea52bf81614284f9)

  1. … 3 more files in changeset.
SAK-45686 Fixed NPE causing missing submission in new grader (#9409)

https://jira.sakaiproject.org/browse/SAK-45686

(cherry picked from commit 2df610ad4fafd9b0152821bc39e4126670e2a7f0)

SAK-45686 Fixed NPE causing missing submission in new grader (#9409)

https://jira.sakaiproject.org/browse/SAK-45686

SAK-45686 Fixed NPE causing missing submission in new grader (#9409)

https://jira.sakaiproject.org/browse/SAK-45686

(cherry picked from commit 2df610ad4fafd9b0152821bc39e4126670e2a7f0)

SAK-45669 Format grader dates using user preferences (#9401)

* SAK-45669 Format grader dates using user preferences

https://jira.sakaiproject.org/browse/SAK-45669

* Update AssignmentService.java

Co-authored-by: Sam Ottenhoff <ottenhoff@longsight.com>

(cherry picked from commit b508b34fefd30b1eef6990e3b16ab584a4c8c72e)

  1. … 11 more files in changeset.
SAK-45669 Format grader dates using user preferences (#9401)

* SAK-45669 Format grader dates using user preferences

https://jira.sakaiproject.org/browse/SAK-45669

* Update AssignmentService.java

Co-authored-by: Sam Ottenhoff <ottenhoff@longsight.com>

  1. … 11 more files in changeset.
SAK-45669 Format grader dates using user preferences (#9401)

* SAK-45669 Format grader dates using user preferences

https://jira.sakaiproject.org/browse/SAK-45669

* Update AssignmentService.java

Co-authored-by: Sam Ottenhoff <ottenhoff@longsight.com>

(cherry picked from commit b508b34fefd30b1eef6990e3b16ab584a4c8c72e)

  1. … 11 more files in changeset.
SAK-45305 Check for inactive members in new grader (#9327)

https://jira.sakaiproject.org/browse/SAK-45305

(cherry picked from commit 82ed6e85bce765e9780395595f3b7a509a7f79cd)

SAK-45305 Check for inactive members in new grader (#9327)

https://jira.sakaiproject.org/browse/SAK-45305

SAK-45305 Check for inactive members in new grader (#9327)

https://jira.sakaiproject.org/browse/SAK-45305

(cherry picked from commit 82ed6e85bce765e9780395595f3b7a509a7f79cd)

SAK-45575 Only convert attachments from assignment submissions (#9337)

https://jira.sakaiproject.org/browse/SAK-45575

(cherry picked from commit 0d0cd1d16a6fa6e306016591b57a72e3d36427ed)

  1. … 5 more files in changeset.
SAK-45575 Only convert attachments from assignment submissions (#9337)

https://jira.sakaiproject.org/browse/SAK-45575

  1. … 5 more files in changeset.
SAK-44183 Let grader preview images (#8521) (#9242)

https://jira.sakaiproject.org/browse/SAK-44183

(cherry picked from commit d1f604f7a1b30b5bd30adacca92156ac9600a3c2)

  1. … 3 more files in changeset.
SAK-44684 Allow draft submissions to be viewed in grader (#9097)

https://jira.sakaiproject.org/browse/SAK-44684

(cherry picked from commit 1546f67e37245eb1a4da165da4e0390317af557c)

  1. … 7 more files in changeset.
SAK-44684 Allow draft submissions to be viewed in grader (#9097)

https://jira.sakaiproject.org/browse/SAK-44684

(cherry picked from commit 1546f67e37245eb1a4da165da4e0390317af557c)

  1. … 7 more files in changeset.
SAK-44684 Allow draft submissions to be viewed in grader (#9097)

https://jira.sakaiproject.org/browse/SAK-44684

  1. … 7 more files in changeset.
SAK-45039 Improve number of submission in grades widget (#9051)

https://jira.sakaiproject.org/browse/SAK-45039

This change results in the grades api endpoint asking assignments or

samigo for the number of submissions and graded, when the GB assignment

is externally maintained.

  1. … 5 more files in changeset.
SAK-45023 Don't return submitterless submissions in new grader (#9021)

https://jira.sakaiproject.org/browse/SAK-45023

This can arise if you remove a submission user from your LDAP, for instance.

(cherry picked from commit 86e8e0f3928be96baa366566c7d136db3dedaa7b)

SAK-45023 Don't return submitterless submissions in new grader (#9021)

https://jira.sakaiproject.org/browse/SAK-45023

This can arise if you remove a submission user from your LDAP, for instance.

SAK-45023 Don't return submitterless submissions in new grader (#9021)

https://jira.sakaiproject.org/browse/SAK-45023

This can arise if you remove a submission user from your LDAP, for instance.

(cherry picked from commit 86e8e0f3928be96baa366566c7d136db3dedaa7b)

SAK-44850 Set sortName to displayName when anon grading (#8954)

https://jira.sakaiproject.org/browse/SAK-44850

(cherry picked from commit 4147df455849172bf7ac5ab3948361136171a34b)

SAK-44850 Set sortName to displayName when anon grading (#8954)

https://jira.sakaiproject.org/browse/SAK-44850

(cherry picked from commit 4147df455849172bf7ac5ab3948361136171a34b)