Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Backport of SAK-40092 for 11.x (#5713)

  1. … 3 more files in changeset.
SAK-33960 - Instructor is not able to see assignments of his group (#5345)

  1. … 1 more file in changeset.
SAK-33546 - 11 patch Release grade fails problem if there is no grade entered (#5217)

SAK-33395 Assignments RedirectingAssignmentEntityServlet.MySecurityAdvisor equals() (#4823)

(cherry picked from commit 48c88a734bcb544fefaf7666b65cb1dc54f266ca)

    • -45
    • +46
    ./tool/RedirectingAssignmentEntityServlet.java
SAK-33396 Push and Pop a named advisor (#4825) SAK-34018 Assignments grade provider advisor order incorrect (#5403) (cherry picked from commit ea0066ebb60d1cb6189c58c2f2dffade91a6a87c) (cherry picked from commit 7cc34f1fb46c10223b22557133e96fd3133b9156)

    • -5
    • +8
    ./entityproviders/AssignmentEntityProvider.java
  1. … 1 more file in changeset.
SAK-32101 Assignments service refactor (#4712)

* SAK-32101 refactor PeerAssessment to use JPA

* SAK-32101 rename Assignment in edu service to GradebookAssignment

* SAK-32101 Persistence mostly completed

* SAK-32101 Add JSON/XML serialization to persistence

* SAK-32101 AssignmentService

* SAK-32101 AssignmentService 2

* Adapted service and persistence entities to work with existing services.

* AssignmentService Unit Tests setup with Repository

* More additions to assignment service

* Lots of new stuff but mostly Reference Reckoner.

* updated test

* remove assignmentReferenceUtil and use AssignmentReferenceReckoner

* Add test for removing assignments

* remove BaseAssignmentService after rebase

* updateAssigment test

* addSubmission implemented with test

* Rearrange persistence class inheritance

* Added removeSubmission and tests

* flush session after merge

* minor change

* updated persistence methods

* finished adding remaining methods to service

* AssignmentAction refactor part duo

* AssignmentsAction refactor part 3

* AssignmentAction refactor completed

* More AssignmentsAction refactor

* AssignmentAction builds

* Refactor around sakai in relation to AssignmentsService

* Assignment template fixes part 1

* More template fixes and content review added back

* Few more refactors after sync with master

* Rearrange project structure

* ReFormatting

* Code refactor

* AssignmentAction and template fixes

* Fixed hideduedate, modified dates, author is populated

* Reformatting

* Assignment to GradebookAssignment refactor

* Assignment to GradebookAssignment refactor 2

    • -997
    • +0
    ./entityproviders/AssignmentEntityProvider.java
    • -200
    • +0
    ./taggable/tool/DecoratedTaggingProvider.java
    • -17987
    • +0
    ./tool/AssignmentAction.java
    • -272
    • +0
    ./tool/RedirectingAssignmentEntityServlet.java
  1. … 359 more files in changeset.
SAK-32500 In/New is affected by instructor submission while in "Student View" or in "Enter access View" in the Assignment tool (#4662)

* SAK-32500 updated AssignmentAction.java, chef_assignments_list_assignments.vm

* SAK-32500 updated AssignmentAction.java, chef_assignments_list_assignments.vm

  1. … 1 more file in changeset.
SAK-32475: duplicated too many decimal places error message (#4318)

SAK-32461 - Add unit test for Assignment Action (scalePointGrade): (#4305)

* SAK-32461 - Add unit test for Assignment Action (scalePointGrade):

* Fixed tabs/spaces indentation in test.

* SAK-32461 Change of test to use Fake SessionState.

* SAK-32461 Change of test to use Fake SessionState.

  1. … 3 more files in changeset.
SAK-32445 Fix Assignments Grading with ".X" Grades (#4250)

When an assignment was saved with a grade such as ".7" with less

than the number of allowed decimal places (2 is default), the grade was

saved as "0.07"). This changes causes it to be saved as "0.70" by

padding entered scores with trailing 0s as appropriate.

(cherry picked from commit 4ffb8957653d7c3cbf98ad6666742a1982737ace)

SAK-32445 Fix Assignments Grading with ".X" Grades (#4250)

When an assignment was saved with a grade such as ".7" with less

than the number of allowed decimal places (2 is default), the grade was

saved as "0.07"). This changes causes it to be saved as "0.70" by

padding entered scores with trailing 0s as appropriate.

SAK-32461 - Add unit test for Assignment Action (scalePointGrade):

  1. … 2 more files in changeset.
SAK-32405 - Content Review - VeriCite - Student Preview of plag score (#4191)

  1. … 16 more files in changeset.
Revert "SAK-32174 Improvements over group blocking feature (#3947)"

This reverts commit cd50a6df85f8707b053db1d54a9e93cbae1eaec3.

  1. … 22 more files in changeset.
SAK-32350 Don’t fail attachments in peer review mode. (#4116)

When an assignment is in peer review student review mode there is an option for the student to provide attachments for their review, however we were attempting to check these with content-review which isn’t correct (and was failing). So this check has been disabled when in peer review mode.

SAK-32350 Don’t fail attachments in peer review mode. (#4116)

When an assignment is in peer review student review mode there is an option for the student to provide attachments for their review, however we were attempting to check these with content-review which isn’t correct (and was failing). So this check has been disabled when in peer review mode.

SAK-32320 org.sakaiproject.util.StringUtil.trimToNullLower() -> org.apache.commons.lang3.StringUtils.trimToNullLower() (#4073)

  1. … 20 more files in changeset.
Allow setting hidden defaults for plagiarism detection (#4071)

Previously, if a field was hidden from the the instructor, then it wouldn't

get set. Now we'll set the value to the default from the configs

- contentreview.option.exclude_quoted == To show field to instructor

- contentreview.option.exclude_quoted.default == default value

- contentreview.option.exclude_self_plag == To show field to instructor

- contentreview.option.exclude_self_plag.default == default value

- contentreview.option.store_inst_index == To show field to instructor

- contentreview.option.store_inst_index.default == default value

SAK-32276 Cope with no CandidateDetailsProvider (#4054)

Assignments was failing (NPE) when viewing submissions when there wasn’t a candidate details provider set. Now when there’s no provider we don’t ask it for any notes.

SAK-32174 Improvements over group blocking feature (#3947)

(cherry picked from commit 06e5379fba5e93d88ec7492fa32385ae6ca2408d)

  1. … 22 more files in changeset.
SAK-32174 Improvements over group blocking feature (#3947)

  1. … 22 more files in changeset.
SAK-32184 Remove redundant -pack projects. (#3912)

* SAK-32184 Remove redundant -pack projects.

Make most -impl projects of type sakai-component which means we have

less modules in the build and our build is smaller.

There were some references left to the -impl projects from things other than -pack projects. These have been refactored, either by moving the code, removing the unused dependency or in a couple of cases re-writing a tiny bit of code.

When deploying don’t create lots of small files which slows down the deployment for me.

    • -7
    • +16
    ./entityproviders/AssignmentEntityProvider.java
  1. … 522 more files in changeset.
SAK-32160 Use Font-Awesome icons in content review implementations (#3869)

  1. … 17 more files in changeset.
SAK-31923 Exporting to csv always use comma as separator (#3825)

* SAK-31923 Exporting to csv always use comma as separator

* Update AssignmentService.java

  1. … 6 more files in changeset.
SAK-27980 Fix for merge back to 11.

This is because on trunk the covers have been removed, but they are still there on the stable branch.

SAK-31405 Allow institution provided anonymous IDs (+ additional candidate notes) (#3331)

* SAK-31404, SAK-31405 and SAK-31406

anonymous coursework project

- Manage Candidate ID and additional notes.

- Sample, html, zip and more

* Add support to LDAP multi-valued properties

* SAK-31404, SAK-31405 and SAK-31406 : Move providers out of the kernel.

The kernel shouldn't depend on anything else in Sakai.

* SAK-31404, SAK-31405 and SAK-31406 : Don’t require a candidate details provider.

Now we make the provider optional. I did look at making the field Optional<CandidateDetailsProvider> but it needs more work. This is desirable so that it’s clearer to all callers of methods on this field that they need to handle the case when it’s not set (null).

It would be better to hide all this behind the API so that the tool doesn’t deal with it at all.

* SAK-31404, SAK-31405 and SAK-31406 : We expect some users to not be found.

Don’t log at warn but at debug when users aren’t found as this is an expected case.

* SAK-31404, SAK-31405 and SAK-31406 : Add the logger back in so it compiles.

* SAK-31404, SAK-31405 and SAK-31406

- Switched ValueEncryptionUtilities to be a service so that it’s easier

to switch to a static key if we need to in the future for performance

reasons.

- Add padding to values so that all encrypted values will be the same

length.

- Added MappingDetailProvider

* SAK-31405

* additional notes added to :

- submission grading screen (only for no group assignments)

- grade report screen : html table

- grade report screen : xls export

- submission list -> download all -> grades file inside zip (csv, xls)

* candidateDetailProvider is no longer injected in vm files (also site).

Now we use notesMap

* SAK-31405 Allow forcing of anonymous assignments.

Now we make the provider optional. I did look at making the field Optional<CandidateDetailsProvider> but it needs more work. This is desirable so that it’s clearer to all callers of methods on this field that they need to handle the case when it’s not set (null).

It would be better to hide all this behind the API so that the tool doesn’t deal with it at all.

Don’t log at warn but at debug when users aren’t found as this is an expected case.

Also switched ValueEncryptionUtilities to be a service so that it’s easier to switch to a static key if we need to in the future for performance reasons.

Add padding to values so that all encrypted values will be the same length.

* SAK-31405 Make the sample data display nicer.

This allows wrapping in the interface and doesn’t make it unusable.

Also stop the NPE by trying to encrypt null.

* SAK-31405 Fix indentation on API

* SAK-31405 Added more documentation and a readme.md

This is to make it easier to understand how this provider is designed to work.

* SAK-31405 Switch the SLF4J from commons-logging.

  1. … 35 more files in changeset.
SAK-27980 Removing a group will orphan the group's assignment submission (#3826)

  1. … 15 more files in changeset.
SAK-27980 Removing a group will orphan the group's assignment submission (#3826)

  1. … 15 more files in changeset.
SAK-29791 Remove covers from assignments. (#3437)

* SAK-29791 Remove covers from /assignment

This highlights that there were some differences between the API and cover as the exceptions were different.

Updated message bundle for assignments.

Validate our dependencies in init()

Make sure we have all the services we need.

    • -8
    • +10
    ./entityproviders/AssignmentEntityProvider.java
    • -575
    • +479
    ./tool/AssignmentAction.java
  1. … 31 more files in changeset.
SAK-29928 Switch to java internal zip and Files.copy methods (#3692)